Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

RussellSpitzer merged PR #11444: URL: https://github.com/apache/iceberg/pull/11444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

RussellSpitzer commented on PR #11444: URL: https://github.com/apache/iceberg/pull/11444#issuecomment-2462576360 Thanks @aihuaxu , @Fokko and @nastra for reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

RussellSpitzer commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1831723691 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -95,14 +140,21 @@ public void testUnsupportedInitialDefault(int formatVersion) { f

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

RussellSpitzer commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1831723193 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -18,32 +18,27 @@ */ package org.apache.iceberg; +import static org.apache.iceberg.Schema.DE

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

nastra commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1830491512 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -64,27 +59,77 @@ public class TestSchema { .withWriteDefault("--") .build(

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

nastra commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1830494527 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -18,32 +18,27 @@ */ package org.apache.iceberg; +import static org.apache.iceberg.Schema.DEFAULT_VA

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

nastra commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1830492332 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -64,27 +59,77 @@ public class TestSchema { .withWriteDefault("--") .build(

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

nastra commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1830492172 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -64,27 +59,77 @@ public class TestSchema { .withWriteDefault("--") .build(

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

nastra commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1830490735 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -95,14 +140,21 @@ public void testUnsupportedInitialDefault(int formatVersion) { formatVer

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

nastra commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1830490067 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -95,14 +140,21 @@ public void testUnsupportedInitialDefault(int formatVersion) { formatVer

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

RussellSpitzer commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1828047216 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -21,29 +21,30 @@ import static org.assertj.core.api.Assertions.assertThatCode; import static o

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

aihuaxu commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1826485532 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -64,27 +65,77 @@ public class TestSchema { .withWriteDefault("--") .build

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

aihuaxu commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1826348277 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -21,29 +21,30 @@ import static org.assertj.core.api.Assertions.assertThatCode; import static org.asse

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

RussellSpitzer commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1826341709 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -21,29 +21,30 @@ import static org.assertj.core.api.Assertions.assertThatCode; import static o

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

RussellSpitzer commented on PR #11444: URL: https://github.com/apache/iceberg/pull/11444#issuecomment-2452666774 Test results look like  -- This is an automated message from the Apache Git

Re: [PR] API: Removes Explicit Parameterization of Schema Tests [iceberg]

RussellSpitzer commented on code in PR #11444: URL: https://github.com/apache/iceberg/pull/11444#discussion_r1826341442 ## api/src/test/java/org/apache/iceberg/TestSchema.java: ## @@ -21,29 +21,30 @@ import static org.assertj.core.api.Assertions.assertThatCode; import static o