RussellSpitzer commented on code in PR #11444:
URL: https://github.com/apache/iceberg/pull/11444#discussion_r1831723691
##########
api/src/test/java/org/apache/iceberg/TestSchema.java:
##########
@@ -95,14 +140,21 @@ public void testUnsupportedInitialDefault(int
formatVersion) {
formatVersion);
}
- @Test
- public void testSupportedInitialDefault() {
- assertThatCode(() -> Schema.checkCompatibility(INITIAL_DEFAULT_SCHEMA, 3))
+ private static int[] testSupportedInitialDefault =
+ IntStream.rangeClosed(DEFAULT_VALUES_MIN_FORMAT_VERSION,
MAX_FORMAT_VERSION).toArray();
+
+ @ParameterizedTest
+ @FieldSource
+ public void testSupportedInitialDefault(int formatVersion) {
+ assertThatCode(() -> Schema.checkCompatibility(INITIAL_DEFAULT_SCHEMA,
formatVersion))
.doesNotThrowAnyException();
}
+ private static int[] testSupportedWriteDefault =
+ IntStream.rangeClosed(1, MAX_FORMAT_VERSION).toArray();
+
@ParameterizedTest
- @ValueSource(ints = {1, 2, 3})
+ @FieldSource
Review Comment:
That's fine, I kind of like how it just uses the exact same name though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
