Re: [PR] API: Move Variant interfaces and serialized implementations to API [iceberg]

2025-02-21 Thread via GitHub
rdblue merged PR #12374: URL: https://github.com/apache/iceberg/pull/12374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] API: Move Variant interfaces and serialized implementations to API [iceberg]

2025-02-21 Thread via GitHub
rdblue commented on PR #12374: URL: https://github.com/apache/iceberg/pull/12374#issuecomment-2675800286 Thanks for the reviews, @danielcweeks and @aihuaxu! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] API: Move Variant interfaces and serialized implementations to API [iceberg]

2025-02-21 Thread via GitHub
rdblue commented on PR #12374: URL: https://github.com/apache/iceberg/pull/12374#issuecomment-2675799837 > I think the one preference I would have is that if we're moving some of the type info (basic/logical/physical), I feel it would be better to move it inner enum to Variant interface so