Re: [PR] API: Define RepairManifests action interface [iceberg]

flyrain commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2679510929 @danielcweeks thanks for the confirmation. One of use cases is to check the integrity of a copied table from different places. The use cases are increasing as `rewriteTablePath` was out

Re: [PR] API: Define RepairManifests action interface [iceberg]

danielcweeks commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2675997406 > Do we still pursue this? Yes, @amogh-jahagirdar is still looking at this and we continue to see use cases where this is necessary. -- This is an automated message from t

Re: [PR] API: Define RepairManifests action interface [iceberg]

flyrain commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2675966634 Do we still pursue this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] API: Define RepairManifests action interface [iceberg]

wypoon commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2623572958 Another question I have about duplicate entries (in the manifests) is: do their presence make the table unreadable? Or is the table still readable and it is a valid state, although undes

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2623396968 > For my edification, can someone please explain how duplicate file entries in manifests can arise? Can two entries for the same file occur in a single manifest? Can even two

Re: [PR] API: Define RepairManifests action interface [iceberg]

wypoon commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2623353054 For my edification, can someone please explain how duplicate file entries in manifests can arise? Can two entries for the same file occur in a single manifest? Can even two manifests be

[PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar opened a new pull request, #10784: URL: https://github.com/apache/iceberg/pull/10784 Co-authored-by: Mathew Fournier <160646114+tabmatfourn...@users.noreply.github.com> Refer to #10445 for more details. This change defines a RepairManifest Action interface wher

Re: [PR] API: Define RepairManifests action interface [iceberg]

github-actions[bot] commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2480862630 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] API: Define RepairManifests action interface [iceberg]

github-actions[bot] closed pull request #10784: API: Define RepairManifests action interface URL: https://github.com/apache/iceberg/pull/10784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] API: Define RepairManifests action interface [iceberg]

github-actions[bot] commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2466519748 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2316733589 > Makes sense @amogh-jahagirdar ! > > > @szehon-ho I actually had a question on the snapshot repair, based on the description the goal of that is to repair snapshot summa

Re: [PR] API: Define RepairManifests action interface [iceberg]

szehon-ho commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2275063775 Makes sense @amogh-jahagirdar ! > @szehon-ho I actually had a question on the snapshot repair, based on the description the goal of that is to repair snapshot summary stats wh

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2274937702 @szehon-ho I think I agree that the use cases presented are legitimate repair cases however I'm not sure that we should be combining all of them into a single `RepairTable` pro

Re: [PR] API: Define RepairManifests action interface [iceberg]

szehon-ho commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2272369995 Another one is : https://github.com/apache/iceberg/issues/10535 corrupt manifest file. It may make sense to repair those as well. So in summary: - repairSnapshotMetadata (re

Re: [PR] API: Define RepairManifests action interface [iceberg]

szehon-ho commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2272138130 Hi, @amogh-jahagirdar @RussellSpitzer had a question. I think one motivation was to handle CheckSnapshotIntegrity API proposed in https://github.com/apache/iceberg/pull/10642

Re: [PR] API: Define RepairManifests action interface [iceberg]

nastra commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1705661534 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] API: Define RepairManifests action interface [iceberg]

nastra commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1705661534 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1702223635 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1702225042 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1702188447 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] API: Define RepairManifests action interface [iceberg]

danielcweeks commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1700788963 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] API: Define RepairManifests action interface [iceberg]

danielcweeks commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1700780360 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] API: Define RepairManifests action interface [iceberg]

danielcweeks commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1700759862 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] API: Define RepairManifests action interface [iceberg]

szehon-ho commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1700670303 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1700627651 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1699116602 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] API: Define RepairManifests action interface [iceberg]

szehon-ho commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1695628950 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] API: Define RepairManifests action interface [iceberg]

RussellSpitzer commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1693578847 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] API: Define RepairManifests action interface [iceberg]

RussellSpitzer commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1693576095 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] API: Define RepairManifests action interface [iceberg]

RussellSpitzer commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1693574845 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] API: Define RepairManifests action interface [iceberg]

RussellSpitzer commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1693574574 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] API: Define RepairManifests action interface [iceberg]

nastra commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1692959163 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] API: Define RepairManifests action interface [iceberg]

nastra commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1692959610 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1691918624 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1691911018 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar commented on code in PR #10784: URL: https://github.com/apache/iceberg/pull/10784#discussion_r1691911018 ## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[PR] API: Define RepairManifests action interface [iceberg]

amogh-jahagirdar opened a new pull request, #10784: URL: https://github.com/apache/iceberg/pull/10784 Co-authored-by: Mathew Fournier <160646114+tabmatfourn...@users.noreply.github.com> Refer to #10445 for more details. This change defines a RepairManifest Action interface wher