szehon-ho commented on PR #10784: URL: https://github.com/apache/iceberg/pull/10784#issuecomment-2272138130
Hi, @amogh-jahagirdar @RussellSpitzer had a question. I think one motivation was to handle CheckSnapshotIntegrity API proposed in https://github.com/apache/iceberg/pull/10642 However in that pr, it is also checking metadata.jsons and manifest-list. for missing metadata-file locations. I think there are other cases it may be worth to repair, for example snapshot summary metadata can be repaired if they are ever out of sync (as the values are mostly updated incrementally and one bad update can cascade for subsequent snapshots). What do you guys think about a generic RepairTable, and have some analgous methods repairSnapshotSummaries or repairSnapshots ? Otherwise we may still need https://github.com/apache/iceberg/pull/10642 to do those checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
