Re: [PR] API: Add missing deprecations [iceberg]

2024-12-17 Thread via GitHub
Fokko merged PR #11734: URL: https://github.com/apache/iceberg/pull/11734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] API: Add missing deprecations [iceberg]

2024-12-17 Thread via GitHub
Fokko commented on code in PR #11734: URL: https://github.com/apache/iceberg/pull/11734#discussion_r1888171074 ## api/src/main/java/org/apache/iceberg/transforms/VoidTransform.java: ## @@ -49,6 +49,14 @@ public Void apply(S t) { private VoidTransform() {} + /** + * Tra

Re: [PR] API: Add missing deprecations [iceberg]

2024-12-09 Thread via GitHub
ebyhr commented on code in PR #11734: URL: https://github.com/apache/iceberg/pull/11734#discussion_r1877025051 ## api/src/main/java/org/apache/iceberg/transforms/UnknownTransform.java: ## @@ -33,6 +33,14 @@ public class UnknownTransform implements Transform { this.transform

Re: [PR] API: Add missing deprecations [iceberg]

2024-12-09 Thread via GitHub
Fokko commented on code in PR #11734: URL: https://github.com/apache/iceberg/pull/11734#discussion_r1876502816 ## api/src/main/java/org/apache/iceberg/transforms/Bucket.java: ## @@ -43,6 +43,12 @@ static Bucket get(int numBuckets) { return new Bucket<>(numBuckets); }

Re: [PR] API: Add missing deprecations [iceberg]

2024-12-09 Thread via GitHub
nastra commented on code in PR #11734: URL: https://github.com/apache/iceberg/pull/11734#discussion_r1876092705 ## api/src/main/java/org/apache/iceberg/transforms/Bucket.java: ## @@ -43,6 +43,12 @@ static Bucket get(int numBuckets) { return new Bucket<>(numBuckets); }

[PR] API: Add missing deprecations [iceberg]

2024-12-09 Thread via GitHub
Fokko opened a new pull request, #11734: URL: https://github.com/apache/iceberg/pull/11734 Adds some missing deprecations as based in https://github.com/apache/iceberg/pull/11691 Also, copied some deprecations from the interface to the implementations to make it more explicit. --