ebyhr commented on code in PR #11734:
URL: https://github.com/apache/iceberg/pull/11734#discussion_r1877025051
##########
api/src/main/java/org/apache/iceberg/transforms/UnknownTransform.java:
##########
@@ -33,6 +33,14 @@ public class UnknownTransform<S, T> implements Transform<S,
T> {
this.transform = transform;
}
+ /**
+ * Transforms a value to its corresponding partition value.
+ *
+ * @param value a source value
+ * @return a transformed partition value
Review Comment:
nit: This explanation looks a little misleading to me because this method
always throws an exception.
##########
api/src/main/java/org/apache/iceberg/transforms/VoidTransform.java:
##########
@@ -49,6 +49,14 @@ public Void apply(S t) {
private VoidTransform() {}
+ /**
+ * Transforms a value to its corresponding partition value.
+ *
+ * @param value a source value
+ * @return a transformed partition value
Review Comment:
nit: We could mention that this method always return null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
