RussellSpitzer commented on PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#issuecomment-2448510107
Thanks everyone - @rdblue (for original fix), @Fokko , @anuragmantri ,
@kevinjqliu , @singhpk234 , @amogh-jahagirdar For reviews!
--
This is an automated message from the Apac
RussellSpitzer merged PR #11434:
URL: https://github.com/apache/iceberg/pull/11434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
RussellSpitzer commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823318178
##
api/src/main/java/org/apache/iceberg/Schema.java:
##
@@ -586,16 +587,37 @@ private List reassignIds(List
columns, TypeUtil.GetID
* @param formatVersion
RussellSpitzer commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823317138
##
api/src/main/java/org/apache/iceberg/Schema.java:
##
@@ -586,16 +587,37 @@ private List reassignIds(List
columns, TypeUtil.GetID
* @param formatVersion
singhpk234 commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823309114
##
api/src/main/java/org/apache/iceberg/Schema.java:
##
@@ -586,16 +587,37 @@ private List reassignIds(List
columns, TypeUtil.GetID
* @param formatVersion tab
Fokko commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823307130
##
api/src/main/java/org/apache/iceberg/Schema.java:
##
@@ -54,6 +54,7 @@ public class Schema implements Serializable {
private static final Joiner NEWLINE = Joiner.
rdblue commented on PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#issuecomment-2448072176
Updated. Thanks, @RussellSpitzer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
RussellSpitzer commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823174316
##
api/src/main/java/org/apache/iceberg/Schema.java:
##
@@ -586,16 +588,37 @@ private List reassignIds(List
columns, TypeUtil.GetID
* @param formatVersion
RussellSpitzer commented on PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#issuecomment-2447996818
Tests failing are because Metadata.json also has validations for this and
this check is failing first
--
This is an automated message from the Apache Git Service.
To respond to
RussellSpitzer commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823154660
##
api/src/test/java/org/apache/iceberg/TestSchema.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
RussellSpitzer commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823152850
##
api/src/test/java/org/apache/iceberg/TestSchema.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
RussellSpitzer commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823152403
##
api/src/test/java/org/apache/iceberg/TestSchema.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
12 matches
Mail list logo
