RussellSpitzer commented on code in PR #11434:
URL: https://github.com/apache/iceberg/pull/11434#discussion_r1823318178
##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -586,16 +587,37 @@ private List<NestedField> reassignIds(List<NestedField>
columns, TypeUtil.GetID
* @param formatVersion table format version
*/
public static void checkCompatibility(Schema schema, int formatVersion) {
- // check the type in each field
+ // accumulate errors as a treemap to keep them in a reasonable order
+ Map<Integer, String> problems = Maps.newTreeMap();
Review Comment:
Or any type parameter I think ... I feel like this is a 1337code question
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
