Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-30 Thread via GitHub
nastra merged PR #8851: URL: https://github.com/apache/iceberg/pull/8851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-30 Thread via GitHub
nastra commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1376276601 ## api/src/main/java/org/apache/iceberg/view/View.java: ## @@ -111,4 +112,13 @@ default ReplaceViewVersion replaceVersion() { default UpdateLocation updateLocation()

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-30 Thread via GitHub
nastra commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1376275776 ## api/src/main/java/org/apache/iceberg/view/View.java: ## @@ -111,4 +112,13 @@ default ReplaceViewVersion replaceVersion() { default UpdateLocation updateLocation()

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
nastra commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1362309604 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -97,4 +98,9 @@ public ReplaceViewVersion replaceVersion() { public UpdateLocation updateLocation()

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
nk1506 commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1362126880 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -97,4 +98,9 @@ public ReplaceViewVersion replaceVersion() { public UpdateLocation updateLocation()

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
ajantha-bhat commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1362101911 ## api/src/main/java/org/apache/iceberg/view/View.java: ## @@ -111,4 +112,13 @@ default ReplaceViewVersion replaceVersion() { default UpdateLocation updateLocat

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
nastra commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1362046505 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -97,4 +98,9 @@ public ReplaceViewVersion replaceVersion() { public UpdateLocation updateLocation()

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
amogh-jahagirdar commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1361948344 ## api/src/main/java/org/apache/iceberg/view/View.java: ## @@ -111,4 +112,13 @@ default ReplaceViewVersion replaceVersion() { default UpdateLocation updateL

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
nk1506 commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1361819048 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -97,4 +98,9 @@ public ReplaceViewVersion replaceVersion() { public UpdateLocation updateLocation()

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
nastra commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1361897579 ## api/src/main/java/org/apache/iceberg/view/View.java: ## @@ -111,4 +112,13 @@ default ReplaceViewVersion replaceVersion() { default UpdateLocation updateLocation()

Re: [PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
ajantha-bhat commented on code in PR #8851: URL: https://github.com/apache/iceberg/pull/8851#discussion_r1361891676 ## api/src/main/java/org/apache/iceberg/view/View.java: ## @@ -111,4 +112,13 @@ default ReplaceViewVersion replaceVersion() { default UpdateLocation updateLocat

[PR] API, Core: Add uuid() to View [iceberg]

2023-10-17 Thread via GitHub
nastra opened a new pull request, #8851: URL: https://github.com/apache/iceberg/pull/8851 similar to https://github.com/apache/iceberg/pull/8800, adding UUID to the `View` API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a