nk1506 commented on code in PR #8851:
URL: https://github.com/apache/iceberg/pull/8851#discussion_r1361819048


##########
core/src/main/java/org/apache/iceberg/view/BaseView.java:
##########
@@ -97,4 +98,9 @@ public ReplaceViewVersion replaceVersion() {
   public UpdateLocation updateLocation() {
     return new SetViewLocation(ops);
   }
+
+  @Override
+  public UUID uuid() {
+    return UUID.fromString(ops.current().uuid());

Review Comment:
   nit: for few catalogs, it may go through all the refresh mechanism. I am not 
sure if we have any other better approach or not. 



##########
api/src/main/java/org/apache/iceberg/view/View.java:
##########
@@ -111,4 +112,13 @@ default ReplaceViewVersion replaceVersion() {
   default UpdateLocation updateLocation() {
     throw new UnsupportedOperationException("Updating a view's location is not 
supported");
   }
+
+  /**
+   * Returns the view's UUID
+   *
+   * @return the view's UUID

Review Comment:
   nit: tag description and summary are same. IMO, we should have one. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to