Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-12-16 Thread via GitHub
nastra commented on PR #11587: URL: https://github.com/apache/iceberg/pull/11587#issuecomment-2545378279 closing this in favor of #11620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-12-16 Thread via GitHub
nastra closed pull request #11587: API, Core: Add formatVersion() to Table URL: https://github.com/apache/iceberg/pull/11587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-11-26 Thread via GitHub
aokolnychyi commented on PR #11587: URL: https://github.com/apache/iceberg/pull/11587#issuecomment-2502200150 I think I'd prefer #11620 for now, not a strong opinion, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-11-21 Thread via GitHub
nastra commented on PR #11587: URL: https://github.com/apache/iceberg/pull/11587#issuecomment-2491230705 I've created an alternative impl to this in https://github.com/apache/iceberg/pull/11620 where we can achieve the same thing without adjusting the `Table` API. -- This is an automate

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-11-20 Thread via GitHub
amogh-jahagirdar commented on code in PR #11587: URL: https://github.com/apache/iceberg/pull/11587#discussion_r1849121688 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -212,6 +212,11 @@ public String toString() { return name(); } + @Override +

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-11-20 Thread via GitHub
nastra commented on code in PR #11587: URL: https://github.com/apache/iceberg/pull/11587#discussion_r1849692234 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -212,6 +212,11 @@ public String toString() { return name(); } + @Override + public i

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-11-19 Thread via GitHub
nastra commented on code in PR #11587: URL: https://github.com/apache/iceberg/pull/11587#discussion_r1849692234 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -212,6 +212,11 @@ public String toString() { return name(); } + @Override + public i

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-11-19 Thread via GitHub
RussellSpitzer commented on code in PR #11587: URL: https://github.com/apache/iceberg/pull/11587#discussion_r1848691024 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -373,4 +373,14 @@ default Snapshot snapshot(String name) { return null; } + + /** + * Re

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-11-19 Thread via GitHub
RussellSpitzer commented on code in PR #11587: URL: https://github.com/apache/iceberg/pull/11587#discussion_r1848685646 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -212,6 +212,11 @@ public String toString() { return name(); } + @Override +