nastra commented on code in PR #11587:
URL: https://github.com/apache/iceberg/pull/11587#discussion_r1849692234
##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -212,6 +212,11 @@ public String toString() {
return name();
}
+ @Override
+ public int formatVersion() {
+ return table().formatVersion();
Review Comment:
so the only table where this would be currently necessary to have is
`PositionDeletesTable`. This is so that we can know in
`SparkPositionDeletesRewrite` (which runs against `PositionDeletesTable`)
whether existing position deletes need to be rewritten to either V2 positional
deletes or to DVs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
