Re: [PR] [WIP] Migrate non TestBase related and Data classes in Flink [iceberg]

2024-04-12 Thread via GitHub
nastra commented on code in PR #10130: URL: https://github.com/apache/iceberg/pull/10130#discussion_r1562505930 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkAvroReaderWriter.java: ## @@ -95,14 +96,14 @@ private void writeAndValidate(Schema schema, Li

Re: [PR] [WIP] Migrate non TestBase related and Data classes in Flink [iceberg]

2024-04-12 Thread via GitHub
nastra commented on code in PR #10130: URL: https://github.com/apache/iceberg/pull/10130#discussion_r1562501901 ## data/src/test/java/org/apache/iceberg/data/parquet/TestParquetEncryptionWithWriteSupport.java: ## @@ -76,16 +77,16 @@ protected void writeAndValidate(Schema schema)

Re: [PR] [WIP] Migrate non TestBase related and Data classes in Flink [iceberg]

2024-04-12 Thread via GitHub
nastra commented on code in PR #10130: URL: https://github.com/apache/iceberg/pull/10130#discussion_r1562500825 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -132,12 +132,12 @@ public void testTwoLevelList() throws IOException { .

Re: [PR] [WIP] Migrate non TestBase related and Data classes in Flink [iceberg]

2024-04-12 Thread via GitHub
nastra commented on code in PR #10130: URL: https://github.com/apache/iceberg/pull/10130#discussion_r1562500640 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -132,12 +132,12 @@ public void testTwoLevelList() throws IOException { .

Re: [PR] [WIP] Migrate non TestBase related and Data classes in Flink [iceberg]

2024-04-12 Thread via GitHub
nastra commented on code in PR #10130: URL: https://github.com/apache/iceberg/pull/10130#discussion_r1562498776 ## data/src/test/java/org/apache/iceberg/data/DataTest.java: ## @@ -58,7 +58,7 @@ public abstract class DataTest { required(116, "dec_38_10", Types.DecimalT