nastra commented on code in PR #10130: URL: https://github.com/apache/iceberg/pull/10130#discussion_r1562505930
########## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkAvroReaderWriter.java: ########## @@ -95,14 +96,14 @@ private void writeAndValidate(Schema schema, List<Record> expectedRecords, int n Iterator<Record> expected = expectedRecords.iterator(); Iterator<RowData> rows = reader.iterator(); for (int i = 0; i < numRecord; i++) { - Assert.assertTrue("Should have expected number of records", rows.hasNext()); + assertThat(rows.hasNext()).isTrue(); Review Comment: same as previously mentioned. please also update all other places -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org