Re: [PR] [WIP] Feat: replace sort order [iceberg-python]

2025-01-24 Thread via GitHub
JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1928406696 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] [WIP] Feat: replace sort order [iceberg-python]

2025-01-24 Thread via GitHub
JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1928393381 ## pyiceberg/table/update/sorting.py: ## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] [WIP] Feat: replace sort order [iceberg-python]

2025-01-24 Thread via GitHub
JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1928389461 ## tests/integration/test_sort_order_update.py: ## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

Re: [PR] [WIP] Feat: replace sort order [iceberg-python]

2025-01-24 Thread via GitHub
JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1928389461 ## tests/integration/test_sort_order_update.py: ## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

Re: [PR] [WIP] Feat: replace sort order [iceberg-python]

2025-01-24 Thread via GitHub
JasperHG90 commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1928380832 ## pyiceberg/table/__init__.py: ## @@ -404,6 +405,20 @@ def update_schema(self, allow_incompatible_changes: bool = False, case_sensitive name_ma

Re: [PR] [WIP] Feat: replace sort order [iceberg-python]

2025-01-16 Thread via GitHub
JasperHG90 commented on PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#issuecomment-2596869184 Thanks for the comments 🙌 @kevinjqliu . Will look at your comments this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [WIP] Feat: replace sort order [iceberg-python]

2025-01-11 Thread via GitHub
kevinjqliu commented on code in PR #1500: URL: https://github.com/apache/iceberg-python/pull/1500#discussion_r1912178675 ## tests/integration/test_sort_order_update.py: ## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

[PR] [WIP] Feat: replace sort order [iceberg-python]

2025-01-08 Thread via GitHub
JasperHG90 opened a new pull request, #1500: URL: https://github.com/apache/iceberg-python/pull/1500 This PR adds functionality to replace a table's sort order. Closes #1245 Some basic tests are implemented but need to be expanded. Currently, a new sort order ID is assigned. Th