kevinjqliu commented on PR #444:
URL: https://github.com/apache/iceberg-python/pull/444#issuecomment-1961952840
@Fokko PRs ready for review. Please give it a try. I've linked an example
notebook in the PR description.
I've also noticed that writing one RecordBatch at a time seems to
kevinjqliu commented on code in PR #444:
URL: https://github.com/apache/iceberg-python/pull/444#discussion_r1499783029
##
pyiceberg/io/pyarrow.py:
##
@@ -1715,53 +1715,65 @@ def fill_parquet_file_metadata(
def write_file(table: Table, tasks: Iterator[WriteTask]) -> Iterator
Fokko commented on code in PR #444:
URL: https://github.com/apache/iceberg-python/pull/444#discussion_r1499027177
##
pyiceberg/io/pyarrow.py:
##
@@ -1715,53 +1715,65 @@ def fill_parquet_file_metadata(
def write_file(table: Table, tasks: Iterator[WriteTask]) -> Iterator[Data
Fokko commented on code in PR #444:
URL: https://github.com/apache/iceberg-python/pull/444#discussion_r1499000219
##
pyiceberg/io/pyarrow.py:
##
@@ -1715,53 +1715,65 @@ def fill_parquet_file_metadata(
def write_file(table: Table, tasks: Iterator[WriteTask]) -> Iterator[Data
Fokko commented on code in PR #444:
URL: https://github.com/apache/iceberg-python/pull/444#discussion_r1499000219
##
pyiceberg/io/pyarrow.py:
##
@@ -1715,53 +1715,65 @@ def fill_parquet_file_metadata(
def write_file(table: Table, tasks: Iterator[WriteTask]) -> Iterator[Data
Fokko commented on code in PR #444:
URL: https://github.com/apache/iceberg-python/pull/444#discussion_r1499000219
##
pyiceberg/io/pyarrow.py:
##
@@ -1715,53 +1715,65 @@ def fill_parquet_file_metadata(
def write_file(table: Table, tasks: Iterator[WriteTask]) -> Iterator[Data
Fokko commented on code in PR #444:
URL: https://github.com/apache/iceberg-python/pull/444#discussion_r1498996906
##
pyiceberg/io/pyarrow.py:
##
@@ -1715,53 +1715,65 @@ def fill_parquet_file_metadata(
def write_file(table: Table, tasks: Iterator[WriteTask]) -> Iterator[Data