Fokko commented on code in PR #444:
URL: https://github.com/apache/iceberg-python/pull/444#discussion_r1498996906
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1715,53 +1715,65 @@ def fill_parquet_file_metadata(
def write_file(table: Table, tasks: Iterator[WriteTask]) -> Iterator[DataFile]:
- task = next(tasks)
+ # task = next(tasks)
+
+ # try:
+ # _ = next(tasks)
+ # # If there are more tasks, raise an exception
+ # raise NotImplementedError("Only unpartitioned writes are supported:
https://github.com/apache/iceberg-python/issues/208";)
+ # except StopIteration:
+ # pass
+ data_files = []
+ for task in tasks:
+ parquet_writer_kwargs = _get_parquet_writer_kwargs(table.properties)
Review Comment:
Both this one, and the `row_group_size` can be moved out of the for to avoid
resolving all the properties with each task 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
