Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

aokolnychyi commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826536833 ## core/src/main/java/org/apache/iceberg/BaseFile.java: ## @@ -339,6 +344,9 @@ protected void internalSet(int pos, T value) { this.sortOrderId = (Intege

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

aokolnychyi commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826530813 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -448,6 +449,12 @@ public Object get(int pos) { return wrapped.equalityFieldIds();

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

amogh-jahagirdar commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826345609 ## api/src/main/java/org/apache/iceberg/DeleteFile.java: ## @@ -31,4 +31,15 @@ public interface DeleteFile extends ContentFile { default List splitOffsets

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

rdblue commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826336805 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -448,6 +449,12 @@ public Object get(int pos) { return wrapped.equalityFieldIds(); c

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

rdblue commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826335735 ## core/src/main/java/org/apache/iceberg/BaseFile.java: ## @@ -339,6 +344,9 @@ protected void internalSet(int pos, T value) { this.sortOrderId = (Integer) va

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

aokolnychyi commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826307104 ## core/src/main/java/org/apache/iceberg/BaseFile.java: ## @@ -339,6 +344,9 @@ protected void internalSet(int pos, T value) { this.sortOrderId = (Intege

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

aokolnychyi commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826304698 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -448,6 +449,12 @@ public Object get(int pos) { return wrapped.equalityFieldIds();

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

aokolnychyi commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826304698 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -448,6 +449,12 @@ public Object get(int pos) { return wrapped.equalityFieldIds();

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

aokolnychyi commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826304698 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -448,6 +449,12 @@ public Object get(int pos) { return wrapped.equalityFieldIds();