aokolnychyi commented on code in PR #11443:
URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826304698
##########
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##########
@@ -448,6 +449,12 @@ public Object get(int pos) {
return wrapped.equalityFieldIds();
case 15:
return wrapped.sortOrderId();
+ case 16:
+ if (wrapped instanceof DeleteFile) {
Review Comment:
I am not a big fan of this `instanceof` given that it is called in a tight
loop. We need it as `IndexedDataFile` is used for both data and deletes. I am
not sure it is reasonable to add `IndexedDeleteFile` for 3 different fields.
Thoughts?
##########
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##########
@@ -448,6 +449,12 @@ public Object get(int pos) {
return wrapped.equalityFieldIds();
case 15:
return wrapped.sortOrderId();
+ case 16:
+ if (wrapped instanceof DeleteFile) {
Review Comment:
I am not a big fan of this `instanceof` given that it is called in a tight
loop. We need it as `IndexedDataFile` is used for both data and deletes. I am
not sure it is reasonable to add `IndexedDeleteFile` for 3 different fields.
Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
