Re: [I] struct value design [iceberg-rust]

2023-11-15 Thread via GitHub
liurenjie1024 commented on issue #77: URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1813893291 Tracked in #96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] struct value design [iceberg-rust]

2023-11-15 Thread via GitHub
liurenjie1024 closed issue #77: struct value design URL: https://github.com/apache/iceberg-rust/issues/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [I] struct value design [iceberg-rust]

2023-10-12 Thread via GitHub
liurenjie1024 commented on issue #77: URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1760723094 > Another solution is pass struct type as another parameter when we need it, e.g. I prefer this approach. It's weird for me to store types with values, and we can alway

Re: [I] struct value design [iceberg-rust]

2023-10-12 Thread via GitHub
ZENOTME commented on issue #77: URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1760655157 cc @JanKaul @Fokko @Xuanwo @liurenjie1024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] struct value design [iceberg-rust]

2023-10-12 Thread via GitHub
ZENOTME commented on issue #77: URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1759997715 I find that our struct value didn't include type info. Do we want include type info in it? 1. If we include info in struct, the struct value may look like ``` struc

[I] struct value design [iceberg-rust]

2023-10-12 Thread via GitHub
ZENOTME opened a new issue, #77: URL: https://github.com/apache/iceberg-rust/issues/77 Use lookup will make the memory cost if we have multiple struct with same type. One solve way is to use `Arc` in Struct. I try this design in https://github.com/icelake-io/icelake/pull/136.