ZENOTME commented on issue #77:
URL: https://github.com/apache/iceberg-rust/issues/77#issuecomment-1759997715

   I find that our struct value didn't include type info. Do we want include 
type info in it?
   
   1. If we include info in struct, the struct value may look like 
   
   ```
   struct Struct {
      type: Arc<StructType>
      ...
   }
   ```
   
   - The benefit of it is we can look up field info directly by struct.
   - The drawback is that extra 8 bytes pointer cost.
   
   2. Another solution is pass struct type as another parameter when we need 
it, e.g.
   ```
   fn write(struct_value: Struct,struct_type: StructType)
   ```
   
   - The benefit of it is save memory cost.
   - The drawback is that I'm not sure whether the struct type is hard 
available in some case .
   
   For now, I'm working on serialize/deserialize value. And both process seem 
can solve by second way. (pass a struct type as parameter)
   
   But I'm not sure whether there is some scenario we must include info in 
struct value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to