Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-04-05 Thread via GitHub
liurenjie1024 closed issue #264: Implement `project` for `Transform`. URL: https://github.com/apache/iceberg-rust/issues/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-03-28 Thread via GitHub
ZENOTME commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-2025194854 > @liurenjie1024 @ZENOTME ...the `fn project(...)` is getting kinda extensive (lengthy). I think it'd be appropriate to introduce some helper functions here instead of writing a h

Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-03-27 Thread via GitHub
liurenjie1024 commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-2024236422 > @liurenjie1024 @ZENOTME ...the `fn project(...)` is getting kinda extensive (lengthy). I think it'd be appropriate to introduce some helper functions here instead of writi

Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-03-27 Thread via GitHub
marvinlanhenke commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-2022741526 @liurenjie1024 @ZENOTME ...the `fn project(...)` is getting kinda extensive (lengthy). I think it'd be appropriate to introduce some helper functions here instead of wri

Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-03-25 Thread via GitHub
ZENOTME commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-2017900050 > @ZENOTME are you still working on #287 and the proposed interface? just looking for a quick update on this - and huge thanks for your effort on this. Yes. I will update it

Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-03-25 Thread via GitHub
marvinlanhenke commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-2017896018 @ZENOTME are you still working on #287 and the proposed interface? just looking for a quick update on this - and huge thanks for your effort on this. -- This is a

Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-03-18 Thread via GitHub
marvinlanhenke commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-2005921495 thank you, once #283 is ready, I will continue here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-03-18 Thread via GitHub
liurenjie1024 commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-2005612750 @marvinlanhenke Sorry for late reply. Yeah, this is exactly what I'm thinking about, thanks! -- This is an automated message from the Apache Git Service. To respond to th

Re: [I] Implement `project` for `Transform`. [iceberg-rust]

2024-03-14 Thread via GitHub
marvinlanhenke commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-1997524951 @liurenjie1024 ...just to make sure I'm on the right track - and to confirm the idea. Here is what I would (high-level): - implement `fn project` on Transform