ZENOTME commented on issue #264: URL: https://github.com/apache/iceberg-rust/issues/264#issuecomment-2025194854
> @liurenjie1024 @ZENOTME ...the `fn project(...)` is getting kinda extensive (lengthy). I think it'd be appropriate to introduce some helper functions here instead of writing a huge `match` statement - to make the code more readable and reduce duplication. > > Any suggestions/ preferences where to put those? > > * `mod.rs` in iceberg/src/transform > * create `utils.rs` in iceberg/src/spec > * create fns on impl Transform itself > > thanks for your thoughts on this > > EDIT: For now, I decided to go with option no. 3, which I like since the scope of those helper functions is restricted only to `Transform` - putting those into some `utils.rs` would not be justified, since nobody else woud need those fns... +1 for no. 3 too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
