Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-08 Thread via GitHub
HonahX closed issue #502: [feature request] easier API to set table properties URL: https://github.com/apache/iceberg-python/issues/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-08 Thread via GitHub
HonahX commented on issue #502: URL: https://github.com/apache/iceberg-python/issues/502#issuecomment-1985304133 Thanks @syun64 @kevinjqliu for the thoughts and explanation. Since users seem to benefit from dictionaries and kwargs, I think it is good idea to support both (as in #503 ) --

Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-07 Thread via GitHub
kevinjqliu commented on issue #502: URL: https://github.com/apache/iceberg-python/issues/502#issuecomment-1983846568 oh wow, thanks @HonahX. I didn't think to pass the properties dictionary as kwargs. > Do you think the above way is good enough or the ** thing is still not very intu

Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-07 Thread via GitHub
syun64 commented on issue #502: URL: https://github.com/apache/iceberg-python/issues/502#issuecomment-1983542153 @HonahX - yes, that's right. We can currently achieve functionally the same thing by providing the properties as properties** into the function call. I guess my point

Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-06 Thread via GitHub
HonahX commented on issue #502: URL: https://github.com/apache/iceberg-python/issues/502#issuecomment-1982550509 Hi @kevinjqliu @syun64 I think currently we can also set properties using dictionaries, just need `**` in front of the dictionary: ```python properties: Dict[str, str] = {..

Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-06 Thread via GitHub
syun64 commented on issue #502: URL: https://github.com/apache/iceberg-python/issues/502#issuecomment-1982120843 I think this is a great idea @kevinjqliu . Most of the table properties have `.` in the key anyways, and hence we can't pass them as kwargs anyways. Changing the input parameter

Re: [I] [feature request] easier API to set table properties [iceberg-python]

2024-03-06 Thread via GitHub
kevinjqliu commented on issue #502: URL: https://github.com/apache/iceberg-python/issues/502#issuecomment-1981976531 Another workaround can be to use ``` with tbl.transaction() as transaction: transaction._apply((SetPropertiesUpdate(updates=properties),)) ``` -- This i