syun64 commented on issue #502: URL: https://github.com/apache/iceberg-python/issues/502#issuecomment-1983542153
@HonahX - yes, that's right. We can currently achieve functionally the same thing by providing the properties as ****properties** into the function call. I guess my point is that, if most of the properties have special characters in them so that they must be passed in as dictionary key values anyways, wouldn't it feel more straightforward for the users if we defined **properties** as a dictionary type in the first place? Or does it still make sense to keep it as it is because something like below is possible: ``` load_catalog( "my_catalog", type="rest", uri="http://localhost:8181";) ``` or ``` load_catalog( "my_catalog", type="rest", uri="http://localhost:8181";, **{ "s3.endpoint": "http://localhost:9000";, "s3.access-key-id": "admin", "s3.secret-access-key": "password", } ``` Where users would appreciate the ability to pass in simpler catalog properties like `type` and `uri` as simple kwargs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
