Re: [PR] Spark-3.5, 4.0: Add unit tests for ColumnarBatchUtil [iceberg]

2025-06-22 Thread via GitHub
huaxingao commented on PR #12275: URL: https://github.com/apache/iceberg/pull/12275#issuecomment-2995075838 @anuragmantri The PR looks good overall! One small suggestion: for `buildIsDeleted`, shall we also have a test for the mixed case (both equality + position deletes)? -- This is an

Re: [I] Why is the default value of write.metadata.delete-after-commit.enabled set to false? [iceberg]

2025-06-22 Thread via GitHub
lintingbin commented on issue #13330: URL: https://github.com/apache/iceberg/issues/13330#issuecomment-2995162163 How to modify the default value at the catalog level? Currently, it seems that the default value can only be modified through Iceberg's code. -- This is an automated message f

Re: [I] Why is the default value of write.metadata.delete-after-commit.enabled set to false? [iceberg]

2025-06-22 Thread via GitHub
manuzhang commented on issue #13330: URL: https://github.com/apache/iceberg/issues/13330#issuecomment-2995156664 It might be reasonable to be conservative on default value, and it can be easily overwritten with catalog level config. -- This is an automated message from the Apache Git Serv

Re: [PR] Spark-3.5, 4.0: Add unit tests for ColumnarBatchUtil [iceberg]

2025-06-22 Thread via GitHub
huaxingao commented on code in PR #12275: URL: https://github.com/apache/iceberg/pull/12275#discussion_r2160786111 ## spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/TestColumnarBatchUtil.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software

Re: [PR] Optimise RowData evolution [iceberg]

2025-06-22 Thread via GitHub
aiborodin commented on code in PR #13340: URL: https://github.com/apache/iceberg/pull/13340#discussion_r2160768670 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java: ## @@ -315,6 +316,16 @@ public Builder cacheRefreshMs(long refreshM

Re: [PR] Optimise RowData evolution [iceberg]

2025-06-22 Thread via GitHub
aiborodin commented on code in PR #13340: URL: https://github.com/apache/iceberg/pull/13340#discussion_r2160730816 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/convert/ArrayConverter.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Fou

Re: [I] Why is the default value of write.metadata.delete-after-commit.enabled set to false? [iceberg]

2025-06-22 Thread via GitHub
lintingbin commented on issue #13330: URL: https://github.com/apache/iceberg/issues/13330#issuecomment-2994915887 > The most relevant case I've seen is HadoopCatalog which relies on `metadata.json` files to load the table. For high frequency and concurrency updates, it's possible that the `

Re: [I] Core: `GenericDeleteFile` constructor missing `dataSequenceNumber` field [iceberg]

2025-06-22 Thread via GitHub
manuzhang commented on issue #13320: URL: https://github.com/apache/iceberg/issues/13320#issuecomment-2994908558 cc @stevenzwu @pvary to help check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] feat: add support for avro to arrow data conversion [iceberg-cpp]

2025-06-22 Thread via GitHub
mapleFU commented on code in PR #124: URL: https://github.com/apache/iceberg-cpp/pull/124#discussion_r2160658424 ## src/iceberg/avro/avro_data_util_internal.h: ## @@ -26,10 +26,21 @@ namespace iceberg::avro { +/// \brief Append an Avro datum to an Arrow array builder. +///

Re: [I] Support Azure FileSystem with Pyarrow FileIO [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2112: URL: https://github.com/apache/iceberg-python/issues/2112#issuecomment-2994853060 #2111 is now merged. @NikitaMatskevich is this good to close? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] [bug] Schema validation should reject field names that are invalid Avro identifiers [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2123: URL: https://github.com/apache/iceberg-python/issues/2123#issuecomment-2994456628 @kris-gaudel done! looking forward to the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] feat: add support for avro to arrow data conversion [iceberg-cpp]

2025-06-22 Thread via GitHub
zhjwpku commented on code in PR #124: URL: https://github.com/apache/iceberg-cpp/pull/124#discussion_r2160649110 ## src/iceberg/avro/avro_data_util.cc: ## @@ -17,16 +17,383 @@ * under the License. */ +#include +#include +#include +#include +#include +#include +#inclu

Re: [I] [DISCUSSION] json_internal Should we implement a minimal unit of code for JSON functionality to avoid mutual dependencies? [iceberg-cpp]

2025-06-22 Thread via GitHub
MisterRaindrop commented on issue #128: URL: https://github.com/apache/iceberg-cpp/issues/128#issuecomment-2994784536 Thanks I'll have it a try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [DISCUSSION] json_internal Should we implement a minimal unit of code for JSON functionality to avoid mutual dependencies? [iceberg-cpp]

2025-06-22 Thread via GitHub
MisterRaindrop commented on issue #128: URL: https://github.com/apache/iceberg-cpp/issues/128#issuecomment-2994670819 I didn’t make it clear. I called NameMappingFromJson in avro_read for name mapping. However, this method is defined in json_internal, and if I reference it, it will cause p

Re: [PR] feat(transaction): Implement TransactionAction for FastAppendAction [iceberg-rust]

2025-06-22 Thread via GitHub
dentiny commented on code in PR #1448: URL: https://github.com/apache/iceberg-rust/pull/1448#discussion_r2160577732 ## crates/iceberg/src/spec/manifest/writer.rs: ## @@ -127,7 +127,7 @@ impl ManifestWriter { pub(crate) fn new( output: OutputFile, snapshot_

Re: [PR] support TIMESTAMP_NANO for kafka connector [iceberg]

2025-06-22 Thread via GitHub
ihadoop commented on PR #13365: URL: https://github.com/apache/iceberg/pull/13365#issuecomment-2994614141 > same Ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] `iceberg-rest-fixture` errors with SQLiteException under high concurrent load [iceberg]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #13366: URL: https://github.com/apache/iceberg/issues/13366#issuecomment-2994426955 > I was under the assumption that SQLite would handle concurrency from the same process. Yea i think this is a quirk of the sqlite in-memory db. From https://www.sqlite.

[PR] add field type convert [iceberg]

2025-06-22 Thread via GitHub
ihadoop opened a new pull request, #13365: URL: https://github.com/apache/iceberg/pull/13365 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] perf: `table.add_files` and `inspect.files` [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on code in PR #2133: URL: https://github.com/apache/iceberg-python/pull/2133#discussion_r2160410763 ## pyiceberg/table/inspect.py: ## @@ -650,11 +650,12 @@ def _files(self, snapshot_id: Optional[int] = None, data_file_filter: Optional[S snapshot

Re: [I] `iceberg-rest-fixture` errors with SQLiteException under high concurrent load [iceberg]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #13366: URL: https://github.com/apache/iceberg/issues/13366#issuecomment-2994432381 > Another option would be to limit the concurrency to 1 to avoid race conditions completely, since SQLite is purely for testing purposes. Setting concurrency to 1 solves t

Re: [I] k1 [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2134: URL: https://github.com/apache/iceberg-python/issues/2134#issuecomment-2994328494 not sure if this was intentional, feel free to reopen if it is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] `iceberg-rest-fixture` errors with SQLiteException under high concurrent load [iceberg]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #13366: URL: https://github.com/apache/iceberg/issues/13366#issuecomment-2994415316 `jdbc:sqlite` usage in iceberg repos, https://grep.app/search?f.repo.pattern=apache%2Ficeberg&q=jdbc%3Asqlite Only in `apache/iceberg` and apache/iceberg-rust` -- This is a

Re: [I] Duplicate File Remediation [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2130: URL: https://github.com/apache/iceberg-python/issues/2130#issuecomment-2994346349 @MrDerecho @ForeverAngry can you help me understand the use case and expected behavior? > on occasion, there will be a duplicate file, I load so many files that I

Re: [I] Reading a table without schema IDs [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on issue #11740: URL: https://github.com/apache/iceberg/issues/11740#issuecomment-2994562348 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Spark, Avro: Add support for row lineage in Avro reader [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed pull request #13070: Spark, Avro: Add support for row lineage in Avro reader URL: https://github.com/apache/iceberg/pull/13070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Core: support pass storage credential to HadoopFileIO [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed pull request #13062: Core: support pass storage credential to HadoopFileIO URL: https://github.com/apache/iceberg/pull/13062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Generic Serializer and DeSerializer for control topic consumers and producers [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #12583: URL: https://github.com/apache/iceberg/pull/12583#issuecomment-2994562745 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spark, Avro: Add support for row lineage in Avro reader [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #13070: URL: https://github.com/apache/iceberg/pull/13070#issuecomment-2994563474 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] AWS: Support setting description for Glue table within buildTable [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed issue #11735: AWS: Support setting description for Glue table within buildTable URL: https://github.com/apache/iceberg/issues/11735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Generic Serializer and DeSerializer for control topic consumers and producers [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed pull request #12583: Generic Serializer and DeSerializer for control topic consumers and producers URL: https://github.com/apache/iceberg/pull/12583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Add partition expire for Iceberg [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed issue #11686: Add partition expire for Iceberg URL: https://github.com/apache/iceberg/issues/11686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] AWS: Support setting description for Glue table within buildTable [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on issue #11735: URL: https://github.com/apache/iceberg/issues/11735#issuecomment-2994562329 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Remove time logical information from connect schema for spark compatibility [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed pull request #12724: Remove time logical information from connect schema for spark compatibility URL: https://github.com/apache/iceberg/pull/12724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Spec: clarify that bounds of variant field must not have bounds for mixed types [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #13073: URL: https://github.com/apache/iceberg/pull/13073#issuecomment-2994563562 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] Reading a table without schema IDs [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed issue #11740: Reading a table without schema IDs URL: https://github.com/apache/iceberg/issues/11740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] kafka-connector | org.apache.kafka.connect.storage.StringConverter for value not working [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on issue #11871: URL: https://github.com/apache/iceberg/issues/11871#issuecomment-2994562421 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] Core: validate file format compatibility with v3 [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #13060: URL: https://github.com/apache/iceberg/pull/13060#issuecomment-2994563236 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spec: clarify that bounds of variant field must not have bounds for mixed types [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed pull request #13073: Spec: clarify that bounds of variant field must not have bounds for mixed types URL: https://github.com/apache/iceberg/pull/13073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Core: validate file format compatibility with v3 [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed pull request #13060: Core: validate file format compatibility with v3 URL: https://github.com/apache/iceberg/pull/13060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Spark-3.5: Add procedure to compute partition stats [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #12451: URL: https://github.com/apache/iceberg/pull/12451#issuecomment-2994562470 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spark-3.5: Add procedure to compute partition stats [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] closed pull request #12451: Spark-3.5: Add procedure to compute partition stats URL: https://github.com/apache/iceberg/pull/12451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Core: support pass storage credential to HadoopFileIO [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #13062: URL: https://github.com/apache/iceberg/pull/13062#issuecomment-2994563348 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] Add partition expire for Iceberg [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on issue #11686: URL: https://github.com/apache/iceberg/issues/11686#issuecomment-2994562295 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Remove time logical information from connect schema for spark compatibility [iceberg]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #12724: URL: https://github.com/apache/iceberg/pull/12724#issuecomment-2994562988 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] [feature request] docs for IRC catalog connection [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2096: URL: https://github.com/apache/iceberg-python/issues/2096#issuecomment-2994339785 @james5418 feel free to open up a PR! I would suggest taking a look at the above catalog integrations to see how these params are relevant. -- This is an automated mess

Re: [I] Table metadata corruption during parallel upsert operations [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2120: URL: https://github.com/apache/iceberg-python/issues/2120#issuecomment-2994389057 ok the issue is with the apache/iceberg-rest-fixture. i'll open an issue on the java side -- This is an automated message from the Apache Git Service. To respond to the

[PR] Preliminary benchmarking framework [iceberg-rust]

2025-06-22 Thread via GitHub
kyteware opened a new pull request, #1463: URL: https://github.com/apache/iceberg-rust/pull/1463 ## Which issue does this PR close? - Closes #1432. ## What changes are included in this PR? This PR adds a preliminary benchmarking framework and the first ben

Re: [I] [bug] Schema validation should reject field names that are invalid Avro identifiers [iceberg-python]

2025-06-22 Thread via GitHub
kris-gaudel commented on issue #2123: URL: https://github.com/apache/iceberg-python/issues/2123#issuecomment-2994439347 Could I be assigned this issue please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] `iceberg-rest-fixture` errors with SQLiteException under high concurrent load [iceberg]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #13366: URL: https://github.com/apache/iceberg/issues/13366#issuecomment-2994465370 Setting `CATALOG_URI=jdbc:sqlite:file::memory:?cache=shared` still has issues when concurrently updating the sqlite db. Setting `CATALOG_CLIENTS=1` resolves this consistency

Re: [I] Failed to save Iceberg table from Delta table. Cannot work with a non-pinned table snapshot [iceberg]

2025-06-22 Thread via GitHub
vladislav-sidorovich commented on issue #13359: URL: https://github.com/apache/iceberg/issues/13359#issuecomment-2994459904 Looks like there is a root cause in Delta: https://github.com/delta-io/delta/issues/2443 -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Failed to save Iceberg table from Delta table. Cannot work with a non-pinned table snapshot [iceberg]

2025-06-22 Thread via GitHub
vladislav-sidorovich closed issue #13359: Failed to save Iceberg table from Delta table. Cannot work with a non-pinned table snapshot URL: https://github.com/apache/iceberg/issues/13359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] `iceberg-rest-fixture` errors with SQLiteException under high concurrent load [iceberg]

2025-06-22 Thread via GitHub
Fokko commented on issue #13366: URL: https://github.com/apache/iceberg/issues/13366#issuecomment-2994423750 Interesting. I was under the assumption that SQLite would handle concurrency from the same process. Another option would be to limit the concurrency to 1 to avoid race conditions com

Re: [I] Table metadata corruption during parallel upsert operations [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2120: URL: https://github.com/apache/iceberg-python/issues/2120#issuecomment-2994406941 https://github.com/apache/iceberg/issues/13366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[I] `iceberg-rest-fixture` errors with `no such table: iceberg_tables` [iceberg]

2025-06-22 Thread via GitHub
kevinjqliu opened a new issue, #13366: URL: https://github.com/apache/iceberg/issues/13366 ### Apache Iceberg version None ### Query engine None ### Please describe the bug 🐞 The [`iceberg-rest-fixture`](https://hub.docker.com/r/apache/iceberg-rest-fixture)

Re: [PR] perf: `table.add_files` and `inspect.files` [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on PR #2133: URL: https://github.com/apache/iceberg-python/pull/2133#issuecomment-2994341263 @jayceslesar looks like the linter isnt happy, could you run `make lint`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] Table metadata corruption during parallel upsert operations [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2120: URL: https://github.com/apache/iceberg-python/issues/2120#issuecomment-2994359501 > Caused by: org.sqlite.SQLiteException: [SQLITE_ERROR] SQL error or missing database (no such table: iceberg_tables) thats interesting. And you're using `apache/ice

Re: [PR] perf: optimize `table.add_files` and `inspect.files` [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on PR #2133: URL: https://github.com/apache/iceberg-python/pull/2133#issuecomment-2994354530 Thanks @jayceslesar btw i change the PR description so we dont close the 2 issues automatically -- This is an automated message from the Apache Git Service. To respond

Re: [PR] perf: optimize `table.add_files` and `inspect.files` [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu merged PR #2133: URL: https://github.com/apache/iceberg-python/pull/2133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [I] Duplicate File Remediation [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2130: URL: https://github.com/apache/iceberg-python/issues/2130#issuecomment-2994346640 I think a pseducode snippet of how youre using add_files would be really helpful here! -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] doc: Add a readme for the SQL catalog [iceberg-rust]

2025-06-22 Thread via GitHub
kevinjqliu commented on code in PR #1459: URL: https://github.com/apache/iceberg-rust/pull/1459#discussion_r2160421219 ## crates/catalog/sql/README.md: ## @@ -0,0 +1,39 @@ + + +# Apache Iceberg SQL Catalog Official Native Rust Implementation + +[![crates.io](https://img.shields.

Re: [I] Add files support for parquet field_ids [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2131: URL: https://github.com/apache/iceberg-python/issues/2131#issuecomment-2994352661 > allow for parquet field_id support in the add_files method? this is already done automatically based on the table metadata. https://github.com/apache/iceberg-

Re: [PR] perf: `table.add_files` and `inspect.files` [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on PR #2133: URL: https://github.com/apache/iceberg-python/pull/2133#issuecomment-2994348236 yep thats the goal eventually. I also think the biggest perf bottleneck is reading the avro metadata files. Once we move that part to rust (https://github.com/apache/iceberg-rus

Re: [PR] perf: `table.add_files` and `inspect.files` [iceberg-python]

2025-06-22 Thread via GitHub
jayceslesar commented on PR #2133: URL: https://github.com/apache/iceberg-python/pull/2133#issuecomment-2994345091 I wonder if we can eventually replace this portion with rust -- unsure what that implementation supports currently but would be fun to try it out -- This is an automated mess

Re: [I] How can I speed up batched add_files calls? [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #2132: URL: https://github.com/apache/iceberg-python/issues/2132#issuecomment-2994340583 I see the option is not mentioned in the add_files docs https://py.iceberg.apache.org/api/#add-files Lets add it there so it becomes transparent -- This is an automa

Re: [I] k1 [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu closed issue #2134: k1 URL: https://github.com/apache/iceberg-python/issues/2134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

Re: [I] `iceberg-catalog-sql` is not published. [iceberg-rust]

2025-06-22 Thread via GitHub
kevinjqliu commented on issue #1460: URL: https://github.com/apache/iceberg-rust/issues/1460#issuecomment-2994339065 Btw @JanKaul and i talked offline. hes working to publish crates in the https://github.com/JanKaul/iceberg-rust/ repo, include the one referenced above, under a different nam

Re: [PR] Create devcontainer.json [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu closed pull request #2135: Create devcontainer.json URL: https://github.com/apache/iceberg-python/pull/2135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Create devcontainer.json [iceberg-python]

2025-06-22 Thread via GitHub
kevinjqliu commented on PR #2135: URL: https://github.com/apache/iceberg-python/pull/2135#issuecomment-2994328404 not sure if this was intentional, feel free to reopen if it is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] [DISCUSSION] json_internal Should we implement a minimal unit of code for JSON functionality to avoid mutual dependencies? [iceberg-cpp]

2025-06-22 Thread via GitHub
wgtmac commented on issue #128: URL: https://github.com/apache/iceberg-cpp/issues/128#issuecomment-2994270942 `NameMappingFromJson` shouldn't depend on `iceberg-bundle`. Could you double check if any dependency of avro or arrow caused the failure? -- This is an automated message from the

[PR] avro support applying field-ids based on name mapping [iceberg-cpp]

2025-06-22 Thread via GitHub
MisterRaindrop opened a new pull request, #127: URL: https://github.com/apache/iceberg-cpp/pull/127 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[I] [DISCUSSION] json_internal Should we implement a minimal unit of code for JSON functionality to avoid mutual dependencies? [iceberg-cpp]

2025-06-22 Thread via GitHub
MisterRaindrop opened a new issue, #128: URL: https://github.com/apache/iceberg-cpp/issues/128 I encountered a problem when implementing the code. The NameMappingFromJson code in json_internal is dependent on iceberg-bundle, and iceberg also depends on it. This kind of dependency causes the

Re: [I] [DISCUSSION] How to implement manifest list or manifest read? [iceberg-cpp]

2025-06-22 Thread via GitHub
MisterRaindrop closed issue #122: [DISCUSSION] How to implement manifest list or manifest read? URL: https://github.com/apache/iceberg-cpp/issues/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] build(deps): bump the gomod_updates group with 16 updates [iceberg-go]

2025-06-22 Thread via GitHub
dependabot[bot] opened a new pull request, #465: URL: https://github.com/apache/iceberg-go/pull/465 Bumps the gomod_updates group with 16 updates: | Package | From | To | | --- | --- | --- | | [github.com/apache/arrow-go/v18](https://github.com/apache/arrow-go) | `18.3.0` | `18.

Re: [PR] Build: Bump datamodel-code-generator from 0.31.0 to 0.31.1 [iceberg]

2025-06-22 Thread via GitHub
Fokko merged PR #13362: URL: https://github.com/apache/iceberg/pull/13362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Bump testcontainers from 1.21.1 to 1.21.2 [iceberg]

2025-06-22 Thread via GitHub
Fokko merged PR #13363: URL: https://github.com/apache/iceberg/pull/13363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] feature: expire snapshots action [iceberg-rust]

2025-06-22 Thread via GitHub
liurenjie1024 commented on PR #1455: URL: https://github.com/apache/iceberg-rust/pull/1455#issuecomment-2994077975 > But, do you mean that this procedure fits in this repo, but belongs in a different crate? Or that it doesn’t fit this repository? The procedure implementation relies