kevinjqliu commented on code in PR #2133:
URL: https://github.com/apache/iceberg-python/pull/2133#discussion_r2160410763
##########
pyiceberg/table/inspect.py:
##########
@@ -650,11 +650,12 @@ def _files(self, snapshot_id: Optional[int] = None,
data_file_filter: Optional[S
snapshot = self._get_snapshot(snapshot_id)
io = self.tbl.io
- files_table: list[pa.Table] = []
- for manifest_list in snapshot.manifests(io):
- files_table.append(self._get_files_from_manifest(manifest_list,
data_file_filter))
- return pa.concat_tables(files_table)
+ executor = ExecutorFactory.get_or_create()
+ results = list(
+ executor.map(lambda manifest:
self._get_files_from_manifest(manifest, data_file_filter),
snapshot.manifests(io))
Review Comment:
nit: this is manifest_list
```suggestion
executor.map(lambda manifest_list:
self._get_files_from_manifest(manifest_list, data_file_filter),
snapshot.manifests(io))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
