Fokko commented on code in PR #58:
URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2041524600
##
src/iceberg/expression.h:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
Fokko commented on code in PR #58:
URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2041514451
##
src/iceberg/expression.cc:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
sdd commented on PR #982:
URL: https://github.com/apache/iceberg-rust/pull/982#issuecomment-2800620649
Thanks for the review @liurenjie1024 - much appreciated. Will come back with
a revised design.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
liurenjie1024 merged PR #1209:
URL: https://github.com/apache/iceberg-rust/pull/1209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
peach12345 commented on issue #12759:
URL: https://github.com/apache/iceberg/issues/12759#issuecomment-2800540273
Hi @kumarpritam863 thank you for your response.
Regarding error handling within the Iceberg-Sink Connector, how does it
work? We recently encountered an issue where metadata w
Xuanwo merged PR #69:
URL: https://github.com/apache/iceberg-cpp/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
Xuanwo merged PR #60:
URL: https://github.com/apache/iceberg-cpp/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
zhjwpku commented on PR #69:
URL: https://github.com/apache/iceberg-cpp/pull/69#issuecomment-2800509574
@Fokko @Xuanwo Please take a look at this PR when you are available, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
xxchan opened a new pull request, #1210:
URL: https://github.com/apache/iceberg-rust/pull/1210
## Which issue does this PR close?
`cargo run --bin iceberg-cli`
ICEBERG CLI v0.4.0
Error: No such file or directory (os error 2)
After
ICEBERG CLI v0.4.0
Error: fa
pvary commented on issue #12749:
URL: https://github.com/apache/iceberg/issues/12749#issuecomment-2800488305
> > Are these changes are breaking changes for users? Can we move forward
anyway? Do we need to highlight these changes for the users?
>
> Previously, we also updated metrics w
maomaodev opened a new issue, #12790:
URL: https://github.com/apache/iceberg/issues/12790
### Query engine
Spark 3.4.2
Iceberg 1.4.3
### Question
1. After [SPARK-43203](https://issues.apache.org/jira/browse/SPARK-43203),
Spark move all Drop Table case to DataSource V2
Xuanwo merged PR #1206:
URL: https://github.com/apache/iceberg-rust/pull/1206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
zhjwpku commented on PR #60:
URL: https://github.com/apache/iceberg-cpp/pull/60#issuecomment-2800463163
@Fokko @Xuanwo I think the community have reached the consensus, and I have
resolved the merge conflict, it would be great if you can help merge this,
thanks.
--
This is an automated m
zhjwpku commented on code in PR #60:
URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2041395083
##
src/iceberg/snapshot.cc:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
Xuanwo closed pull request #760: refactor: avoid async_trait macro for
IcebergWriter and provide extra dyn trait for object safety
URL: https://github.com/apache/iceberg-rust/pull/760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
Xuanwo commented on PR #762:
URL: https://github.com/apache/iceberg-rust/pull/762#issuecomment-2800410027
Hi, I personally feel that the benefits of avoiding the use of `async_trait`
at our `FileWrite` level aren't worth it. I'm going to close this PR now. Feel
free to start a discussion ab
Xuanwo commented on PR #761:
URL: https://github.com/apache/iceberg-rust/pull/761#issuecomment-2800410083
Hi, I personally feel that the benefits of avoiding the use of `async_trait`
at our `FileWrite` level aren't worth it. I'm going to close this PR now. Feel
free to start a discussion ab
Xuanwo commented on PR #760:
URL: https://github.com/apache/iceberg-rust/pull/760#issuecomment-2800410239
Hi, I personally feel that the benefits of avoiding the use of `async_trait`
at our `FileWrite` level aren't worth it. I'm going to close this PR now. Feel
free to start a discussion ab
Xuanwo closed pull request #761: refactor: avoid async_trait for FileRead and
provide object safe dyn methods
URL: https://github.com/apache/iceberg-rust/pull/761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Xuanwo closed pull request #762: refactor: avoid async_trait for FileWrite and
provide extra dyn methods
URL: https://github.com/apache/iceberg-rust/pull/762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
wgtmac commented on code in PR #60:
URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2041360622
##
src/iceberg/snapshot.h:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the N
slfan1989 commented on code in PR #12784:
URL: https://github.com/apache/iceberg/pull/12784#discussion_r2041361102
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##
@@ -1109,6 +1110,22 @@ public void testAddFilesParti
slfan1989 commented on code in PR #12784:
URL: https://github.com/apache/iceberg/pull/12784#discussion_r2041358636
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##
@@ -1109,6 +1110,22 @@ public void testAddFilesParti
gty404 commented on PR #61:
URL: https://github.com/apache/iceberg-cpp/pull/61#issuecomment-2800283294
@Fokko @Xuanwo Could you help review and merge this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Xuanwo merged PR #1205:
URL: https://github.com/apache/iceberg-rust/pull/1205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
liurenjie1024 merged PR #1200:
URL: https://github.com/apache/iceberg-rust/pull/1200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
jonathanc-n commented on PR #1207:
URL: https://github.com/apache/iceberg-rust/pull/1207#issuecomment-2800265965
cc @Xuanwo @fqaiser94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
liurenjie1024 closed issue #1199: infra: Add an epic issue type.
URL: https://github.com/apache/iceberg-rust/issues/1199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
manuzhang commented on PR #12778:
URL: https://github.com/apache/iceberg/pull/12778#issuecomment-2800250536
@akhilyendluri please follow changes in
https://github.com/apache/iceberg/pull/11264 to fix UT.
--
This is an automated message from the Apache Git Service.
To respond to the messag
manuzhang commented on PR #12780:
URL: https://github.com/apache/iceberg/pull/12780#issuecomment-2800249907
@akhilyendluri please follow changes in
https://github.com/apache/iceberg/pull/11264 to fix UT.
--
This is an automated message from the Apache Git Service.
To respond to the messag
manuzhang commented on issue #12749:
URL: https://github.com/apache/iceberg/issues/12749#issuecomment-2800248445
> Are these changes are breaking changes for users? Can we move forward
anyway? Do we need to highlight these changes for the users?
Previously, we updated metrics when [up
manuzhang commented on PR #12767:
URL: https://github.com/apache/iceberg/pull/12767#issuecomment-2800245540
Do we need to update LICENSE and NOTICE as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jonathanc-n opened a new pull request, #1207:
URL: https://github.com/apache/iceberg-rust/pull/1207
## Which issue does this PR close?
- Closes #1198.
## What changes are included in this PR?
Add prefetch hint for parsing puffin footer + change some docs
github-actions[bot] closed issue #10557: how to update nested column value with
spark
URL: https://github.com/apache/iceberg/issues/10557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on issue #1227:
URL:
https://github.com/apache/iceberg-python/issues/1227#issuecomment-2800205252
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity
github-actions[bot] commented on PR #12098:
URL: https://github.com/apache/iceberg/pull/12098#issuecomment-2800203404
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #12159:
URL: https://github.com/apache/iceberg/pull/12159#issuecomment-2800203433
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] closed issue #8338: Iceberg data file Not Found but have an
entry in table.files catalog
URL: https://github.com/apache/iceberg/issues/8338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
github-actions[bot] closed pull request #12098: Spec: Update partition stats
for V3
URL: https://github.com/apache/iceberg/pull/12098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
github-actions[bot] commented on PR #11513:
URL: https://github.com/apache/iceberg/pull/11513#issuecomment-2800203357
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed pull request #11513: Core, Spark: Refactor
FileRewriter interface to separate planning and execution
URL: https://github.com/apache/iceberg/pull/11513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on issue #8338:
URL: https://github.com/apache/iceberg/issues/8338#issuecomment-2800203260
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] commented on issue #10557:
URL: https://github.com/apache/iceberg/issues/10557#issuecomment-2800203285
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache
lidavidm commented on code in PR #60:
URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2041248649
##
src/iceberg/snapshot.cc:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
lidavidm commented on code in PR #60:
URL: https://github.com/apache/iceberg-cpp/pull/60#discussion_r2041247562
##
src/iceberg/snapshot.h:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
lidavidm commented on code in PR #58:
URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2041246684
##
test/expression_test.cc:
##
Review Comment:
This could benefit from a parameterized test
##
src/iceberg/expression.cc:
##
@@ -0,0 +1,65 @@
+
dttung2905 opened a new pull request, #395:
URL: https://github.com/apache/iceberg-go/pull/395
I'm adding the functionality to set table properties in AWS Glue catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jdockerty commented on code in PR #1116:
URL: https://github.com/apache/iceberg-rust/pull/1116#discussion_r2041196034
##
crates/iceberg/src/spec/name_mapping.rs:
##
@@ -33,12 +48,38 @@ pub struct NameMapping {
#[serde(rename_all = "kebab-case")]
pub struct MappedField {
#
jdockerty commented on code in PR #1116:
URL: https://github.com/apache/iceberg-rust/pull/1116#discussion_r2041196034
##
crates/iceberg/src/spec/name_mapping.rs:
##
@@ -33,12 +48,38 @@ pub struct NameMapping {
#[serde(rename_all = "kebab-case")]
pub struct MappedField {
#
kevinjqliu commented on issue #1201:
URL: https://github.com/apache/iceberg-rust/issues/1201#issuecomment-2800062533
> Currently in the integrations, we create docker images on the fly
i think this is [copied over from
pyiceberg](https://github.com/apache/iceberg-python/blob/bb45d1ea9
kevinjqliu commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2800011503
cool CI passes now
@mnzpk please take a look when you have time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ZENOTME commented on PR #1176:
URL: https://github.com/apache/iceberg-rust/pull/1176#issuecomment-288830
> I believe this functionality should be covered in a schema update action.
It does seem nice to have an easier way to add a field. What are your thoughts?
cc @liurenjie1024 @Fokko
manuzhang closed pull request #12785: Build: Bump junit-platform from 1.11.4 to
1.12.2
URL: https://github.com/apache/iceberg/pull/12785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #12785:
URL: https://github.com/apache/iceberg/pull/12785#issuecomment-285016
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency
dependabot[bot] commented on PR #12786:
URL: https://github.com/apache/iceberg/pull/12786#issuecomment-284912
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency
manuzhang closed pull request #12786: Build: Bump nessie from 0.103.2 to 0.103.3
URL: https://github.com/apache/iceberg/pull/12786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
dependabot[bot] commented on PR #12787:
URL: https://github.com/apache/iceberg/pull/12787#issuecomment-284709
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency
manuzhang closed pull request #12787: Build: Bump junit from 5.11.4 to 5.12.2
URL: https://github.com/apache/iceberg/pull/12787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kevinjqliu merged PR #1907:
URL: https://github.com/apache/iceberg-python/pull/1907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
sungwy commented on code in PR #1908:
URL: https://github.com/apache/iceberg-python/pull/1908#discussion_r2041146404
##
dev/Dockerfile:
##
@@ -52,7 +52,7 @@ RUN curl --retry 5 -s
https://repository.apache.org/content/groups/snapshots/org
# Download AWS bundle
-RUN curl --r
sungwy opened a new pull request, #1908:
URL: https://github.com/apache/iceberg-python/pull/1908
# Rationale for this change
https://github.com/apache/iceberg-python/issues/1906
# Are these changes tested?
Yes, unit tested
# Are there any user-facing ch
sunxiaojian commented on PR #12754:
URL: https://github.com/apache/iceberg/pull/12754#issuecomment-2799961553
> > But should this be done after the Flink implementation is completed and
then the logic is extracted to the core uniformly?
>
> I faced the exact same question when I have
dependabot[bot] commented on PR #1170:
URL: https://github.com/apache/iceberg-rust/pull/1170#issuecomment-2799926541
Looks like parquet is updatable in another way, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
dependabot[bot] opened a new pull request, #1206:
URL: https://github.com/apache/iceberg-rust/pull/1206
Bumps the arrow-parquet group with 2 updates in the / directory:
[arrow-buffer](https://github.com/apache/arrow-rs) and
[arrow-schema](https://github.com/apache/arrow-rs).
Updates
dependabot[bot] closed pull request #1170: chore(deps): Bump parquet from
54.2.0 to 54.2.1 in the arrow-parquet group
URL: https://github.com/apache/iceberg-rust/pull/1170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dependabot[bot] opened a new pull request, #1205:
URL: https://github.com/apache/iceberg-rust/pull/1205
Bumps [roaring](https://github.com/RoaringBitmap/roaring-rs) from `6cfeb88`
to `9496afe`.
Commits
https://github.com/RoaringBitmap/roaring-rs/commit/9496afe1e6ad93a8875f901c2
ebyhr commented on code in PR #12784:
URL: https://github.com/apache/iceberg/pull/12784#discussion_r2041101703
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##
@@ -1109,6 +1110,22 @@ public void testAddFilesPartition
dependabot[bot] opened a new pull request, #394:
URL: https://github.com/apache/iceberg-go/pull/394
Bumps the gomod_updates group with 1 update:
[github.com/substrait-io/substrait-go/v3](https://github.com/substrait-io/substrait-go).
Updates `github.com/substrait-io/substrait-go/v3` f
kumarpritam863 commented on issue #12759:
URL: https://github.com/apache/iceberg/issues/12759#issuecomment-2799861769
Hi @peach12345 as far as I am aware Kafka Connect Iceberg does not has DLQ
support for sending the records to dll once the record lands to the sink task
but you can have the
Fokko commented on code in PR #1899:
URL: https://github.com/apache/iceberg-python/pull/1899#discussion_r2041062862
##
dev/Dockerfile:
##
@@ -39,20 +39,20 @@ WORKDIR ${SPARK_HOME}
# Remember to also update `tests/conftest`'s spark setting
ENV SPARK_VERSION=3.5.4
ENV ICEBERG_S
Fokko opened a new pull request, #1907:
URL: https://github.com/apache/iceberg-python/pull/1907
# Rationale for this change
# Are these changes tested?
# Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to
71 matches
Mail list logo
