ebyhr commented on code in PR #12784:
URL: https://github.com/apache/iceberg/pull/12784#discussion_r2041101703
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -1109,6 +1110,22 @@ public void testAddFilesPartitionedWithParallelism() {
sql("SELECT id, name, dept, subdept FROM %s ORDER BY id", tableName));
}
+ @TestTemplate
+ public void testMigrateWithInvalidParallelism() throws IOException {
+ createUnpartitionedHiveTable();
+
+ createIcebergTable(
+ "id Integer, name String, dept String, subdept String", "PARTITIONED
BY (id)");
+
+ assertThatThrownBy(
+ () ->
+ sql(
+ "CALL %s.system.add_files(table => '%s', source_table =>
'%s', parallelism => %d)",
+ catalogName, tableName, sourceTableName, -1))
Review Comment:
nit: We can inline `-1`.
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -1109,6 +1110,22 @@ public void testAddFilesPartitionedWithParallelism() {
sql("SELECT id, name, dept, subdept FROM %s ORDER BY id", tableName));
}
+ @TestTemplate
+ public void testMigrateWithInvalidParallelism() throws IOException {
Review Comment:
```suggestion
public void testAddFilesWithInvalidParallelism() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
