Re: [PR] Add pure virtual classes for Catalog, Table, etc. [iceberg-cpp]

2025-03-22 Thread via GitHub
lidavidm commented on code in PR #47: URL: https://github.com/apache/iceberg-cpp/pull/47#discussion_r2007071791 ## src/iceberg/table_identifier.h: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

[PR] fix(table): fix funky test paths [iceberg-go]

2025-03-22 Thread via GitHub
zeroshade opened a new pull request, #351: URL: https://github.com/apache/iceberg-go/pull/351 fixes #346 Was using the wrong path when generating the Metadata in the tests `createTable` method. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Implementation of version metadata table for view [iceberg]

2025-03-22 Thread via GitHub
huan233usc commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r2009018423 ## core/src/main/java/org/apache/iceberg/BaseViewMetadataTable.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Implementation of version metadata table for view [iceberg]

2025-03-22 Thread via GitHub
huan233usc commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r2009018192 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -2109,6 +2109,34 @@ public void createViewWithCustomMetadata

Re: [PR] Implementation of version metadata table for view [iceberg]

2025-03-22 Thread via GitHub
huan233usc commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r2009017632 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1639,6 +1641,29 @@ public void updateViewLocationConflict() { .hasMessageConta

Re: [PR] Implementation of version metadata table for view [iceberg]

2025-03-22 Thread via GitHub
huan233usc commented on code in PR #12014: URL: https://github.com/apache/iceberg/pull/12014#discussion_r2009016220 ## core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java: ## @@ -67,6 +71,31 @@ public View loadView(TableIdentifier identifier) { throw ne

[PR] Build: Bump parquet from 1.15.0 to 1.15.1 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12616: URL: https://github.com/apache/iceberg/pull/12616 Bumps `parquet` from 1.15.0 to 1.15.1. Updates `org.apache.parquet:parquet-avro` from 1.15.0 to 1.15.1 Release notes Sourced from https://github.com/apache/parquet-mr/releases";>o

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.55.0 to 26.56.0 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] commented on PR #12485: URL: https://github.com/apache/iceberg/pull/12485#issuecomment-2746015882 Superseded by #12619. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Build: Bump calcite from 1.10.0 to 1.39.0 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12617: URL: https://github.com/apache/iceberg/pull/12617 Bumps `calcite` from 1.10.0 to 1.39.0. Updates `org.apache.calcite:calcite-core` from 1.10.0 to 1.39.0 Commits https://github.com/apache/calcite/commit/0b328db78cca67b7b3407e7

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.55.0 to 26.56.0 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] closed pull request #12485: Build: Bump com.google.cloud:libraries-bom from 26.55.0 to 26.56.0 URL: https://github.com/apache/iceberg/pull/12485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Build: Bump com.google.cloud:libraries-bom from 26.55.0 to 26.57.0 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12619: URL: https://github.com/apache/iceberg/pull/12619 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.55.0 to 26.57.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bo

[PR] Build: Bump jetty from 11.0.24 to 11.0.25 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12618: URL: https://github.com/apache/iceberg/pull/12618 Bumps `jetty` from 11.0.24 to 11.0.25. Updates `org.eclipse.jetty:jetty-server` from 11.0.24 to 11.0.25 Updates `org.eclipse.jetty:jetty-servlet` from 11.0.24 to 11.0.25 D

[PR] Build: Bump com.google.errorprone:error_prone_annotations from 2.36.0 to 2.37.0 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12622: URL: https://github.com/apache/iceberg/pull/12622 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.36.0 to 2.37.0. Release notes Sourced from https://github.com/google/error-prone

[PR] Build: Bump software.amazon.awssdk:bom from 2.30.31 to 2.31.6 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12621: URL: https://github.com/apache/iceberg/pull/12621 Bumps software.amazon.awssdk:bom from 2.30.31 to 2.31.6. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softw

[PR] Build: Bump guava from 33.4.0-jre to 33.4.5-jre [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12620: URL: https://github.com/apache/iceberg/pull/12620 Bumps `guava` from 33.4.0-jre to 33.4.5-jre. Updates `com.google.guava:guava` from 33.4.0-jre to 33.4.5-jre Release notes Sourced from https://github.com/google/guava/releases";>c

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.30.31 to 2.31.1 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] closed pull request #12536: Build: Bump software.amazon.awssdk:bom from 2.30.31 to 2.31.1 URL: https://github.com/apache/iceberg/pull/12536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Build: Bump nessie from 0.103.0 to 0.103.2 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12615: URL: https://github.com/apache/iceberg/pull/12615 Bumps `nessie` from 0.103.0 to 0.103.2. Updates `org.projectnessie.nessie:nessie-client` from 0.103.0 to 0.103.2 Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.

[PR] Build: Bump mkdocs-material from 9.6.8 to 9.6.9 [iceberg]

2025-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12614: URL: https://github.com/apache/iceberg/pull/12614 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.8 to 9.6.9. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdocs-

[PR] add missing iceberg_export.h [iceberg-cpp]

2025-03-22 Thread via GitHub
zhjwpku opened a new pull request, #48: URL: https://github.com/apache/iceberg-cpp/pull/48 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [I] Spark Streaming Job with multiple queries MERGE INTO the same target table (Runtime file filtering is not possible) [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #11094: URL: https://github.com/apache/iceberg/issues/11094#issuecomment-2745929580 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

[PR] Core: Add option to fallback to thread classloader [iceberg]

2025-03-22 Thread via GitHub
bryanck opened a new pull request, #12613: URL: https://github.com/apache/iceberg/pull/12613 Spark loads jars from the classpath into the app classloader. The Spark submit command loads jars specified in the command into a classloader that is a child of the app classloader. If the Iceberg j

Re: [I] Retry logic in JDBC catalog fails with class cast exception if driver exception class does not extend SQLTransientException [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #11176: URL: https://github.com/apache/iceberg/issues/11176#issuecomment-2745929608 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] WIP Parquet: Support reading/writing geometry and geography columns [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] commented on PR #12347: URL: https://github.com/apache/iceberg/pull/12347#issuecomment-2745929637 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Add pure virtual classes for Catalog, Table, etc. [iceberg-cpp]

2025-03-22 Thread via GitHub
wgtmac commented on code in PR #47: URL: https://github.com/apache/iceberg-cpp/pull/47#discussion_r2007167457 ## src/iceberg/table_operations.h: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [I] Spark Streaming Job with multiple queries MERGE INTO the same target table (Runtime file filtering is not possible) [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] closed issue #11094: Spark Streaming Job with multiple queries MERGE INTO the same target table (Runtime file filtering is not possible) URL: https://github.com/apache/iceberg/issues/11094 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [I] com.esotericsoftware.kryo.KryoException: java.lang.ClassCastException: java.lang.Integer cannot be cast to java.nio.ByteBuffer [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] closed issue #9738: com.esotericsoftware.kryo.KryoException: java.lang.ClassCastException: java.lang.Integer cannot be cast to java.nio.ByteBuffer URL: https://github.com/apache/iceberg/issues/9738 -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Add integration tests with PostgreSQL DB backend [iceberg-python]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #1178: URL: https://github.com/apache/iceberg-python/issues/1178#issuecomment-2745930637 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Fast Avro Decoder not included in Conda Deployment of pyiceberg [iceberg-python]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #1093: URL: https://github.com/apache/iceberg-python/issues/1093#issuecomment-2745930649 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] REPLACE TABLE Support [iceberg-python]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #281: URL: https://github.com/apache/iceberg-python/issues/281#issuecomment-2745930662 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity oc

Re: [I] Iceberg Read is not working on Iceberg Hive table [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #11168: URL: https://github.com/apache/iceberg/issues/11168#issuecomment-2745929596 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Iceberg Glue Concurrent Update can result in missing metadata_location [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #9411: URL: https://github.com/apache/iceberg/issues/9411#issuecomment-2745929545 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Iceberg Glue Concurrent Update can result in missing metadata_location [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] closed issue #9411: Iceberg Glue Concurrent Update can result in missing metadata_location URL: https://github.com/apache/iceberg/issues/9411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Improve `All` Metadata Tables with Snapshot Information [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #8856: URL: https://github.com/apache/iceberg/issues/8856#issuecomment-2745929530 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Support create table `PRIMARY KEY` column via Spark sql? [iceberg]

2025-03-22 Thread via GitHub
github-actions[bot] commented on issue #5069: URL: https://github.com/apache/iceberg/issues/5069#issuecomment-2745929525 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Support Filters on Top-Level Struct Fields [iceberg-python]

2025-03-22 Thread via GitHub
srilman commented on code in PR #1832: URL: https://github.com/apache/iceberg-python/pull/1832#discussion_r2008850938 ## tests/test_schema.py: ## @@ -925,7 +926,7 @@ def primitive_fields() -> List[NestedField]: ] -def test_add_top_level_primitives(primitive_fields: Nest

[PR] Support Filters on Top-Level Struct Fields [iceberg-python]

2025-03-22 Thread via GitHub
srilman opened a new pull request, #1832: URL: https://github.com/apache/iceberg-python/pull/1832 Closes #1778. # Rationale for this change Current, filters that are applied to the top-level struct column do not work. For example, given a table of schema: ``` table {

Re: [PR] fix(table): fix funky test paths [iceberg-go]

2025-03-22 Thread via GitHub
zeroshade merged PR #351: URL: https://github.com/apache/iceberg-go/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Spark 3.4: Rewrite data files with high delete ratio [iceberg]

2025-03-22 Thread via GitHub
amogh-jahagirdar commented on PR #12601: URL: https://github.com/apache/iceberg/pull/12601#issuecomment-2745349027 Thanks @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] Add support for `Transaction.update_statistics()` [iceberg-python]

2025-03-22 Thread via GitHub
srilman opened a new pull request, #1831: URL: https://github.com/apache/iceberg-python/pull/1831 # Rationale for this change Addd a new API `Transaction.update_statistics()` to use the existing transaction instead of a brand new one. # Are these changes tested? I extend

Re: [PR] Add Arrow C Data Interface and nanoarrow dependency [iceberg-cpp]

2025-03-22 Thread via GitHub
Fokko commented on PR #44: URL: https://github.com/apache/iceberg-cpp/pull/44#issuecomment-2742715984 This looks good to me, thanks @wgtmac for working on this, and thanks @lidavidm and @zhjwpku for the review 👍 -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Spark 3.4: Rewrite V2 deletes to V3 DVs / Detect dangling DVs properly [iceberg]

2025-03-22 Thread via GitHub
amogh-jahagirdar commented on PR #12606: URL: https://github.com/apache/iceberg/pull/12606#issuecomment-2745359150 Thanks @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Spark 3.4: Rewrite V2 deletes to V3 DVs / Detect dangling DVs properly [iceberg]

2025-03-22 Thread via GitHub
amogh-jahagirdar merged PR #12606: URL: https://github.com/apache/iceberg/pull/12606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Spark 3.4: Rewrite data files with high delete ratio [iceberg]

2025-03-22 Thread via GitHub
amogh-jahagirdar merged PR #12601: URL: https://github.com/apache/iceberg/pull/12601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[PR] fix: safety ci using static check zizmor [iceberg-rust]

2025-03-22 Thread via GitHub
yihong0618 opened a new pull request, #1123: URL: https://github.com/apache/iceberg-rust/pull/1123 ## Which issue does this PR close? this patch make ci more safety using static check zizmor: to avoid code injection more: - https://github.com/apache/airflow/issues/4

[PR] Core: Enable row lineage for all v3 tables [iceberg]

2025-03-22 Thread via GitHub
rdblue opened a new pull request, #12593: URL: https://github.com/apache/iceberg/pull/12593 This removes sections of #11948 that allow row lineage to be enabled or disabled. Instead, row lineage is always on for v3 tables. **Note**: This is a work-in-progress and merging should wait u

Re: [I] Commit fails because S3 checksum does match when calling PutObject [iceberg]

2025-03-22 Thread via GitHub
dmytroi11i closed issue #12577: Commit fails because S3 checksum does match when calling PutObject URL: https://github.com/apache/iceberg/issues/12577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Move implementation of upsert from Table to Transaction [iceberg-python]

2025-03-22 Thread via GitHub
koenvo commented on PR #1817: URL: https://github.com/apache/iceberg-python/pull/1817#issuecomment-2745302629 Agree! I will work on the test. With "update" you mean "delete", right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Move implementation of upsert from Table to Transaction [iceberg-python]

2025-03-22 Thread via GitHub
mattmartin14 commented on PR #1817: URL: https://github.com/apache/iceberg-python/pull/1817#issuecomment-2745289992 I think since the transaction wrapper has been moved out, there should be a unit test added to do partial upsert and then throw an error and ensure the rollback occurs and we

[I] how to enable in compaction status, Snapshot retention status, orphan file deletion status on aws glue tables.for reference i have [iceberg-python]

2025-03-22 Thread via GitHub
dvnageshpatil opened a new issue, #1829: URL: https://github.com/apache/iceberg-python/issues/1829 ### Question how to enable in **compaction status, Snapshot retention status, orphan file deletion** status on aws glue tables.for reference i have attached the screenshot ![Ima

Re: [PR] S3: Disable strong integrity checksums [iceberg]

2025-03-22 Thread via GitHub
ebyhr commented on code in PR #12264: URL: https://github.com/apache/iceberg/pull/12264#discussion_r2006998899 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ## @@ -275,6 +275,7 @@ private List deleteBatch(String bucket, Collection keysToDelete) DeleteOb

Re: [PR] Core, Parquet, ORC: Fix missing data when writing unknown [iceberg]

2025-03-22 Thread via GitHub
pvary commented on code in PR #12581: URL: https://github.com/apache/iceberg/pull/12581#discussion_r2005681428 ## orc/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriter.java: ## @@ -156,8 +156,8 @@ public Stream> metrics() { private static class RecordWriter extends

Re: [PR] Fix CLI command order and catalog not found error [iceberg-python]

2025-03-22 Thread via GitHub
jason810496 commented on code in PR #1828: URL: https://github.com/apache/iceberg-python/pull/1828#discussion_r2008723316 ## pyiceberg/cli/console.py: ## @@ -86,31 +91,48 @@ def run( ctx.obj["output"] = JsonOutput(verbose=verbose) try: -ctx.obj["catalog"]

Re: [PR] Fix CLI command order and catalog not found error [iceberg-python]

2025-03-22 Thread via GitHub
jason810496 commented on code in PR #1828: URL: https://github.com/apache/iceberg-python/pull/1828#discussion_r2008723316 ## pyiceberg/cli/console.py: ## @@ -86,31 +91,48 @@ def run( ctx.obj["output"] = JsonOutput(verbose=verbose) try: -ctx.obj["catalog"]

Re: [PR] Fix CLI command order and catalog not found error [iceberg-python]

2025-03-22 Thread via GitHub
jason810496 commented on code in PR #1828: URL: https://github.com/apache/iceberg-python/pull/1828#discussion_r2008722936 ## pyiceberg/cli/console.py: ## @@ -86,31 +91,48 @@ def run( ctx.obj["output"] = JsonOutput(verbose=verbose) try: -ctx.obj["catalog"]

Re: [PR] Fix CLI command order and catalog not found error [iceberg-python]

2025-03-22 Thread via GitHub
jason810496 commented on code in PR #1828: URL: https://github.com/apache/iceberg-python/pull/1828#discussion_r200870 ## pyiceberg/cli/console.py: ## @@ -86,31 +91,48 @@ def run( ctx.obj["output"] = JsonOutput(verbose=verbose) try: -ctx.obj["catalog"]

[PR] Fix CLI command order and catalog not found error [iceberg-python]

2025-03-22 Thread via GitHub
iting0321 opened a new pull request, #1828: URL: https://github.com/apache/iceberg-python/pull/1828 Closes #1784 # Rationale for this change The command order for `pyiceberg list --catalog hive` would raise error; it should be `pyiceberg --catalog hive list`. Now, `pyiceberg l

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

2025-03-22 Thread via GitHub
rdblue commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2008312950 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +565,148 @@ public int hashCode() { } } + public static class GeometryType extends Pr

Re: [PR] Feature: Write to branches [iceberg-python]

2025-03-22 Thread via GitHub
malcolmbovey commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2745126233 Hi, just wondering if there is an update on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] API: Follow up on adding Variant data type to implement sanitizing for Variant [iceberg]

2025-03-22 Thread via GitHub
manirajv06 commented on issue #11479: URL: https://github.com/apache/iceberg/issues/11479#issuecomment-2745116978 @aihuaxu Raised my first pr and added comments. Please check. Can you provide me appropriate rights to add reviewers and assign pr to myself? Thanks. -- This is an automated m

Re: [PR] API: Follow up on adding Variant data type to implement sanitizing fo… [iceberg]

2025-03-22 Thread via GitHub
manirajv06 commented on PR #12611: URL: https://github.com/apache/iceberg/pull/12611#issuecomment-2745114645 @aihuaxu Since this is first PR, need to discuss few things before in hand to ensure the direction is correct. Hence, marking the pr as draft for now. Added a new metho