rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2008312950
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +565,148 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ if (crs != null) {
+ Preconditions.checkArgument(!crs.isEmpty(), "Invalid CRS: (empty
string)");
+ Preconditions.checkArgument(
+ crs.trim().equals(crs), "CRS must not have leading or trailing
spaces: '%s'", crs);
+ this.crs = crs;
+ } else {
+ this.crs = null;
+ }
+ }
+
+ private GeometryType() {
+ crs = null;
+ }
+
+ public static GeometryType crs84() {
Review Comment:
Static factory methods typically go above constructors, and the no-arg
constructor usually comes first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
