Re: [PR] [WIP] Ignore UnknownType in General Parquet Writer [iceberg]

2025-02-05 Thread via GitHub
HonahX commented on code in PR #12177: URL: https://github.com/apache/iceberg/pull/12177#discussion_r1944246239 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java: ## @@ -386,6 +390,20 @@ public void write(int repetitionLevel, UUID value) { } }

Re: [PR] backport c++23 std::expected [iceberg-cpp]

2025-02-05 Thread via GitHub
zhjwpku commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2639011661 @Fokko @Xuanwo I'd appreciate it if you could review this backport of `std::expected`. While we haven't yet decided whether to use `expected` over `exception`, having this backport ready

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
jbonofre commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1944194876 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -500,9 +363,312 @@ file: This binary artifact includes Project Nessie with the following in its NOTICE file: -| Dremio

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
jbonofre commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1944194876 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -500,9 +363,312 @@ file: This binary artifact includes Project Nessie with the following in its NOTICE file: -| Dremio

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
jbonofre commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1944201723 ## spark/v3.5/spark-runtime/LICENSE: ## @@ -583,7 +467,7 @@ License text: This binary artifact contains code from Project Nessie. -Copyright: 2020 Dremio Corpor

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
jbonofre commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1944195410 ## spark/v3.5/spark-runtime/LICENSE: ## @@ -583,7 +467,7 @@ License text: This binary artifact contains code from Project Nessie. -Copyright: 2020 Dremio Corpor

Re: [PR] Core: Change RemoveSnapshots to remove unused schemas [iceberg]

2025-02-05 Thread via GitHub
gaborkaszab commented on PR #12089: URL: https://github.com/apache/iceberg/pull/12089#issuecomment-2638983726 cc @advancedxy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] OpenAPI: Add RemoveSchemas REST update type [iceberg]

2025-02-05 Thread via GitHub
gaborkaszab commented on PR #12022: URL: https://github.com/apache/iceberg/pull/12022#issuecomment-2638983371 cc @advancedxy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
jbonofre commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1944187860 ## spark/v3.5/spark-runtime/LICENSE: ## @@ -403,22 +350,6 @@ License: http://www.apache.org/licenses/LICENSE-2.0

Re: [PR] Fix NOTICE and LICENSE in the gcp-bundle jar [iceberg]

2025-02-05 Thread via GitHub
jbonofre commented on code in PR #12144: URL: https://github.com/apache/iceberg/pull/12144#discussion_r1944184374 ## gcp-bundle/LICENSE: ## @@ -325,24 +315,30 @@ License: The Apache Software License, Version 2.0 - http://www.apache.org/licens ---

Re: [I] Add files to add existing Parquet files to a table [iceberg-rust]

2025-02-05 Thread via GitHub
ZENOTME commented on issue #932: URL: https://github.com/apache/iceberg-rust/issues/932#issuecomment-2638948709 > [@ZENOTME](https://github.com/ZENOTME) When appending existing data files, should the system load file metadata by reading the current snapshot’s manifest lists from an existing

Re: [PR] [infra] add testpypi nightly build [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on code in PR #1601: URL: https://github.com/apache/iceberg-python/pull/1601#discussion_r1944116682 ## .github/workflows/nightly-pypi-build.yml: ## @@ -0,0 +1,89 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on PR #1590: URL: https://github.com/apache/iceberg-python/pull/1590#issuecomment-2638868270 duplicate of #1533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu closed pull request #1590: 1191:Added Docstring and Fixed linter error URL: https://github.com/apache/iceberg-python/pull/1590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [infra] add testpypi nightly build [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on PR #1601: URL: https://github.com/apache/iceberg-python/pull/1601#issuecomment-2638864904 @Fokko i refactor the code to remove `RC`, thanks for the suggestion! I was able to rerun on my fork and published to [pyiceberg-kevinliu 0.9.0rc20250203](https://test.pypi.o

Re: [I] How to read/write Iceberg table from/to ADLS gen 2 container with PyIceberg [iceberg-python]

2025-02-05 Thread via GitHub
martinseifertprojuventute commented on issue #1588: URL: https://github.com/apache/iceberg-python/issues/1588#issuecomment-2638820605 Hey @HungYangChang Did you try to `table.scan().to_pandas()` with that? I still fail at that step :/ -- This is an automated message from the Apac

Re: [PR] [infra] add testpypi nightly build [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on code in PR #1601: URL: https://github.com/apache/iceberg-python/pull/1601#discussion_r1944091552 ## .github/workflows/pypi-build-artifacts.yml: ## @@ -35,7 +35,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: -os: [ ubuntu-2

Re: [I] Build new `TableMetadata` without reassigning field IDs [iceberg-rust]

2025-02-05 Thread via GitHub
kevinjqliu commented on issue #919: URL: https://github.com/apache/iceberg-rust/issues/919#issuecomment-2638795348 For python, you can just pass in the Schema to the constructor https://github.com/apache/iceberg-python/blob/26eff992715fdf22c020c0f1da8a38afad55f7be/tests/catalog/test_hive

Re: [PR] Added support for Polars DataFrame [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on code in PR #1614: URL: https://github.com/apache/iceberg-python/pull/1614#discussion_r1944069870 ## pyiceberg/table/__init__.py: ## @@ -1624,6 +1628,19 @@ def to_ray(self) -> ray.data.dataset.Dataset: return ray.data.from_arrow(self.to_arrow())

Re: [I] Add V3 type `unknown` [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on issue #1553: URL: https://github.com/apache/iceberg-python/issues/1553#issuecomment-2638778152 sure @kaushiksrini feel free to create a PR and reference this issue :) -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] Create table format version constants [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on issue #851: URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2638775180 @iyad-f I think we can start it and see where it takes us. its a good exercise to see where we use version numbers. esp now that we need to add V3 -- This is an automated

Re: [PR] Build: Bump mkdocstrings-python from 1.14.4 to 1.14.5 [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu merged PR #1616: URL: https://github.com/apache/iceberg-python/pull/1616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Build: Bump duckdb from 1.1.3 to 1.2.0 [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on PR #1617: URL: https://github.com/apache/iceberg-python/pull/1617#issuecomment-2638771655 CI issue confirmed in https://github.com/duckdb/duckdb/issues/16076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on code in PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1943674177 ## pyiceberg/table/__init__.py: ## @@ -1064,6 +1067,78 @@ def name_mapping(self) -> Optional[NameMapping]: """Return the table's field-id NameMapping

Re: [I] DOCS: Improve Documentation on Write Support [iceberg-python]

2025-02-05 Thread via GitHub
shrutisachan08 commented on issue #1008: URL: https://github.com/apache/iceberg-python/issues/1008#issuecomment-2638733950 Hii, I would like to work on this. I can update documentation by adding separate subsections for each write mode(append, overwrite, delete). I can insert some examples

Re: [PR] Docs: Remove data_file.distinct_counts [iceberg]

2025-02-05 Thread via GitHub
edgarRd commented on PR #12183: URL: https://github.com/apache/iceberg/pull/12183#issuecomment-2638617512 @Fokko > This should have happened a while ago to avoid unnecessary confusion. Looking at this made me realize I had a similar [PR a year ago](https://github.com/apache/iceber

Re: [I] Should be null_value_counts updated after adding a new column to the schema? [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] closed issue #10773: Should be null_value_counts updated after adding a new column to the schema? URL: https://github.com/apache/iceberg/issues/10773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Bump Nessie to include updated License/Notice [iceberg]

2025-02-05 Thread via GitHub
amogh-jahagirdar merged PR #12186: URL: https://github.com/apache/iceberg/pull/12186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] closed pull request #11313: Kafka Connect: Add config to route to tables using topic name URL: https://github.com/apache/iceberg/pull/11313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Hive: Add Hive 4 support and remove Hive runtime [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] commented on PR #11750: URL: https://github.com/apache/iceberg/pull/11750#issuecomment-2638321159 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] Azure Databricks Azure databricks 14.3 LTS runtime with apache iceberg 1.5.2 spark 3.5.0 and scala 2.12 Error [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] closed issue #10789: Azure Databricks Azure databricks 14.3 LTS runtime with apache iceberg 1.5.2 spark 3.5.0 and scala 2.12 Error URL: https://github.com/apache/iceberg/issues/10789 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] Should be null_value_counts updated after adding a new column to the schema? [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] commented on issue #10773: URL: https://github.com/apache/iceberg/issues/10773#issuecomment-2638320905 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Kafka Connect: Add config to route to tables using topic name [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] commented on PR #11313: URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2638321108 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] Azure Databricks Azure databricks 14.3 LTS runtime with apache iceberg 1.5.2 spark 3.5.0 and scala 2.12 Error [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] commented on issue #10789: URL: https://github.com/apache/iceberg/issues/10789#issuecomment-2638320970 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Error configuration key in document [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] closed issue #10785: Error configuration key in document URL: https://github.com/apache/iceberg/issues/10785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Error configuration key in document [iceberg]

2025-02-05 Thread via GitHub
github-actions[bot] commented on issue #10785: URL: https://github.com/apache/iceberg/issues/10785#issuecomment-2638320935 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1943818949 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantReaders.java: ## @@ -0,0 +1,409 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1943809738 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantReaders.java: ## @@ -0,0 +1,409 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1943800768 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantReaders.java: ## @@ -0,0 +1,409 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1943787663 ## spark/v3.5/spark-runtime/LICENSE: ## @@ -583,7 +467,7 @@ License text: This binary artifact contains code from Project Nessie. -Copyright: 2020 Dremio Corporat

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1943787663 ## spark/v3.5/spark-runtime/LICENSE: ## @@ -583,7 +467,7 @@ License text: This binary artifact contains code from Project Nessie. -Copyright: 2020 Dremio Corporat

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1943784586 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -500,9 +363,312 @@ file: This binary artifact includes Project Nessie with the following in its NOTICE file: -| Dremio -|

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1943783507 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -500,9 +363,312 @@ file: This binary artifact includes Project Nessie with the following in its NOTICE file: -| Dremio -|

Re: [PR] Added support for Polars DataFrame [iceberg-python]

2025-02-05 Thread via GitHub
yigal-rozenberg commented on PR #1614: URL: https://github.com/apache/iceberg-python/pull/1614#issuecomment-2638211161 Thanks for the comment! I can add this to the documentation as an alternative. The motivations was to extend existing PyIceberg table API to align with 'to_pandas' as

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
tscottcoombes1 commented on code in PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1943771982 ## pyproject.toml: ## @@ -99,17 +101,24 @@ docutils = "!=0.21.post1" # https://github.com/python-poetry/poetry/issues/924 [tool.poetry.group.docs.depe

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
tscottcoombes1 commented on code in PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1943711166 ## pyiceberg/table/__init__.py: ## @@ -1064,6 +1067,78 @@ def name_mapping(self) -> Optional[NameMapping]: """Return the table's field-id NameMap

[PR] Build: Bump duckdb from 1.1.3 to 1.2.0 [iceberg-python]

2025-02-05 Thread via GitHub
dependabot[bot] opened a new pull request, #1617: URL: https://github.com/apache/iceberg-python/pull/1617 Bumps [duckdb](https://github.com/duckdb/duckdb) from 1.1.3 to 1.2.0. Release notes Sourced from https://github.com/duckdb/duckdb/releases";>duckdb's releases. DuckDB 1.2

[PR] Build: Bump mkdocstrings-python from 1.14.4 to 1.14.5 [iceberg-python]

2025-02-05 Thread via GitHub
dependabot[bot] opened a new pull request, #1616: URL: https://github.com/apache/iceberg-python/pull/1616 Bumps [mkdocstrings-python](https://github.com/mkdocstrings/python) from 1.14.4 to 1.14.5. Release notes Sourced from https://github.com/mkdocstrings/python/releases";>mkdocstr

Re: [I] Add files to add existing Parquet files to a table [iceberg-rust]

2025-02-05 Thread via GitHub
jonathanc-n commented on issue #932: URL: https://github.com/apache/iceberg-rust/issues/932#issuecomment-2638113131 @ZENOTME When appending existing data files, should the system load file metadata by reading the current snapshot’s manifest lists from an existing Iceberg table, or would you

[PR] position_deletes metadata table [iceberg-python]

2025-02-05 Thread via GitHub
amitgilad3 opened a new pull request, #1615: URL: https://github.com/apache/iceberg-python/pull/1615 Implements position_deletes metadata table - https://github.com/apache/iceberg-python/issues/1053 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] Build new `TableMetadata` without reassigning field IDs [iceberg-rust]

2025-02-05 Thread via GitHub
jdockerty commented on issue #919: URL: https://github.com/apache/iceberg-rust/issues/919#issuecomment-2638081901 > in pyiceberg, we have a function that will reassign field-ids and return a TableMetadata object Yeah, I missed the link into the main issue description, but I noticed th

Re: [PR] Added support for Polars DataFrame [iceberg-python]

2025-02-05 Thread via GitHub
corleyma commented on PR #1614: URL: https://github.com/apache/iceberg-python/pull/1614#issuecomment-2638079043 At first glance, this approach seems fairly inferior to using the Polars [scan_iceberg ](https://docs.pola.rs/api/python/dev/reference/api/polars.scan_iceberg.html) functionality

Re: [PR] Added support for Polars DataFrame [iceberg-python]

2025-02-05 Thread via GitHub
yigal-rozenberg commented on code in PR #1614: URL: https://github.com/apache/iceberg-python/pull/1614#discussion_r1943690450 ## pyproject.toml: ## @@ -1183,6 +1184,766 @@ ignore_missing_imports = true module = "tenacity.*" ignore_missing_imports = true +[[tool.mypy.override

Re: [PR] Added support for Polars DataFrame [iceberg-python]

2025-02-05 Thread via GitHub
yigal-rozenberg commented on code in PR #1614: URL: https://github.com/apache/iceberg-python/pull/1614#discussion_r1943690450 ## pyproject.toml: ## @@ -1183,6 +1184,766 @@ ignore_missing_imports = true module = "tenacity.*" ignore_missing_imports = true +[[tool.mypy.override

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-02-05 Thread via GitHub
amitgilad3 commented on PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#issuecomment-2638045119 Ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2638039558 > late to the party, but i'll take a look too. Thanks for all the hard work here everyone!! Great @kevinjqliu . I think we are in good shape at this point. To bring you

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2638020679 late to the party, but i'll take a look too. Thanks for all the hard work here everyone!! -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2638010278 @Fokko @tscottcoombes1 - i think all remaining changes are in; my pytests all ran successfully; can you please check one more time on your end? -- This is an automated messa

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
mattmartin14 commented on code in PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1943653910 ## pyiceberg/table/__init__.py: ## @@ -1064,6 +1067,81 @@ def name_mapping(self) -> Optional[NameMapping]: """Return the table's field-id NameMappi

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
mattmartin14 commented on code in PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1943644143 ## pyiceberg/table/__init__.py: ## @@ -1064,6 +1067,81 @@ def name_mapping(self) -> Optional[NameMapping]: """Return the table's field-id NameMappi

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
mattmartin14 commented on code in PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1943641367 ## tests/table/test_merge_rows.py: ## @@ -0,0 +1,380 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
mattmartin14 commented on code in PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1943645378 ## pyiceberg/table/__init__.py: ## @@ -1064,6 +1067,81 @@ def name_mapping(self) -> Optional[NameMapping]: """Return the table's field-id NameMappi

Re: [PR] Feature: MERGE/Upsert Support [iceberg-python]

2025-02-05 Thread via GitHub
mattmartin14 commented on code in PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1943643310 ## pyiceberg/expressions/literals.py: ## @@ -28,6 +28,8 @@ from math import isnan from typing import Any, Generic, Type from uuid import UUID +from datet

Re: [I] Build new `TableMetadata` without reassigning field IDs [iceberg-rust]

2025-02-05 Thread via GitHub
kevinjqliu commented on issue #919: URL: https://github.com/apache/iceberg-rust/issues/919#issuecomment-2637971231 It makes sense to be able to create an `TableMetadata` object without automatically assigning the field-ids. Esp for use cases such as what you described above. How we

Re: [I] How to read/write Iceberg table from/to ADLS gen 2 container with PyIceberg [iceberg-python]

2025-02-05 Thread via GitHub
HungYangChang closed issue #1588: How to read/write Iceberg table from/to ADLS gen 2 container with PyIceberg URL: https://github.com/apache/iceberg-python/issues/1588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943623327 ## build.gradle: ## @@ -157,7 +157,7 @@ subprojects { rootTask.finalizedBy showDeprecationRulesOnRevApiFailure } } - + Review Comment: Unn

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943622533 ## build.gradle: ## @@ -636,6 +636,45 @@ project(':iceberg-delta-lake') { } } +project(':iceberg-bigquery') { + test { +useJUnitPlatform() + } + + depende

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r194362 ## build.gradle: ## @@ -636,6 +636,45 @@ project(':iceberg-delta-lake') { } } +project(':iceberg-bigquery') { + test { +useJUnitPlatform() + } + + depende

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943620170 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943619867 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943617650 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943617650 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943616455 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943615685 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

[PR] Bump Nessie to include updated License/Notice [iceberg]

2025-02-05 Thread via GitHub
amogh-jahagirdar opened a new pull request, #12186: URL: https://github.com/apache/iceberg/pull/12186 Nessie https://github.com/projectnessie/nessie/releases/tag/nessie-0.102.5 has updated License/Notice changes required to unblock the 1.8 release -- This is an automated message from the

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943611905 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943611005 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

[PR] tweak dependabot to bundle all go mod upgrades into the same PR [iceberg-go]

2025-02-05 Thread via GitHub
raidancampbell opened a new pull request, #289: URL: https://github.com/apache/iceberg-go/pull/289 The intent of this PR is to configure dependabot to bundle these dependency upgrades together in one PR instead of one PR per dependency bump. It looks like #281, #282, #283, #284, and #

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943610664 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943610203 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943609820 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943608036 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943605981 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClient.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[I] GlueCatalog name validation [iceberg]

2025-02-05 Thread via GitHub
devinrsmith opened a new issue, #12185: URL: https://github.com/apache/iceberg/issues/12185 ### Apache Iceberg version 1.7.1 (latest release) ### Query engine None ### Please describe the bug 🐞 I was confused for a while why a GlueCatalog I had constructed w

[PR] Run dependabot daily [iceberg]

2025-02-05 Thread via GitHub
Fokko opened a new pull request, #12184: URL: https://github.com/apache/iceberg/pull/12184 It would be nice to get notified of updates more frequently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

2025-02-05 Thread via GitHub
jbonofre commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1943585204 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -63,29 +63,277 @@ NOTICE file: -Thi

Re: [I] How to read/write Iceberg table from/to ADLS gen 2 container with PyIceberg [iceberg-python]

2025-02-05 Thread via GitHub
HungYangChang commented on issue #1588: URL: https://github.com/apache/iceberg-python/issues/1588#issuecomment-2637890569 I found out actually it's not the file_io issue I am able to solved it My new code with testing against lakekeepr ``` set up env variable (this solves

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943579431 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClient.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Fix NOTICE and LICENSE in the spark-runtime jar [iceberg]

2025-02-05 Thread via GitHub
jbonofre commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1943578107 ## spark/v3.5/spark-runtime/NOTICE: ## @@ -500,9 +363,52 @@ file: This binary artifact includes Project Nessie with the following in its NOTICE file: +| NOTICE a

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943575699 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java: ## @@ -0,0 +1,492 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943574434 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java: ## @@ -0,0 +1,492 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943572308 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java: ## @@ -0,0 +1,492 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943571247 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java: ## @@ -0,0 +1,492 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943569098 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java: ## @@ -0,0 +1,492 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943568625 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java: ## @@ -0,0 +1,492 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943567072 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java: ## @@ -0,0 +1,492 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #11039: URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943563130 ## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Added support for Polars DataFrame [iceberg-python]

2025-02-05 Thread via GitHub
yigal-rozenberg commented on PR #1614: URL: https://github.com/apache/iceberg-python/pull/1614#issuecomment-2637856975 I will provide with the relevant documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1943546072 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantReaders.java: ## @@ -0,0 +1,409 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Parquet: Implement Variant readers [iceberg]

2025-02-05 Thread via GitHub
rdblue commented on code in PR #12139: URL: https://github.com/apache/iceberg/pull/12139#discussion_r1943546072 ## parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantReaders.java: ## @@ -0,0 +1,409 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

  1   2   3   >