Re: [PR] Spark 3.5: Iceberg / DataFusion Comet integration [iceberg]

huaxingao commented on PR #12147: URL: https://github.com/apache/iceberg/pull/12147#issuecomment-2628836704 Thanks a lot @aokolnychyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Spark 3.5: Iceberg / DataFusion Comet integration [iceberg]

aokolnychyi merged PR #12147: URL: https://github.com/apache/iceberg/pull/12147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Spark 3.5: Iceberg / DataFusion Comet integration [iceberg]

aokolnychyi commented on code in PR #12147: URL: https://github.com/apache/iceberg/pull/12147#discussion_r1938223234 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java: ## @@ -27,6 +27,9 @@ private SparkSQLProperties() {} // Controls whether ve

Re: [PR] Flink: Replace use of deprecated methods [iceberg]

jbonofre commented on PR #11658: URL: https://github.com/apache/iceberg/pull/11658#issuecomment-2628808344 I will resume this "cleaning" on Flink (I'm focusing on Flink right now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Core, Spark: Exclude non live content file in RewriteTablePathUtil [iceberg]

szehon-ho commented on code in PR #12006: URL: https://github.com/apache/iceberg/pull/12006#discussion_r1938210083 ## core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java: ## @@ -354,7 +354,10 @@ private static RewriteResult writeDataFileEntry( DataFile newDataFi

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

jbonofre commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1938210401 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -63,29 +63,277 @@ NOTICE file: -Thi

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

jbonofre commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1938210401 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -63,29 +63,277 @@ NOTICE file: -Thi

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

jbonofre commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1937659243 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -63,29 +63,277 @@ NOTICE file: -Thi

Re: [PR] Spark 3.5: Always use '/' in RewriteTablePath [iceberg]

szehon-ho commented on PR #12066: URL: https://github.com/apache/iceberg/pull/12066#issuecomment-2628795243 I think we can change the issue as its a bit misleading, it was always using '/', but now its a constant. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Implement column projection [iceberg-python]

kevinjqliu commented on code in PR #1443: URL: https://github.com/apache/iceberg-python/pull/1443#discussion_r1938141310 ## tests/io/test_pyarrow.py: ## @@ -1122,6 +1127,129 @@ def test_projection_concat_files(schema_int: Schema, file_int: str) -> None: assert repr(result_

Re: [PR] fix: use upstream avro tag [iceberg-cpp]

wgtmac commented on PR #42: URL: https://github.com/apache/iceberg-cpp/pull/42#issuecomment-2628756881 The CI failure is unrelated which timed out to download Arrow tar ball. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] fix: use upstream avro tag [iceberg-cpp]

wgtmac opened a new pull request, #42: URL: https://github.com/apache/iceberg-cpp/pull/42 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [I] There is a bug with the new version of boto used by s3fs that prevents writes to non-AWS S3 buckets [iceberg-python]

maarek commented on issue #1546: URL: https://github.com/apache/iceberg-python/issues/1546#issuecomment-2628740423 It is discussed briefly here https://github.com/fsspec/s3fs/issues/931 though it might be best to track as a separate issue. It looks from the doc that it should be passed int

Re: [PR] Spec: Update partition stats for V3 [iceberg]

aokolnychyi commented on code in PR #12098: URL: https://github.com/apache/iceberg/pull/12098#discussion_r1938154643 ## format/spec.md: ## @@ -927,20 +927,21 @@ These rows must be sorted (in ascending manner with NULL FIRST) by `partition` f The schema of the partition stati

Re: [PR] Spec: Update partition stats for V3 [iceberg]

aokolnychyi commented on code in PR #12098: URL: https://github.com/apache/iceberg/pull/12098#discussion_r1938147854 ## format/spec.md: ## @@ -927,20 +927,21 @@ These rows must be sorted (in ascending manner with NULL FIRST) by `partition` f The schema of the partition stati

Re: [PR] Core: add variant builder implementation [iceberg]

aihuaxu commented on code in PR #11857: URL: https://github.com/apache/iceberg/pull/11857#discussion_r1938145300 ## core/src/main/java/org/apache/iceberg/variants/VariantBuilder.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Fix NOTICE and LICENSE in the azure-bundle jar [iceberg]

amogh-jahagirdar merged PR #12143: URL: https://github.com/apache/iceberg/pull/12143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Implement update for `remove-snapshots` action [iceberg-python]

kevinjqliu commented on code in PR #1561: URL: https://github.com/apache/iceberg-python/pull/1561#discussion_r1938122584 ## tests/table/test_init.py: ## @@ -793,6 +794,40 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table) -> None: ) +def test_update_remove_s

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2628614211 hey @vinjai are you interested to pick this back up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] WIP: Deletion vectors [iceberg-python]

kevinjqliu commented on PR #1516: URL: https://github.com/apache/iceberg-python/pull/1516#issuecomment-2628620227 do we want to include this as part of 0.9.0? the ability to read puffin files would be great! -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] feat: support S3 Table Buckets with S3TablesCatalog [iceberg-python]

kevinjqliu commented on PR #1429: URL: https://github.com/apache/iceberg-python/pull/1429#issuecomment-2628610962 @felixscherz could you rebase this against main? i see that [getmoto/moto/8470](https://github.com/getmoto/moto/pull/8470) is now merged, thanks for driving that! --

Re: [I] Change the description in Table metadata spec about the cardinality/mapping between snapshot and puffin [iceberg]

github-actions[bot] closed issue #10693: Change the description in Table metadata spec about the cardinality/mapping between snapshot and puffin URL: https://github.com/apache/iceberg/issues/10693 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] Can Iceberg branching be used for dataops [iceberg]

github-actions[bot] commented on issue #10738: URL: https://github.com/apache/iceberg/issues/10738#issuecomment-2628605075 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Core: Use FileIO for hadoop table metadata file operations [iceberg]

github-actions[bot] closed pull request #11690: Core: Use FileIO for hadoop table metadata file operations URL: https://github.com/apache/iceberg/pull/11690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Core: Use FileIO for hadoop table metadata file operations [iceberg]

github-actions[bot] commented on PR #11690: URL: https://github.com/apache/iceberg/pull/11690#issuecomment-2628605193 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] Snowflake Iceberg Partitioned data read issue [iceberg]

github-actions[bot] closed issue #9404: Snowflake Iceberg Partitioned data read issue URL: https://github.com/apache/iceberg/issues/9404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Core: Add list/map block sizes [iceberg]

github-actions[bot] commented on PR #10973: URL: https://github.com/apache/iceberg/pull/10973#issuecomment-2628605141 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] Can Iceberg branching be used for dataops [iceberg]

github-actions[bot] closed issue #10738: Can Iceberg branching be used for dataops URL: https://github.com/apache/iceberg/issues/10738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Iceberg Disaster Recovery [iceberg]

github-actions[bot] closed issue #10723: Iceberg Disaster Recovery URL: https://github.com/apache/iceberg/issues/10723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] Change the description in Table metadata spec about the cardinality/mapping between snapshot and puffin [iceberg]

github-actions[bot] commented on issue #10693: URL: https://github.com/apache/iceberg/issues/10693#issuecomment-2628605033 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Iceberg Disaster Recovery [iceberg]

github-actions[bot] commented on issue #10723: URL: https://github.com/apache/iceberg/issues/10723#issuecomment-2628605058 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Snowflake Iceberg Partitioned data read issue [iceberg]

github-actions[bot] commented on issue #9404: URL: https://github.com/apache/iceberg/issues/9404#issuecomment-2628604991 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

kevinjqliu commented on PR #1590: URL: https://github.com/apache/iceberg-python/pull/1590#issuecomment-2628604908 hey @gayatrikate04 looks like theres are changes that added `mkdocs = "^1.6.1"` as a dependency. I dont think its necessary for documentation related changes, can you remove tho

Re: [PR] Implement Kerberos authentication support for Hive Catalog [iceberg-python]

kevinjqliu commented on PR #766: URL: https://github.com/apache/iceberg-python/pull/766#issuecomment-2628602907 hi @yothinix thanks for the contribution. Would love like to address the comment above? Would be great to have this as part of the 0.9.0 release -- This is an automated message

Re: [PR] Spec: Fix current-version-id in View Spec example [iceberg]

bryanck commented on PR #12146: URL: https://github.com/apache/iceberg/pull/12146#issuecomment-2628602011 Thanks for catching this @ldsantos0911 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: implement InMemoryCatalog as a subclass of SqlCatalog [iceberg-python]

kevinjqliu commented on PR #1140: URL: https://github.com/apache/iceberg-python/pull/1140#issuecomment-2628601396 hey @hussein-awala would you like to make the above changes on docs? This PR is almost ready! -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Custom fileio docs [iceberg-python]

kevinjqliu commented on PR #1238: URL: https://github.com/apache/iceberg-python/pull/1238#issuecomment-2628598960 @sikehish this PR is in a great state and just need some minor adjustments. Would you like to continue to work on this PR? -- This is an automated message from the Apache Git

Re: [PR] docs/configuration.md: Documented table properties (#1231) [iceberg-python]

kevinjqliu commented on PR #1232: URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2628599894 @sikehish this PR looks good overall, with just a few minor changes. Would you like to work through these together and take it over the finish line? :) -- This is an automate

Re: [PR] feat: search current working directory for config file [iceberg-python]

kevinjqliu commented on PR #1464: URL: https://github.com/apache/iceberg-python/pull/1464#issuecomment-2628597206 hey @IndexSeek could you rebase this PR and run `make lint`? would be great to include this as part of the 0.9.0 release -- This is an automated message from the Apache Git S

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

kevinjqliu commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2628592600 Thanks for the contribution! @shiv-io -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

kevinjqliu merged PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Build: Bump griffe from 1.5.5 to 1.5.6 [iceberg-python]

kevinjqliu merged PR #1593: URL: https://github.com/apache/iceberg-python/pull/1593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Core: add variant builder implementation [iceberg]

aihuaxu commented on code in PR #11857: URL: https://github.com/apache/iceberg/pull/11857#discussion_r1938099890 ## core/src/main/java/org/apache/iceberg/variants/VariantConstants.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Build: Bump getdaft from 0.4.2 to 0.4.3 [iceberg-python]

kevinjqliu merged PR #1596: URL: https://github.com/apache/iceberg-python/pull/1596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Build: Bump mkdocs-material from 9.5.50 to 9.6.1 [iceberg-python]

kevinjqliu merged PR #1595: URL: https://github.com/apache/iceberg-python/pull/1595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on PR #9841: URL: https://github.com/apache/iceberg/pull/9841#issuecomment-2628566860 Thanks, @huaxingao! Thanks for reviewing, @parthchandra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Core: add variant builder implementation [iceberg]

aihuaxu commented on code in PR #11857: URL: https://github.com/apache/iceberg/pull/11857#discussion_r1938095567 ## core/src/main/java/org/apache/iceberg/variants/VariantConstants.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[PR] [infra] bump dependabot open PR limit [iceberg-python]

kevinjqliu opened a new pull request, #1597: URL: https://github.com/apache/iceberg-python/pull/1597 Bump dependabot open PR limit to 50, similar to [iceberg-rust/#921](https://github.com/apache/iceberg-rust/pull/921) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Flink: Add null check to writers to prevent resurrecting null values [iceberg]

stevenzwu commented on code in PR #12049: URL: https://github.com/apache/iceberg/pull/12049#discussion_r1938083314 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkRowData.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi merged PR #9841: URL: https://github.com/apache/iceberg/pull/9841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on PR #9841: URL: https://github.com/apache/iceberg/pull/9841#issuecomment-2628572897 @aokolnychyi Thank you so much for your reviewing and merge this PR! Also thanks @parthchandra and @RussellSpitzer for reviewing! -- This is an automated message from the Apache Git S

[PR] Spec: Fix current-version-id in View Spec example [iceberg]

ldsantos0911 opened a new pull request, #12146: URL: https://github.com/apache/iceberg/pull/12146 The example given [in the View Spec](https://iceberg.apache.org/view-spec/#appendix-a-an-example) demonstrates creation of a new version of a View. The new metadata file should list the `curre

[PR] Build: Bump getdaft from 0.4.2 to 0.4.3 [iceberg-python]

dependabot[bot] opened a new pull request, #1596: URL: https://github.com/apache/iceberg-python/pull/1596 Bumps [getdaft](https://github.com/Eventual-Inc/Daft) from 0.4.2 to 0.4.3. Release notes Sourced from https://github.com/Eventual-Inc/Daft/releases";>getdaft's releases.

Re: [PR] Flink: Add null check to writers to prevent resurrecting null values [iceberg]

stevenzwu commented on code in PR #12049: URL: https://github.com/apache/iceberg/pull/12049#discussion_r1938079052 ## data/src/test/java/org/apache/iceberg/data/DataTest.java: ## @@ -486,4 +490,22 @@ public void testPrimitiveTypeDefaultValues(Type.PrimitiveType type, Object def

Re: [PR] Spec: Update partition stats for V3 [iceberg]

aokolnychyi commented on code in PR #12098: URL: https://github.com/apache/iceberg/pull/12098#discussion_r1938070328 ## format/spec.md: ## @@ -927,20 +927,21 @@ These rows must be sorted (in ascending manner with NULL FIRST) by `partition` f The schema of the partition stati

Re: [PR] Spec: Update partition stats for V3 [iceberg]

aokolnychyi commented on code in PR #12098: URL: https://github.com/apache/iceberg/pull/12098#discussion_r1938069621 ## format/spec.md: ## @@ -927,20 +927,21 @@ These rows must be sorted (in ascending manner with NULL FIRST) by `partition` f The schema of the partition stati

[PR] Build: Bump mkdocs-material from 9.5.50 to 9.6.1 [iceberg-python]

dependabot[bot] opened a new pull request, #1595: URL: https://github.com/apache/iceberg-python/pull/1595 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.50 to 9.6.1. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>m

Re: [PR] Variants: Implement toString [iceberg]

aihuaxu commented on code in PR #12138: URL: https://github.com/apache/iceberg/pull/12138#discussion_r1938061867 ## core/src/main/java/org/apache/iceberg/variants/VariantMetadata.java: ## @@ -34,4 +34,20 @@ public interface VariantMetadata extends Variants.Serialized { /**

Re: [PR] Variants: Implement toString [iceberg]

aihuaxu commented on code in PR #12138: URL: https://github.com/apache/iceberg/pull/12138#discussion_r1938060630 ## core/src/main/java/org/apache/iceberg/variants/VariantMetadata.java: ## @@ -34,4 +34,20 @@ public interface VariantMetadata extends Variants.Serialized { /**

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

rdblue commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1938046926 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -63,29 +63,277 @@ NOTICE file: -This

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

amogh-jahagirdar merged PR #12142: URL: https://github.com/apache/iceberg/pull/12142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Core: add variant builder implementation [iceberg]

aihuaxu commented on code in PR #11857: URL: https://github.com/apache/iceberg/pull/11857#discussion_r1938030119 ## core/src/main/java/org/apache/iceberg/variants/VariantSizeLimitException.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

jbonofre commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1938007612 ## flink/v1.20/flink-runtime/LICENSE: ## @@ -464,47 +425,92 @@ License text: -

Re: [PR] Core: add variant builder implementation [iceberg]

aihuaxu commented on code in PR #11857: URL: https://github.com/apache/iceberg/pull/11857#discussion_r1938013992 ## core/src/main/java/org/apache/iceberg/variants/VariantArray.java: ## @@ -20,6 +20,10 @@ /** An variant array value. */ public interface VariantArray extends Va

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

jbonofre commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1937659243 ## flink/v1.20/flink-runtime/NOTICE: ## @@ -63,29 +63,277 @@ NOTICE file: -Thi

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

jbonofre commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1938012909 ## flink/v1.20/flink-runtime/LICENSE: ## @@ -464,47 +425,92 @@ License text: -

Re: [I] Data Loss in Flink Job with Iceberg Sink After Restart: How to Ensure Consistent Writes? [iceberg]

sanchay0 commented on issue #11894: URL: https://github.com/apache/iceberg/issues/11894#issuecomment-2628445022 Leaving an update here for others who might run into this in the future as this was rather tricky to debug. We are currently using Iceberg 0.11.x on Flink 1.11, there is a bug tha

Re: [I] Data Loss in Flink Job with Iceberg Sink After Restart: How to Ensure Consistent Writes? [iceberg]

sanchay0 closed issue #11894: Data Loss in Flink Job with Iceberg Sink After Restart: How to Ensure Consistent Writes? URL: https://github.com/apache/iceberg/issues/11894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Fix NOTICE and LICENSE in the flink-runtime jar [iceberg]

jbonofre commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1938007816 ## flink/v1.20/flink-runtime/LICENSE: ## @@ -464,47 +425,92 @@ License text: -

Re: [PR] Fix NOTICE and LICENSE in the gcp-bundle jar [iceberg]

jbonofre commented on code in PR #12144: URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938000804 ## gcp-bundle/NOTICE: ## @@ -29,72 +29,225 @@ from the source code management (SCM) system project uses.

Re: [PR] Fix NOTICE and LICENSE in the gcp-bundle jar [iceberg]

jbonofre commented on code in PR #12144: URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938006639 ## gcp-bundle/LICENSE: ## @@ -203,11 +203,11 @@ -This binary artifact contains

Re: [PR] Fix NOTICE and LICENSE in the gcp-bundle jar [iceberg]

jbonofre commented on code in PR #12144: URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938006481 ## gcp-bundle/NOTICE: ## @@ -29,72 +29,225 @@ from the source code management (SCM) system project uses.

Re: [PR] Fix NOTICE and LICENSE in the gcp-bundle jar [iceberg]

jbonofre commented on code in PR #12144: URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938005618 ## gcp-bundle/LICENSE: ## @@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 - http://www.apache.org/licens Review Comment: Which one ? N

Re: [PR] Fix NOTICE and LICENSE in the gcp-bundle jar [iceberg]

jbonofre commented on code in PR #12144: URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938004031 ## gcp-bundle/LICENSE: ## @@ -203,11 +203,11 @@ -This binary artifact contains

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on PR #9841: URL: https://github.com/apache/iceberg/pull/9841#issuecomment-2628434488 I am OK merging the change if we revert the default reader type and Comet experts approve the logic. I won't block this work because of the dependency on shaded APIs. We will n

Re: [PR] Fix NOTICE and LICENSE in the gcp-bundle jar [iceberg]

jbonofre commented on code in PR #12144: URL: https://github.com/apache/iceberg/pull/12144#discussion_r193763 ## gcp-bundle/LICENSE: ## @@ -220,100 +220,90 @@ License: Apache 2.0 - http://www.apache.org/licenses/LICENSE-2.0 --

Re: [PR] Fix NOTICE and LICENSE in the azure-bundle jar [iceberg]

jbonofre commented on code in PR #12143: URL: https://github.com/apache/iceberg/pull/12143#discussion_r1937995047 ## azure-bundle/NOTICE: ## @@ -7,9 +7,9 @@ The Apache Software Foundation (http://www.apache.org/). -

Re: [PR] Fix NOTICE and LICENSE in the azure-bundle jar [iceberg]

jbonofre commented on code in PR #12143: URL: https://github.com/apache/iceberg/pull/12143#discussion_r1937994646 ## azure-bundle/NOTICE: ## @@ -7,9 +7,9 @@ The Apache Software Foundation (http://www.apache.org/). -

Re: [PR] Fix NOTICE and LICENSE in the azure-bundle jar [iceberg]

jbonofre commented on code in PR #12143: URL: https://github.com/apache/iceberg/pull/12143#discussion_r1937993928 ## azure-bundle/NOTICE: ## @@ -28,3 +28,291 @@ To find the details that apply to this artifact see the accompanying LICENSE fil A list of contributors may be found

Re: [PR] Fix NOTICE and LICENSE in the azure-bundle jar [iceberg]

jbonofre commented on code in PR #12143: URL: https://github.com/apache/iceberg/pull/12143#discussion_r1937990998 ## azure-bundle/NOTICE: ## @@ -7,9 +7,9 @@ The Apache Software Foundation (http://www.apache.org/). -

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

jbonofre commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937990328 ## aws-bundle/LICENSE: ## @@ -297,220 +297,215 @@ License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ -

Re: [PR] Flink: Add null check to writers to prevent resurrecting null values [iceberg]

mxm commented on code in PR #12049: URL: https://github.com/apache/iceberg/pull/12049#discussion_r1937967140 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetWriters.java: ## @@ -498,6 +498,12 @@ private static class RowDataWriter extends ParquetValu

Re: [PR] Flink: Add null check to writers to prevent resurrecting null values [iceberg]

mxm commented on code in PR #12049: URL: https://github.com/apache/iceberg/pull/12049#discussion_r1937962188 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkRowData.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

jbonofre commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937950217 ## aws-bundle/LICENSE: ## @@ -297,220 +297,215 @@ License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ -

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

amogh-jahagirdar commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937947602 ## aws-bundle/LICENSE: ## @@ -297,220 +297,215 @@ License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ -

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

amogh-jahagirdar commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937947602 ## aws-bundle/LICENSE: ## @@ -297,220 +297,215 @@ License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ -

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

jbonofre commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937946983 ## aws-bundle/LICENSE: ## @@ -297,220 +297,215 @@ License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ -

Re: [PR] 0.8.1.protected_type [iceberg-python]

yigal-rozenberg commented on PR #1594: URL: https://github.com/apache/iceberg-python/pull/1594#issuecomment-2628339405 The purpose of the proposed change, is to allow iceberg to identify encrypted data items stored in a column as such, and allow the application to decipher. the current impl

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

amogh-jahagirdar commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937943950 ## aws-bundle/LICENSE: ## @@ -297,220 +297,215 @@ License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ -

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

jbonofre commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937926271 ## aws-bundle/LICENSE: ## @@ -203,7 +203,7 @@ -This binary artifact contains c

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

wypoon commented on code in PR #12117: URL: https://github.com/apache/iceberg/pull/12117#discussion_r1937939871 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/functions/SparkFunctions.java: ## @@ -29,24 +29,41 @@ public class SparkFunctions { private SparkFuncti

Re: [PR] Fix NOTICE and LICENSE in the azure-bundle jar [iceberg]

jbonofre commented on code in PR #12143: URL: https://github.com/apache/iceberg/pull/12143#discussion_r1937935904 ## azure-bundle/LICENSE: ## @@ -203,107 +203,95 @@ -This binary artifact conta

Re: [PR] Flink: Add null check to writers to prevent resurrecting null values [iceberg]

mxm commented on code in PR #12049: URL: https://github.com/apache/iceberg/pull/12049#discussion_r1937936596 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetWriters.java: ## @@ -498,6 +498,12 @@ private static class RowDataWriter extends ParquetValu

Re: [PR] Fix NOTICE and LICENSE in the azure-bundle jar [iceberg]

jbonofre commented on code in PR #12143: URL: https://github.com/apache/iceberg/pull/12143#discussion_r1937935256 ## azure-bundle/LICENSE: ## @@ -483,25 +471,19 @@ License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

wypoon commented on code in PR #12117: URL: https://github.com/apache/iceberg/pull/12117#discussion_r1937934388 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java: ## @@ -70,7 +70,8 @@ public class SparkV2Filters { public static final Set SUPPOR

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

jbonofre commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937934257 ## aws-bundle/NOTICE: ## @@ -9,57 +9,81 @@ The Apache Software Foundation (http://www.apache.org/). NOTICE for Group: commons-codec Name: commons-codec Version:

Re: [PR] Flink: Add null check to writers to prevent resurrecting null values [iceberg]

mxm commented on code in PR #12049: URL: https://github.com/apache/iceberg/pull/12049#discussion_r1937932293 ## data/src/test/java/org/apache/iceberg/data/DataTest.java: ## @@ -486,4 +490,20 @@ public void testPrimitiveTypeDefaultValues(Type.PrimitiveType type, Object defau

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

jbonofre commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937925328 ## aws-bundle/NOTICE: ## @@ -9,57 +9,81 @@ The Apache Software Foundation (http://www.apache.org/). NOTICE for Group: commons-codec Name: commons-codec Version:

Re: [PR] Flink: Add null check to writers to prevent resurrecting null values [iceberg]

mxm commented on code in PR #12049: URL: https://github.com/apache/iceberg/pull/12049#discussion_r1937932845 ## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSink.java: ## @@ -414,6 +422,49 @@ void testOperatorsUidNameWitUidSuffix() throws Exception {

Re: [PR] Fix NOTICE and LICENSE in the aws-bundle jar [iceberg]

jbonofre commented on code in PR #12142: URL: https://github.com/apache/iceberg/pull/12142#discussion_r1937925328 ## aws-bundle/NOTICE: ## @@ -9,57 +9,81 @@ The Apache Software Foundation (http://www.apache.org/). NOTICE for Group: commons-codec Name: commons-codec Version:

  1   2   >