hantangwangd commented on code in PR #11960:
URL: https://github.com/apache/iceberg/pull/11960#discussion_r1914391256
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -659,9 +659,9 @@ public List listNamespaces(SessionContext
context, Namespace names
lliangyu-lin commented on issue #11922:
URL: https://github.com/apache/iceberg/issues/11922#issuecomment-2589245565
I'm able to reproduce the issue. I'm happy to take a try on fixing the issue
and add additional test coverages.
--
This is an automated message from the Apache Git Service.
nastra closed pull request #11962: Core: Fix tests around empty namespaces
URL: https://github.com/apache/iceberg/pull/11962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nastra commented on code in PR #11960:
URL: https://github.com/apache/iceberg/pull/11960#discussion_r1914380512
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -659,9 +659,9 @@ public List listNamespaces(SessionContext
context, Namespace namespac
nastra commented on PR #11962:
URL: https://github.com/apache/iceberg/pull/11962#issuecomment-2589236132
Actually I think https://github.com/apache/iceberg/pull/11960 is the better
fix for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please
nastra commented on code in PR #11960:
URL: https://github.com/apache/iceberg/pull/11960#discussion_r1914380512
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -659,9 +659,9 @@ public List listNamespaces(SessionContext
context, Namespace namespac
nastra commented on PR #11758:
URL: https://github.com/apache/iceberg/pull/11758#issuecomment-2589228337
I think it could be quite helpful but a few small comments or a small readme
would be good to have
--
This is an automated message from the Apache Git Service.
To respond to the messag
hantangwangd commented on PR #11960:
URL: https://github.com/apache/iceberg/pull/11960#issuecomment-2589227245
Hi @nastra , can you please take a look at this fix when available? Thanks a
lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
SGITLOGIN opened a new issue, #11961:
URL: https://github.com/apache/iceberg/issues/11961
### Query engine
Spark 3.4.2
### Question
When Iceberg executes drop table without adding PURGE, the metadata and data
files are not deleted.
I create the same table again. How
SGITLOGIN closed issue #11952: insert branch failed：spark_catalog requires a
single-part namespace, but got `iceberg_db`.`sample_oss_time_travel`.
URL: https://github.com/apache/iceberg/issues/11952
--
This is an automated message from the Apache Git Service.
To respond to the message, please
SGITLOGIN commented on issue #11952:
URL: https://github.com/apache/iceberg/issues/11952#issuecomment-2589132191
> When you use the branch from SparkSQL, you need to set `branch_` before
your branch name. Specifically, for your INSERT query, you need to specify the
branch name like:
>
tomtongue commented on issue #11952:
URL: https://github.com/apache/iceberg/issues/11952#issuecomment-2588929264
When you use the branch from SparkSQL, you need to set `branch_` as its
branch name. Specifically, for your INSERT query, you need to specify the
branch name like:
```
dramaticlly commented on PR #11931:
URL: https://github.com/apache/iceberg/pull/11931#issuecomment-257095
> @dramaticlly would you mind updating doc as well?
Yes @manuzhang , I plan to have a followup PR with spark procedure
documentation once this is merged.
--
This is an aut
manuzhang commented on PR #11931:
URL: https://github.com/apache/iceberg/pull/11931#issuecomment-252806
@dramaticlly would you mind updating doc as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
majian1998 opened a new pull request, #11959:
URL: https://github.com/apache/iceberg/pull/11959
Current Limitations: The rewrite manifest currently has limited parameters.
To set or change the manifest size, you must go through the table config, which
restricts flexibility. We wish for rewr
lidavidm commented on PR #27:
URL: https://github.com/apache/iceberg-cpp/pull/27#issuecomment-2588799249
How it looks:
--
This is an automated message from the Apache Git Service.
To respo
liurenjie1024 merged PR #765:
URL: https://github.com/apache/iceberg-rust/pull/765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
SGITLOGIN commented on issue #11952:
URL: https://github.com/apache/iceberg/issues/11952#issuecomment-2588579221
yes，I tried SET spark. wap. branch=audit; There is no problem, It is
possible that there is an issue with Spark parsing
catalog.namespace.table.branch-audit
--
This is an auto
ebyhr commented on code in PR #11956:
URL: https://github.com/apache/iceberg/pull/11956#discussion_r1913957973
##
site/docs/vendors.md:
##
@@ -89,3 +89,8 @@ Starburst is a commercial offering for the [Trino query
engine](https://trino.io
### [Upsolver](https://upsolver.com)
github-actions[bot] commented on issue #936:
URL: https://github.com/apache/iceberg-python/issues/936#issuecomment-2588486293
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity oc
github-actions[bot] commented on issue #939:
URL: https://github.com/apache/iceberg-python/issues/939#issuecomment-2588486282
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity oc
github-actions[bot] commented on PR #11365:
URL: https://github.com/apache/iceberg/pull/11365#issuecomment-2588484684
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on issue #9956:
URL: https://github.com/apache/iceberg/issues/9956#issuecomment-2588484637
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #10703:
URL: https://github.com/apache/iceberg/issues/10703#issuecomment-2588484662
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] commented on PR #11755:
URL: https://github.com/apache/iceberg/pull/11755#issuecomment-2588484724
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on issue #10713:
URL: https://github.com/apache/iceberg/issues/10713#issuecomment-2588484669
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
tbaeg commented on PR #11895:
URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2588475018
I think incremental improvement for the existing implementation (even if
slated for rewrite) should be included.
Of note, we cherry-picked commits from
https://github.com/apache/ic
ebyhr commented on PR #11758:
URL: https://github.com/apache/iceberg/pull/11758#issuecomment-2588429690
Note that this query runner allows inspecting at breakpoints. This class is
helpful to debug codes without writing tests when community members reported
issues.
--
This is an automate
dependabot[bot] opened a new pull request, #1513:
URL: https://github.com/apache/iceberg-python/pull/1513
Bumps [mkdocs-autorefs](https://github.com/mkdocstrings/autorefs) from 1.2.0
to 1.3.0.
Release notes
Sourced from https://github.com/mkdocstrings/autorefs/releases";>mkdocs-aut
zeroshade merged PR #247:
URL: https://github.com/apache/iceberg-go/pull/247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
zeroshade merged PR #249:
URL: https://github.com/apache/iceberg-go/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
zeroshade merged PR #248:
URL: https://github.com/apache/iceberg-go/pull/248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
zeroshade merged PR #252:
URL: https://github.com/apache/iceberg-go/pull/252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
zeroshade commented on code in PR #252:
URL: https://github.com/apache/iceberg-go/pull/252#discussion_r1913882185
##
table/scanner.go:
##
@@ -259,129 +286,119 @@ func matchDeletesToData(entry iceberg.ManifestEntry,
positionalDeletes []iceberg
return out, nil
}
-func
dependabot[bot] commented on PR #250:
URL: https://github.com/apache/iceberg-go/pull/250#issuecomment-2588346627
Looks like github.com/aws/aws-sdk-go-v2/credentials is up-to-date now, so
this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to t
dependabot[bot] closed pull request #250: build(deps): bump
github.com/aws/aws-sdk-go-v2/credentials from 1.17.48 to 1.17.51
URL: https://github.com/apache/iceberg-go/pull/250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
zeroshade merged PR #251:
URL: https://github.com/apache/iceberg-go/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
zeroshade commented on code in PR #252:
URL: https://github.com/apache/iceberg-go/pull/252#discussion_r1913854651
##
table/scanner.go:
##
@@ -259,129 +286,119 @@ func matchDeletesToData(entry iceberg.ManifestEntry,
positionalDeletes []iceberg
return out, nil
}
-func
iskakaushik commented on code in PR #252:
URL: https://github.com/apache/iceberg-go/pull/252#discussion_r1913861589
##
table/scanner.go:
##
@@ -259,129 +286,119 @@ func matchDeletesToData(entry iceberg.ManifestEntry,
positionalDeletes []iceberg
return out, nil
}
-fun
zeroshade merged PR #253:
URL: https://github.com/apache/iceberg-go/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
jiakai-li commented on issue #1493:
URL:
https://github.com/apache/iceberg-python/issues/1493#issuecomment-2588295176
Sure @kevinjqliu , I think this is a very interesting API to support. I
checked the java side as well to get some idea about how they tackle the issue.
Seems it's not suppo
zeroshade commented on PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#issuecomment-2588263730
@Fokko any further comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
singhpk234 commented on code in PR #11825:
URL: https://github.com/apache/iceberg/pull/11825#discussion_r1913830176
##
core/src/main/java/org/apache/iceberg/actions/SizeBasedDataRewriter.java:
##
@@ -84,13 +86,30 @@ private boolean shouldRewrite(List group) {
return enoughI
zeroshade commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1913825350
##
catalog/rest.go:
##
@@ -663,18 +631,40 @@ func splitIdentForPath(ident table.Identifier) (string,
string, error) {
return strings.Join(NamespaceFromIdent
kevinjqliu commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1913823798
##
catalog/catalog.go:
##
@@ -195,3 +200,36 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Ident
zeroshade commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1913822331
##
catalog/catalog.go:
##
@@ -195,3 +200,36 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Identi
kevinjqliu commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1908136750
##
catalog/catalog.go:
##
@@ -195,3 +200,36 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Ident
kevinjqliu commented on issue #1493:
URL:
https://github.com/apache/iceberg-python/issues/1493#issuecomment-2588188799
Thanks! Thats a good workaround.
I think a more generic use case is to be able to modify pending updates.
`details` here is a pending update, it has not yet been
jiakai-li commented on issue #1493:
URL:
https://github.com/apache/iceberg-python/issues/1493#issuecomment-2588111953
Hey @kevinjqliu , after some investigation, I realized this feature might
require a bigger change than I originally expected (which could be a good thing
though, so we can
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913751486
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1468,6 +1510,28 @@ public Builder setPreviousFileLocation(String
previousFileLocation) {
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913749663
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1230,6 +1260,18 @@ public Builder addSnapshot(Snapshot snapshot) {
snapshotsById.put
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913745405
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1230,6 +1260,18 @@ public Builder addSnapshot(Snapshot snapshot) {
snapshotsById.put
kevinjqliu commented on issue #1105:
URL:
https://github.com/apache/iceberg-python/issues/1105#issuecomment-2588075721
> To retain Nessie’s consistency and cross-branch/tag isolation guarantees,
we have deliberately chosen to only return the state of a table or view as a
single snapshot in
amogh-jahagirdar opened a new pull request, #11957:
URL: https://github.com/apache/iceberg/pull/11957
Leaving in draft now, but in an effort to save executor memory as part of
the broadcast of data to. file scoped deletes, we can remove the referenced
manifest location because that's only n
HonahX commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1913661284
##
core/src/test/resources/TableMetadataV2StatisticsFiles.json:
##
Review Comment:
It is referenced in the following test:
https://github.com/apache/iceberg/b
HonahX commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1913661284
##
core/src/test/resources/TableMetadataV2StatisticsFiles.json:
##
Review Comment:
It is still referenced in the following test:
https://github.com/apache/ice
HonahX commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1913661284
##
core/src/test/resources/TableMetadataV2StatisticsFiles.json:
##
Review Comment:
It is referenced in the following test:
https://github.com/apache/iceberg/b
kevinjqliu commented on code in PR #11845:
URL: https://github.com/apache/iceberg/pull/11845#discussion_r1913641156
##
site/docs/spark-quickstart.md:
##
@@ -267,44 +271,109 @@ To read a table, simply use the Iceberg table's name.
df = spark.table("demo.nyc.taxis").show()
kevinjqliu commented on PR #1511:
URL: https://github.com/apache/iceberg-python/pull/1511#issuecomment-2587762579
Thanks for the follow up @smaheshwar-pltr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
danielcweeks commented on PR #11954:
URL: https://github.com/apache/iceberg/pull/11954#issuecomment-2587762161
Minor comments and we should add a description, but LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
kevinjqliu merged PR #1511:
URL: https://github.com/apache/iceberg-python/pull/1511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
danielcweeks commented on code in PR #11954:
URL: https://github.com/apache/iceberg/pull/11954#discussion_r1913564118
##
aws/src/test/java/org/apache/iceberg/aws/AwsClientPropertiesTest.java:
##
@@ -140,4 +141,54 @@ public void
refreshCredentialsEndpointSetButRefreshDisabled()
danielcweeks commented on code in PR #11954:
URL: https://github.com/apache/iceberg/pull/11954#discussion_r1913468816
##
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##
@@ -215,4 +215,19 @@ public static Namespace decodeNamespace(String encodedNs) {
return Na
kevinjqliu commented on PR #11923:
URL: https://github.com/apache/iceberg/pull/11923#issuecomment-2587748916
looks like we'd have to rerun spotless check again
```
Run './gradlew
:iceberg-spark:iceberg-spark-runtime-3.3_2.12:spotlessApply' to fix these
violations.
```
--
This
kevinjqliu commented on issue #1512:
URL:
https://github.com/apache/iceberg-python/issues/1512#issuecomment-2587742210
I saw on Slack that this is using the Nessie catalog which has a known issue
with returning only 1 snapshot
https://github.com/apache/iceberg-python/issues/1105
--
This
kulte commented on issue #10395:
URL: https://github.com/apache/iceberg/issues/10395#issuecomment-2587723940
Is this really not planned now officially, or is this a `github-actions`
stale automation?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
creechy commented on code in PR #11954:
URL: https://github.com/apache/iceberg/pull/11954#discussion_r1913536698
##
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##
@@ -215,4 +215,19 @@ public static Namespace decodeNamespace(String encodedNs) {
return Namespa
shanielh closed pull request #11895: ParallelIterable: Queue Size w/ O(1)
URL: https://github.com/apache/iceberg/pull/11895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
shantanu-dahiya commented on issue #11836:
URL: https://github.com/apache/iceberg/issues/11836#issuecomment-2587651479
Envoy has [an issue](https://github.com/envoyproxy/envoy/issues/36305) and
an [open PR](https://github.com/envoyproxy/envoy/pull/37642) to add
configuration that allows upg
anish749 commented on issue #11952:
URL: https://github.com/apache/iceberg/issues/11952#issuecomment-2587642557
I am facing the same issue with AWS S3 tables, when writing to a branch.
so
```sql
MERGE INTO `catalog`.namespace.table.branch_audit
...
```
fails because S3 t
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913489410
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913488919
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1913485862
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1468,6 +1510,28 @@ public Builder setPreviousFileLocation(String
previousFileLocation) {
RussellSpitzer commented on PR #11260:
URL: https://github.com/apache/iceberg/pull/11260#issuecomment-2587600228
Approved and Merged, thanks @munendrasn for the PR and @Fokko and @nastra
for reviewing
--
This is an automated message from the Apache Git Service.
To respond to the message,
RussellSpitzer merged PR #11260:
URL: https://github.com/apache/iceberg/pull/11260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
danielcweeks commented on code in PR #11954:
URL: https://github.com/apache/iceberg/pull/11954#discussion_r1913468816
##
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##
@@ -215,4 +215,19 @@ public static Namespace decodeNamespace(String encodedNs) {
return Na
RussellSpitzer commented on PR #11895:
URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2587582525
> @RussellSpitzer, I see that #11768 is closed now, we use the PR in a
forked version for over a week now and we've observed no issues, any chance to
merge this? BTW, the fix for
Fokko merged PR #9890:
URL: https://github.com/apache/iceberg/pull/9890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on code in PR #1388:
URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1913339866
##
pyiceberg/expressions/visitors.py:
##
@@ -1731,3 +1731,214 @@ def _can_contain_nulls(self, field_id: int) -> bool:
def _can_contain_nans(self, field_id:
jbonofre commented on PR #11839:
URL: https://github.com/apache/iceberg/pull/11839#issuecomment-2587420383
@Fokko FYI, I'm working on the tests. I will update this PR soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
jbonofre commented on code in PR #11955:
URL: https://github.com/apache/iceberg/pull/11955#discussion_r1913370539
##
open-api/rest-catalog-open-api.py:
##
@@ -132,11 +132,15 @@ class ExpressionType(BaseModel):
class TrueExpression(BaseModel):
-type: ExpressionType
+
ajantha-bhat commented on PR #6948:
URL: https://github.com/apache/iceberg/pull/6948#issuecomment-2587386729
Some of the users are asking for multi-table transactions. I would love to
see progress on this. Happy to take up the pending work if the author is busy.
--
This is an automated m
gaborkaszab opened a new pull request, #11738:
URL: https://github.com/apache/iceberg/pull/11738
If a regular table had a metadata table name then CachingCatalog throws a
NoSuchTableException when loading that table.
--
This is an automated message from the Apache Git Service.
To respond
nastra closed pull request #11738: Core: Fix loading a table in CachingCatalog
with metadata table name
URL: https://github.com/apache/iceberg/pull/11738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
VladimirYushkevich commented on code in PR #11806:
URL: https://github.com/apache/iceberg/pull/11806#discussion_r1913331085
##
open-api/rest-catalog-open-api.py:
##
@@ -267,26 +267,57 @@ class ViewVersion(BaseModel):
default_namespace: Namespace = Field(..., alias='default-
Fokko commented on PR #1509:
URL: https://github.com/apache/iceberg-python/pull/1509#issuecomment-2587320031
Thanks for the quick follow up @smaheshwar-pltr, and thanks for the review
@kevinjqliu 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
Fokko merged PR #1509:
URL: https://github.com/apache/iceberg-python/pull/1509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
lidavidm commented on issue #26:
URL: https://github.com/apache/iceberg-cpp/issues/26#issuecomment-2587189407
How does it work for C++ though? I see a few random plugins (like cxxdox)
but I'm not confident in them vs Doxygen. (I also don't see from a bit of
searching how mkdocs handles the
DevChrisCross commented on code in PR #1498:
URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1913239486
##
pyiceberg/exceptions.py:
##
@@ -14,6 +14,9 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions
Fokko commented on code in PR #1498:
URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1913230599
##
pyiceberg/io/pyarrow.py:
##
@@ -1003,6 +1000,20 @@ def _(obj: pa.DictionaryType, visitor:
PyArrowSchemaVisitor[T]) -> T:
return visit_pyarrow(obj.value_ty
Fokko commented on code in PR #1498:
URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1913227992
##
pyiceberg/exceptions.py:
##
@@ -14,6 +14,9 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limi
Fokko commented on code in PR #1443:
URL: https://github.com/apache/iceberg-python/pull/1443#discussion_r1913225607
##
pyiceberg/io/pyarrow.py:
##
@@ -1216,6 +1216,25 @@ def _field_id(self, field: pa.Field) -> int:
return -1
+def _get_column_projection_values(
+
munendrasn commented on PR #11260:
URL: https://github.com/apache/iceberg/pull/11260#issuecomment-2587128406
Reached over to iceberg-slack to get the additional review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
gaborkaszab commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1913194574
##
core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java:
##
@@ -166,6 +168,42 @@ public void testTableName() throws Exception {
.isEqualT
Fokko commented on code in PR #1443:
URL: https://github.com/apache/iceberg-python/pull/1443#discussion_r1913166114
##
pyiceberg/io/pyarrow.py:
##
@@ -1216,6 +1216,25 @@ def _field_id(self, field: pa.Field) -> int:
return -1
+def _get_column_projection_values(
+
jbonofre commented on issue #10378:
URL: https://github.com/apache/iceberg/issues/10378#issuecomment-2587027874
I'm resuming work on this one to include 1.7.2 and 1.8.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Fokko commented on issue #26:
URL: https://github.com/apache/iceberg-cpp/issues/26#issuecomment-2587026463
@pitrou It is pretty similar, mkdocs feels a bit more modern to me.
Referencing the Python docs works pretty well:
https://py.iceberg.apache.org/reference/pyiceberg/io/
--
This is a
pitrou commented on issue #26:
URL: https://github.com/apache/iceberg-cpp/issues/26#issuecomment-2587019412
How does mkdocs compare to Sphinx? Sphinx really has excellent
cross-referencing capabilities (to API docs, to glossary, to other pages, to
index references, even to other Spinx docs)
Fokko commented on issue #26:
URL: https://github.com/apache/iceberg-cpp/issues/26#issuecomment-2587009767
I don't have any opinion on the C++ documentation generation, but we use
mkdocs at PyIceberg, and it works really well:
https://github.com/apache/iceberg-python/tree/main/mkdocs
--
Fokko merged PR #11846:
URL: https://github.com/apache/iceberg/pull/11846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
1 - 100 of 145 matches
Mail list logo
