Fokko merged PR #11861:
URL: https://github.com/apache/iceberg/pull/11861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
MichaelDeSteven commented on PR #11373:
URL: https://github.com/apache/iceberg/pull/11373#issuecomment-2559034232
> @MichaelDeSteven -
>
> ```
> Error: eckstyle] [ERROR]
/home/runner/work/iceberg/iceberg/parquet/src/test/java/org/apache/iceberg/parquet/TestPruneColumns.java:23:1:
jbonofre opened a new pull request, #11861:
URL: https://github.com/apache/iceberg/pull/11861
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
manuzhang closed pull request #11859: Infra: Add manuzhang to collaborators
URL: https://github.com/apache/iceberg/pull/11859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
manuzhang commented on code in PR #11859:
URL: https://github.com/apache/iceberg/pull/11859#discussion_r1895267911
##
.asf.yaml:
##
@@ -54,7 +54,7 @@ github:
- SreeramGarlapati
- samredai
Review Comment:
Oh, I might have misunderstood your words. Then let me cancel
bitsondatadev commented on code in PR #11859:
URL: https://github.com/apache/iceberg/pull/11859#discussion_r1895264491
##
.asf.yaml:
##
@@ -54,7 +54,7 @@ github:
- SreeramGarlapati
- samredai
Review Comment:
Actually, if all is the same to @samredai, would you mind
ZENOTME commented on PR #798:
URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2558853987
> > Is it possible to have action like combing fast append and append delete
file and data file? In fact, I try this in practice and it can be read by
spark. And for this action, I thi
smaheshwar-pltr commented on PR #1457:
URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2558846223
Done, @kevinjqliu. FYI, am away for a bit now so will pick this back up in
the new year! (Feel free to take over this if it's urgently required 😄)
--
This is an automated
ebyhr commented on PR #11779:
URL: https://github.com/apache/iceberg/pull/11779#issuecomment-2558801986
@amogh-jahagirdar There is no reason to disagree from my perspective. I was
simply trying to keep the existing behavior because I didn't know the
historical reason. Reverted most changes
liurenjie1024 commented on PR #11772:
URL: https://github.com/apache/iceberg/pull/11772#issuecomment-2558797458
Thanks everyone for reviewing and @kevinjqliu for approving this. I think
most comments have been resolved, and we have reached agreements that it would
be better to start iterati
liurenjie1024 merged PR #11772:
URL: https://github.com/apache/iceberg/pull/11772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ice
liurenjie1024 commented on PR #798:
URL: https://github.com/apache/iceberg-rust/pull/798#issuecomment-2558786292
> Is it possible to have action like combing fast append and append delete
file and data file? In fact, I try this in practice and it can be read by
spark. And for this action, I
zhjwpku commented on PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2558785835
> @zhjwpku Yes, I am already working on simplifying it by integrating
`FetchContent_declare` with `FIND_PACKAGE_ARGS`. They are still in my local
copy and I'm polishing them. It is pretty e
wgtmac commented on PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2558783070
@zhjwpku Yes, I am already working on simplifying it by integrating
`FetchContent_declare` with `FIND_PACKAGE_ARGS`. They are still in my local
copy and I'm polishing them. I'm too busy thes
liurenjie1024 merged PR #832:
URL: https://github.com/apache/iceberg-rust/pull/832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
zhjwpku commented on PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#issuecomment-2558769771
This seems real complicated, ISTM that `find_package and FetchContent`
mentioned by @lidavidm should be an easy way, I tried that in #13, maybe you
can check that.
--
This is an automate
manuzhang commented on PR #817:
URL: https://github.com/apache/iceberg-rust/pull/817#issuecomment-2558732542
@Xuanwo @sungwy Please be aware that [the merged
commit](https://github.com/apache/iceberg-rust/commit/74a85e7530e40c56a2a3075be63fd943e632501d)
didn't carry over a meaningful messag
stevenzwu commented on code in PR #11702:
URL: https://github.com/apache/iceberg/pull/11702#discussion_r1895139276
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##
@@ -666,8 +667,16 @@ private DataStream distributeDataStream(
retur
manuzhang commented on PR #11859:
URL: https://github.com/apache/iceberg/pull/11859#issuecomment-2558729136
Most CIs shouldn't be triggered by this change. I submitted #11860 to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
manuzhang opened a new pull request, #11860:
URL: https://github.com/apache/iceberg/pull/11860
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
manuzhang opened a new pull request, #11859:
URL: https://github.com/apache/iceberg/pull/11859
After discussing offline with @bits, he graciously agreed to be removed from
the collaborator list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jiakai-li commented on PR #1453:
URL: https://github.com/apache/iceberg-python/pull/1453#issuecomment-2558702444
> BTW there are 2 FileIO implementations, one for pyarrow, another for
fsspec.
>
> We might want to do the same for fsspec
>
>
https://github.com/apache/iceberg-pyt
stevenzwu commented on PR #11826:
URL: https://github.com/apache/iceberg/pull/11826#issuecomment-2558689384
@abharath9 is this a clean back port?
It is marked as a draft now. is it ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the mess
Fokko commented on PR #11782:
URL: https://github.com/apache/iceberg/pull/11782#issuecomment-2558680432
Thanks for working on this @tom-s-powell. It turned out I was running into
the same issue as you, see https://github.com/apache/iceberg/pull/11858.
While testing your solution, I no
Fokko opened a new pull request, #11858:
URL: https://github.com/apache/iceberg/pull/11858
This reverts commit 7e2920af400e5d559f8f1742b1043787b0477d74 from #10771.
Reported in https://github.com/apache/iceberg/issues/11783,
https://github.com/apache/iceberg/issues/11633 and
https://
github-actions[bot] commented on PR #11313:
URL: https://github.com/apache/iceberg/pull/11313#issuecomment-2558674264
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on PR #11586:
URL: https://github.com/apache/iceberg/pull/11586#issuecomment-2558674282
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on PR #10943:
URL: https://github.com/apache/iceberg/pull/10943#issuecomment-2558674238
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed pull request #10943: Spark partial limit push down
URL: https://github.com/apache/iceberg/pull/10943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on issue #10535:
URL: https://github.com/apache/iceberg/issues/10535#issuecomment-2558674207
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] closed pull request #9887: [DRAFT]: Adjust site links to
absolute from site_url
URL: https://github.com/apache/iceberg/pull/9887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
github-actions[bot] commented on issue #10493:
URL: https://github.com/apache/iceberg/issues/10493#issuecomment-2558674188
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] commented on PR #9887:
URL: https://github.com/apache/iceberg/pull/9887#issuecomment-2558674143
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
Fokko commented on issue #11582:
URL: https://github.com/apache/iceberg/issues/11582#issuecomment-2558669151
I'm going to close this one as well, to ensure that we have all the
discussion in one central place: https://github.com/apache/iceberg/issues/11633
--
This is an automated message
Fokko closed issue #11582: Iceberg 1.7.0 java.lang.IllegalStateException:
Connection pool shut down
URL: https://github.com/apache/iceberg/issues/11582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Fokko commented on issue #11633:
URL: https://github.com/apache/iceberg/issues/11633#issuecomment-2558668852
I did a git bisect, and narrowed down the issue to this one:
```
➜ iceberg git:(7e2920af4) git bisect bad
7e2920af400e5d559f8f1742b1043787b0477d74 is the first bad
jiakai-li commented on code in PR #1453:
URL: https://github.com/apache/iceberg-python/pull/1453#discussion_r1895102443
##
tests/io/test_pyarrow.py:
##
Review Comment:
I did some more search but I think [this
comment](https://github.com/minio/minio/discussions/20683#discus
Fokko commented on issue #11582:
URL: https://github.com/apache/iceberg/issues/11582#issuecomment-2558640544
@hussein-awala Thanks for taking a stab at this. When cherry-picking your
work, and testing against https://github.com/apache/iceberg-python/pull/1323
I'm still seeing the error 🤔
Fokko commented on issue #11089:
URL: https://github.com/apache/iceberg/issues/11089#issuecomment-2558634446
Looks like this is the same issue as
https://github.com/apache/iceberg/issues/11633 Closing this one.
--
This is an automated message from the Apache Git Service.
To respond to the
Fokko closed issue #11089: Connection pool shut down for iceberg 1.5.0
URL: https://github.com/apache/iceberg/issues/11089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Fokko commented on issue #11633:
URL: https://github.com/apache/iceberg/issues/11633#issuecomment-2558634206
I'm seeing the same here https://github.com/apache/iceberg-python/pull/1323
Let me dig into the details
--
This is an automated message from the Apache Git Service.
To respond to t
lordk911 commented on issue #11820:
URL: https://github.com/apache/iceberg/issues/11820#issuecomment-2558633257
Is this a Bug, or is it by design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko merged PR #11848:
URL: https://github.com/apache/iceberg/pull/11848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko merged PR #11852:
URL: https://github.com/apache/iceberg/pull/11852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
kevinjqliu commented on code in PR #11845:
URL: https://github.com/apache/iceberg/pull/11845#discussion_r1895040536
##
docs/docs/spark-getting-started.md:
##
Review Comment:
note, there are two "getting started" docs
this one and `site/docs/spark-quickstart.md`
#
IndexSeek commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895072573
##
pyiceberg/utils/config.py:
##
Review Comment:
I tried adding a test here, but I wonder if there are opportunities to clean
it up.
--
This is an a
IndexSeek commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895072366
##
mkdocs/docs/configuration.md:
##
Review Comment:
Nice finds! That grep tool is pretty neat. I just made some corrections to
these in
https://github.c
IndexSeek commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895072054
##
pyiceberg/utils/config.py:
##
@@ -84,12 +84,13 @@ def _load_yaml(directory: Optional[str]) ->
Optional[RecursiveDict]:
return file_con
Fokko merged PR #11849:
URL: https://github.com/apache/iceberg/pull/11849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
kevinjqliu commented on code in PR #1464:
URL: https://github.com/apache/iceberg-python/pull/1464#discussion_r1895062991
##
pyiceberg/utils/config.py:
##
@@ -84,12 +84,13 @@ def _load_yaml(directory: Optional[str]) ->
Optional[RecursiveDict]:
return file_co
Fokko merged PR #11847:
URL: https://github.com/apache/iceberg/pull/11847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
IndexSeek opened a new pull request, #1464:
URL: https://github.com/apache/iceberg-python/pull/1464
Resolves #1333
Adds the current working directory to the search path for the
`.pyiceberg.yaml` file.
As it is now, the file is searched in the following order:
1. the `PYICE
Fokko merged PR #11850:
URL: https://github.com/apache/iceberg/pull/11850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko merged PR #11851:
URL: https://github.com/apache/iceberg/pull/11851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko merged PR #11853:
URL: https://github.com/apache/iceberg/pull/11853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko merged PR #11854:
URL: https://github.com/apache/iceberg/pull/11854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
kevinjqliu commented on PR #1457:
URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2558596455
BTW #1462 is merged, could you rebase this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kevinjqliu merged PR #1462:
URL: https://github.com/apache/iceberg-python/pull/1462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
Fokko merged PR #11855:
URL: https://github.com/apache/iceberg/pull/11855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko merged PR #11856:
URL: https://github.com/apache/iceberg/pull/11856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on code in PR #1443:
URL: https://github.com/apache/iceberg-python/pull/1443#discussion_r1895050481
##
pyiceberg/io/pyarrow.py:
##
@@ -1237,16 +1238,29 @@ def _task_to_record_batches(
# When V3 support is introduced, we will update
`downcast_ns_timestam
Fokko commented on code in PR #1454:
URL: https://github.com/apache/iceberg-python/pull/1454#discussion_r1895049968
##
poetry.lock:
##
@@ -1,4 +1,4 @@
-# This file is automatically @generated by Poetry 1.8.5 and should not be
changed by hand.
+# This file is automatically @gene
Fokko commented on PR #1454:
URL: https://github.com/apache/iceberg-python/pull/1454#issuecomment-2558590155
Tnx for the quick review @kevinjqliu 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Fokko merged PR #1454:
URL: https://github.com/apache/iceberg-python/pull/1454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
aihuaxu opened a new pull request, #11857:
URL: https://github.com/apache/iceberg/pull/11857
This PR adds the implementation to build a variant for primitive, object and
array.
The usage:
- Build from Json
`VariantBuilder.parseJson(json_string);`
- build a primitive
chengchengpei opened a new issue, #1463:
URL: https://github.com/apache/iceberg-python/issues/1463
### Question
I am looking into https://py.iceberg.apache.org/configuration/#s3.
i tried `s3.access-key-id` and `s3.secret-access-key`. they works well. but
now, i am thinking how to g
ykcai-daniel commented on issue #11479:
URL: https://github.com/apache/iceberg/issues/11479#issuecomment-2558530999
I would like to work on this issue. I will give an update in around a week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dependabot[bot] opened a new pull request, #832:
URL: https://github.com/apache/iceberg-rust/pull/832
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.28.3 to
1.28.4.
Release notes
Sourced from https://github.com/crate-ci/typos/releases";>crate-ci/typos's
releases.
dependabot[bot] opened a new pull request, #236:
URL: https://github.com/apache/iceberg-go/pull/236
Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2)
from 1.32.6 to 1.32.7.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/5a964704cb2640ed57a74b9b37a5
dependabot[bot] opened a new pull request, #232:
URL: https://github.com/apache/iceberg-go/pull/232
Bumps
[github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2)
from 1.28.6 to 1.28.7.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/5a964704cb2640ed57a7
dependabot[bot] opened a new pull request, #235:
URL: https://github.com/apache/iceberg-go/pull/235
Bumps
[github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2)
from 1.17.47 to 1.17.48.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/5a964704cb264
dependabot[bot] opened a new pull request, #234:
URL: https://github.com/apache/iceberg-go/pull/234
Bumps
[google.golang.org/api](https://github.com/googleapis/google-api-go-client)
from 0.211.0 to 0.214.0.
Release notes
Sourced from https://github.com/googleapis/google-api-go-cli
dependabot[bot] opened a new pull request, #233:
URL: https://github.com/apache/iceberg-go/pull/233
Bumps
[github.com/aws/aws-sdk-go-v2/service/glue](https://github.com/aws/aws-sdk-go-v2)
from 1.104.0 to 1.104.1.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/5a964704cb26
73 matches
Mail list logo
