Re: [PR] support uri not end with character '/' in rest catalog [iceberg]

2024-11-02 Thread via GitHub
beyond-up commented on PR #11392: URL: https://github.com/apache/iceberg/pull/11392#issuecomment-2453316995 > Can you please run `spotlessApply` ? done @jbonofre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Build: Bump mkdocs-material from 9.5.42 to 9.5.43 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11455: URL: https://github.com/apache/iceberg/pull/11455 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.42 to 9.5.43. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc

[PR] Build: Bump software.amazon.awssdk:bom from 2.29.1 to 2.29.6 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11454: URL: https://github.com/apache/iceberg/pull/11454 Bumps software.amazon.awssdk:bom from 2.29.1 to 2.29.6. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa

[PR] Build: Bump com.azure:azure-sdk-bom from 1.2.28 to 1.2.29 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11453: URL: https://github.com/apache/iceberg/pull/11453 Bumps [com.azure:azure-sdk-bom](https://github.com/azure/azure-sdk-for-java) from 1.2.28 to 1.2.29. Release notes Sourced from https://github.com/azure/azure-sdk-for-java/releases";

[PR] Build: Bump com.google.cloud:libraries-bom from 26.49.0 to 26.50.0 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11451: URL: https://github.com/apache/iceberg/pull/11451 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.49.0 to 26.50.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bo

[PR] Build: Bump com.gradleup.shadow:shadow-gradle-plugin from 8.3.3 to 8.3.5 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11452: URL: https://github.com/apache/iceberg/pull/11452 Bumps [com.gradleup.shadow:shadow-gradle-plugin](https://github.com/GradleUp/shadow) from 8.3.3 to 8.3.5. Release notes Sourced from https://github.com/GradleUp/shadow/releases";>c

[PR] Build: Bump org.apache.httpcomponents.client5:httpclient5 from 5.4 to 5.4.1 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11450: URL: https://github.com/apache/iceberg/pull/11450 Bumps [org.apache.httpcomponents.client5:httpclient5](https://github.com/apache/httpcomponents-client) from 5.4 to 5.4.1. Changelog Sourced from https://github.com/apache/httpcompo

[PR] Build: Bump kafka from 3.8.0 to 3.8.1 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11449: URL: https://github.com/apache/iceberg/pull/11449 Bumps `kafka` from 3.8.0 to 3.8.1. Updates `org.apache.kafka:kafka-clients` from 3.8.0 to 3.8.1 Updates `org.apache.kafka:connect-api` from 3.8.0 to 3.8.1 Updates `org.apache.

[PR] Build: Bump jackson-bom from 2.18.0 to 2.18.1 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11448: URL: https://github.com/apache/iceberg/pull/11448 Bumps `jackson-bom` from 2.18.0 to 2.18.1. Updates `com.fasterxml.jackson:jackson-bom` from 2.18.0 to 2.18.1 Commits https://github.com/FasterXML/jackson-bom/commit/ef33ac77e1

[PR] Build: Bump net.snowflake:snowflake-jdbc from 3.19.1 to 3.20.0 [iceberg]

2024-11-02 Thread via GitHub
dependabot[bot] opened a new pull request, #11447: URL: https://github.com/apache/iceberg/pull/11447 Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.19.1 to 3.20.0. Release notes Sourced from https://github.com/snowflakedb/snowflake-jdbc/

Re: [I] refactor: make `PartitionSpec` more safe [iceberg-rust]

2024-11-02 Thread via GitHub
liurenjie1024 closed issue #550: refactor: make `PartitionSpec` more safe URL: https://github.com/apache/iceberg-rust/issues/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat: Safer PartitionSpec & SchemalessPartitionSpec [iceberg-rust]

2024-11-02 Thread via GitHub
liurenjie1024 merged PR #645: URL: https://github.com/apache/iceberg-rust/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: Safer PartitionSpec & SchemalessPartitionSpec [iceberg-rust]

2024-11-02 Thread via GitHub
liurenjie1024 commented on PR #645: URL: https://github.com/apache/iceberg-rust/pull/645#issuecomment-2453287370 Thanks @c-thiel for this great pr! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: Safer PartitionSpec & SchemalessPartitionSpec [iceberg-rust]

2024-11-02 Thread via GitHub
liurenjie1024 commented on code in PR #645: URL: https://github.com/apache/iceberg-rust/pull/645#discussion_r1826899584 ## crates/iceberg/src/spec/partition.rs: ## @@ -131,50 +205,22 @@ impl PartitionSpec { /// * Field names /// * Source column ids /// * Transform

Re: [PR] feat: Safer PartitionSpec & SchemalessPartitionSpec [iceberg-rust]

2024-11-02 Thread via GitHub
liurenjie1024 commented on PR #645: URL: https://github.com/apache/iceberg-rust/pull/645#issuecomment-2453287068 > @Xuanwo, @liurenjie1024 ready for another round. Ditched both the trait and the enum. Bare with me: > > As already mentioned earlier, the enum or the trait were just a ve

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

2024-11-02 Thread via GitHub
flyrain commented on code in PR #11390: URL: https://github.com/apache/iceberg/pull/11390#discussion_r1826877729 ## parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java: ## @@ -181,8 +184,8 @@ boolean[] shouldSkip() { return shouldSkip; } - private Map gener

Re: [PR] Core: Prevent dropping column which is referenced by active partition… [iceberg]

2024-11-02 Thread via GitHub
github-actions[bot] commented on PR #10352: URL: https://github.com/apache/iceberg/pull/10352#issuecomment-2453235701 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spark 3.5: Spark property for avoiding write failures due to missing fields in complex data types [iceberg]

2024-11-02 Thread via GitHub
github-actions[bot] commented on PR #10361: URL: https://github.com/apache/iceberg/pull/10361#issuecomment-2453235723 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] View: add property to describe advisory read mode [iceberg]

2024-11-02 Thread via GitHub
github-actions[bot] commented on PR #10362: URL: https://github.com/apache/iceberg/pull/10362#issuecomment-2453235736 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spec: Add context query parameter for all REST APIs [iceberg]

2024-11-02 Thread via GitHub
github-actions[bot] commented on PR #10359: URL: https://github.com/apache/iceberg/pull/10359#issuecomment-2453235712 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] Spark: Schema evolution is not reflected on branches [iceberg]

2024-11-02 Thread via GitHub
github-actions[bot] commented on issue #10274: URL: https://github.com/apache/iceberg/issues/10274#issuecomment-2453235683 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] Parquet: Use native getRowIndexOffset support instead of calculating it [iceberg]

2024-11-02 Thread via GitHub
github-actions[bot] commented on PR #10107: URL: https://github.com/apache/iceberg/pull/10107#issuecomment-2453235606 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Parquet: Use native getRowIndexOffset support instead of calculating it [iceberg]

2024-11-02 Thread via GitHub
github-actions[bot] closed pull request #10107: Parquet: Use native getRowIndexOffset support instead of calculating it URL: https://github.com/apache/iceberg/pull/10107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

2024-11-02 Thread via GitHub
amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1811606245 ## core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundati

Re: [I] The need for adding hadoop-aws dependencies for `add_files` procedure [iceberg]

2024-11-02 Thread via GitHub
nicornk commented on issue #8322: URL: https://github.com/apache/iceberg/issues/8322#issuecomment-2453124716 Is there any solution for this? Burned a few hours on this issue, trying out multiple different dependency configurations :( -- This is an automated message from the Apache Git Se

Re: [PR] API, Core: Add content offset and size to DeleteFile [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi commented on code in PR #11446: URL: https://github.com/apache/iceberg/pull/11446#discussion_r1826712824 ## api/src/main/java/org/apache/iceberg/util/ContentFileUtil.java: ## @@ -84,4 +85,25 @@ public static String referencedDataFileLocation(DeleteFile deleteFile) {

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

2024-11-02 Thread via GitHub
huaxingao commented on PR #11390: URL: https://github.com/apache/iceberg/pull/11390#issuecomment-2453099693 Thanks a lot @flyrain and @szehon-ho for your review! I've thought this over: I feel the [original change](https://github.com/apache/iceberg/pull/11390/commits/9b4e56d7dd9a6571655fd96

Re: [PR] AWS: Add AWS crt client support [iceberg]

2024-11-02 Thread via GitHub
sullis commented on PR #10217: URL: https://github.com/apache/iceberg/pull/10217#issuecomment-2453088922 I am resuming work on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

2024-11-02 Thread via GitHub
flyrain commented on code in PR #11390: URL: https://github.com/apache/iceberg/pull/11390#discussion_r1826603841 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java: ## @@ -93,10 +93,10 @@ protected CloseableIterator open(FileScanTask task) {

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

2024-11-02 Thread via GitHub
flyrain commented on code in PR #11390: URL: https://github.com/apache/iceberg/pull/11390#discussion_r1826606339 ## data/src/main/java/org/apache/iceberg/data/DeleteFilter.java: ## @@ -93,7 +94,8 @@ protected DeleteFilter( this.posDeletes = posDeleteBuilder.build();

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

2024-11-02 Thread via GitHub
flyrain commented on code in PR #11390: URL: https://github.com/apache/iceberg/pull/11390#discussion_r1826604505 ## data/src/main/java/org/apache/iceberg/data/DeleteFilter.java: ## @@ -69,7 +69,8 @@ protected DeleteFilter( List deletes, Schema tableSchema, S

Re: [PR] API, Core: Add content offset and size to DeleteFile [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi commented on code in PR #11446: URL: https://github.com/apache/iceberg/pull/11446#discussion_r1826603449 ## api/src/main/java/org/apache/iceberg/AddedRowsScanTask.java: ## @@ -55,7 +56,7 @@ default ChangelogOperation operation() { @Override default long sizeB

Re: [PR] API, Core: Add content offset and size to DeleteFile [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi commented on code in PR #11446: URL: https://github.com/apache/iceberg/pull/11446#discussion_r1826603449 ## api/src/main/java/org/apache/iceberg/AddedRowsScanTask.java: ## @@ -55,7 +56,7 @@ default ChangelogOperation operation() { @Override default long sizeB

Re: [PR] API, Core: Add data file reference to DeleteFile [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi commented on PR #11443: URL: https://github.com/apache/iceberg/pull/11443#issuecomment-2453038747 Thanks for reviewing, @rdblue @amogh-jahagirdar! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] API, Core: Add data file reference to DeleteFile [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi merged PR #11443: URL: https://github.com/apache/iceberg/pull/11443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

[I] org.apache.iceberg.exceptions.NoSuchTableException after creating table [iceberg]

2024-11-02 Thread via GitHub
petartushev opened a new issue, #11445: URL: https://github.com/apache/iceberg/issues/11445 ### Query engine I'm using flink as my engine. ### Question I have a java data streaming app that uses flink to process records from kafka that I want to store in iceberg tables w

Re: [PR] Spec v3: Add deletion vectors to the table spec [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi merged PR #11240: URL: https://github.com/apache/iceberg/pull/11240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Spec v3: Add deletion vectors to the table spec [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi commented on PR #11240: URL: https://github.com/apache/iceberg/pull/11240#issuecomment-2452945452 Thanks @rdblue for the great writeup! Thanks to everyone who reviewed and helped shape the doc! -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Puffin: Add delete-vector-v1 blob type [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi commented on PR #11238: URL: https://github.com/apache/iceberg/pull/11238#issuecomment-2452941800 The vote has passed, so I merged this PR. Thanks @rdblue! Thanks everyone who reviewed! -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Puffin: Add delete-vector-v1 blob type [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi merged PR #11238: URL: https://github.com/apache/iceberg/pull/11238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826536833 ## core/src/main/java/org/apache/iceberg/BaseFile.java: ## @@ -339,6 +344,9 @@ protected void internalSet(int pos, T value) { this.sortOrderId = (Intege

Re: [PR] Core: Add cardinality to PositionDeleteIndex [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi merged PR #11442: URL: https://github.com/apache/iceberg/pull/11442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] [WIP] API, Core: Add data file reference to DeleteFile [iceberg]

2024-11-02 Thread via GitHub
aokolnychyi commented on code in PR #11443: URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826530813 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -448,6 +449,12 @@ public Object get(int pos) { return wrapped.equalityFieldIds();