Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-27 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1694103029 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-27 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1694103029 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-27 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1694103029 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

[PR] Build: Bump net.snowflake:snowflake-jdbc from 3.17.0 to 3.18.0 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] opened a new pull request, #10801: URL: https://github.com/apache/iceberg/pull/10801 Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.17.0 to 3.18.0. Release notes Sourced from https://github.com/snowflakedb/snowflake-jdbc/

[PR] Build: Bump software.amazon.awssdk:bom from 2.26.21 to 2.26.25 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] opened a new pull request, #10800: URL: https://github.com/apache/iceberg/pull/10800 Bumps software.amazon.awssdk:bom from 2.26.21 to 2.26.25. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=soft

Re: [PR] Build: Bump com.aliyun.oss:aliyun-sdk-oss from 3.10.2 to 3.18.0 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] commented on PR #10610: URL: https://github.com/apache/iceberg/pull/10610#issuecomment-2254341513 Superseded by #10799. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Build: Bump com.aliyun.oss:aliyun-sdk-oss from 3.10.2 to 3.18.0 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] closed pull request #10610: Build: Bump com.aliyun.oss:aliyun-sdk-oss from 3.10.2 to 3.18.0 URL: https://github.com/apache/iceberg/pull/10610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] Build: Bump com.aliyun.oss:aliyun-sdk-oss from 3.10.2 to 3.18.1 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] opened a new pull request, #10799: URL: https://github.com/apache/iceberg/pull/10799 Bumps com.aliyun.oss:aliyun-sdk-oss from 3.10.2 to 3.18.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com

[PR] Build: Bump kafka from 3.7.1 to 3.8.0 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] opened a new pull request, #10797: URL: https://github.com/apache/iceberg/pull/10797 Bumps `kafka` from 3.7.1 to 3.8.0. Updates `org.apache.kafka:kafka-clients` from 3.7.1 to 3.8.0 Updates `org.apache.kafka:connect-api` from 3.7.1 to 3.8.0 Updates `org.apache.

[PR] Build: Bump nessie from 0.93.1 to 0.94.2 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] opened a new pull request, #10798: URL: https://github.com/apache/iceberg/pull/10798 Bumps `nessie` from 0.93.1 to 0.94.2. Updates `org.projectnessie.nessie:nessie-client` from 0.93.1 to 0.94.2 Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.93.1

[PR] Build: Bump mkdocs-material from 9.5.29 to 9.5.30 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] opened a new pull request, #10796: URL: https://github.com/apache/iceberg/pull/10796 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.29 to 9.5.30. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc

[PR] Build: Bump mkdocs-awesome-pages-plugin from 2.9.2 to 2.9.3 [iceberg]

2024-07-27 Thread via GitHub
dependabot[bot] opened a new pull request, #10795: URL: https://github.com/apache/iceberg/pull/10795 Bumps [mkdocs-awesome-pages-plugin](https://github.com/lukasgeiter/mkdocs-awesome-pages-plugin) from 2.9.2 to 2.9.3. Release notes Sourced from https://github.com/lukasgeiter/mkdoc

Re: [PR] Flink: improve snapshot compatibility check by comparing projected sort schema in SortKeySerializer [iceberg]

2024-07-27 Thread via GitHub
stevenzwu commented on PR #10794: URL: https://github.com/apache/iceberg/pull/10794#issuecomment-2254334279 There are some syntax differences btw the 1.18 and 1.19 unit tests due to the API difference. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Flink: improve snapshot compatibility check by comparing projected sort schema in SortKeySerializer [iceberg]

2024-07-27 Thread via GitHub
stevenzwu opened a new pull request, #10794: URL: https://github.com/apache/iceberg/pull/10794 also add unit tests for serializer snapshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Treat warning as error in CI/Dev [iceberg-python]

2024-07-27 Thread via GitHub
sungwy commented on PR #973: URL: https://github.com/apache/iceberg-python/pull/973#issuecomment-2254297106 Hi @ndrluis - thank you for turning the issue in https://github.com/apache/iceberg-python/issues/971 into these strategic items so quickly. I'm +1 for re-enabling this flag as

Re: [I] Pydantic warning when appending data [iceberg-python]

2024-07-27 Thread via GitHub
sungwy commented on issue #971: URL: https://github.com/apache/iceberg-python/issues/971#issuecomment-2254294963 Hi @ndrluis - first off, thank you very much for jumping in and helping test out the 0.7.0 release. It's a very large release, and I'm sincerely appreciative of all your he

Re: [I] Inconsistency in catalog.list_tables Behavior Across Python and Java: Returns Non-Iceberg Tables in Python Only [iceberg-python]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #314: URL: https://github.com/apache/iceberg-python/issues/314#issuecomment-2254291094 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity oc

Re: [I] Support manually make snapshot base on existing snapshot [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3361: URL: https://github.com/apache/iceberg/issues/3361#issuecomment-2254290622 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Spark: Fix NPE if streaming read since an expired snapshot [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3358: URL: https://github.com/apache/iceberg/pull/3358#issuecomment-2254290609 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] In upsert mode & PARTITIONED, insert TIMESTAMP value throws java.lang.ArrayIndexOutOfBoundsException [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3356: URL: https://github.com/apache/iceberg/issues/3356#issuecomment-2254290596 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Should do the best efforts to release hive table lock [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3336: URL: https://github.com/apache/iceberg/issues/3336#issuecomment-2254290576 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] how to peroform record level delete for parquet in java [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3342: URL: https://github.com/apache/iceberg/issues/3342#issuecomment-2254290589 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Hive handler estimate file size [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3328: URL: https://github.com/apache/iceberg/pull/3328#issuecomment-2254290569 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Flink: Incrementally rewrite data files in streaming. [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3323: URL: https://github.com/apache/iceberg/pull/3323#issuecomment-2254290554 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] How to fall back the current schema version to the previous one? [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3306: URL: https://github.com/apache/iceberg/issues/3306#issuecomment-2254290544 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Can spark operates iceberg table created by hive? [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3295: URL: https://github.com/apache/iceberg/issues/3295#issuecomment-2254290527 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Fixes got unexpected number of data files after binpack rewrite when there are delete files [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3301: URL: https://github.com/apache/iceberg/pull/3301#issuecomment-2254290536 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] JdbcCatalog should work with any SQL dialect and advanced jdbc-wrappers like Jooq [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3291: URL: https://github.com/apache/iceberg/issues/3291#issuecomment-2254290518 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] How to disable snapshot at table level? [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3290: URL: https://github.com/apache/iceberg/issues/3290#issuecomment-2254290507 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Glue catalog namespace cannot set description [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3286: URL: https://github.com/apache/iceberg/issues/3286#issuecomment-2254290496 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Include provided catalog impl as known types [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3289: URL: https://github.com/apache/iceberg/issues/3289#issuecomment-2254290500 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Pluggable Procedures [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3254: URL: https://github.com/apache/iceberg/issues/3254#issuecomment-2254290463 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] When trying to use Flink SQL to operate on Iceberg tables in parallel, tell me that Metadata.json is in a different location from the current metadata. [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3280: URL: https://github.com/apache/iceberg/issues/3280#issuecomment-2254290494 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Parquet: avoid premature closing of FSDataInputStream object [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3276: URL: https://github.com/apache/iceberg/pull/3276#issuecomment-2254290491 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] How can Iceberg support automatic compression and automatic merging of small files from Flink SQL? [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3266: URL: https://github.com/apache/iceberg/issues/3266#issuecomment-2254290478 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] add show partition with partitions [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3271: URL: https://github.com/apache/iceberg/pull/3271#issuecomment-2254290483 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Flink: Add operator to expire snapshots [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3255: URL: https://github.com/apache/iceberg/pull/3255#issuecomment-2254290470 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Update Nessie to 1.0.0 [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3243: URL: https://github.com/apache/iceberg/issues/3243#issuecomment-2254290449 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Is alter table supported or not in iceberg-hive? [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3247: URL: https://github.com/apache/iceberg/issues/3247#issuecomment-2254290457 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Extend DeleteOrphanFiles use cases [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3212: URL: https://github.com/apache/iceberg/issues/3212#issuecomment-2254290432 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Hive : fix vectorization test if hive it's not ok with vectorization [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3242: URL: https://github.com/apache/iceberg/pull/3242#issuecomment-2254290440 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Issue on Hive 3 vectorization with complex type [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on issue #3241: URL: https://github.com/apache/iceberg/issues/3241#issuecomment-2254290438 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: auto compact small files [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3213: URL: https://github.com/apache/iceberg/pull/3213#issuecomment-2254290437 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: add Jackson serialization util for Trino and Presto [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3210: URL: https://github.com/apache/iceberg/pull/3210#issuecomment-2254290425 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Flink: flink read iceberg upsert data use streaming mode [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] closed pull request #3095: Flink: flink read iceberg upsert data use streaming mode URL: https://github.com/apache/iceberg/pull/3095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Flink: flink read iceberg upsert data use streaming mode [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3095: URL: https://github.com/apache/iceberg/pull/3095#issuecomment-2254290370 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] API: add snapshot encryption key metadata [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3049: URL: https://github.com/apache/iceberg/pull/3049#issuecomment-2254290352 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] API: add snapshot encryption key metadata [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] closed pull request #3049: API: add snapshot encryption key metadata URL: https://github.com/apache/iceberg/pull/3049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Revert #2960 and commit no-op partition replacement operations [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] closed pull request #3043: Revert #2960 and commit no-op partition replacement operations URL: https://github.com/apache/iceberg/pull/3043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Revert #2960 and commit no-op partition replacement operations [iceberg]

2024-07-27 Thread via GitHub
github-actions[bot] commented on PR #3043: URL: https://github.com/apache/iceberg/pull/3043#issuecomment-2254290342 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [I] Rest Catalog and Writing data to Minio Raises `OSError: When initiating multiple part upload` [iceberg-python]

2024-07-27 Thread via GitHub
Al-Moatasem closed issue #974: Rest Catalog and Writing data to Minio Raises `OSError: When initiating multiple part upload` URL: https://github.com/apache/iceberg-python/issues/974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Rest Catalog and Writing data to Minio Raises `OSError: When initiating multiple part upload` [iceberg-python]

2024-07-27 Thread via GitHub
Al-Moatasem commented on issue #974: URL: https://github.com/apache/iceberg-python/issues/974#issuecomment-2254263817 @ndrluis thank you for your fast response, now it is writing the data into Minio -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] Rest Catalog and Writing data to Minio Raises `OSError: When initiating multiple part upload` [iceberg-python]

2024-07-27 Thread via GitHub
ndrluis commented on issue #974: URL: https://github.com/apache/iceberg-python/issues/974#issuecomment-2254259875 As a workaround, you can define the S3 configurations (endpoint, secret access key, and access key ID) in the load_rest method. ```python catalog = load_rest( na

Re: [I] Pydantic warning when appending data [iceberg-python]

2024-07-27 Thread via GitHub
ndrluis commented on issue #971: URL: https://github.com/apache/iceberg-python/issues/971#issuecomment-2254257270 Hi @sungwy, I got this warning message when I was testing the 0.7.0rc2. I have mixed feelings about not adding this to the final release. It does not raise an error, but

[I] Rest Catalog and Writing data to Minio Raises `OSError: When initiating multiple part upload` [iceberg-python]

2024-07-27 Thread via GitHub
Al-Moatasem opened a new issue, #974: URL: https://github.com/apache/iceberg-python/issues/974 ### Apache Iceberg version 0.6.1 (latest release) ### Please describe the bug 🐞 Hi, I am trying to use the **rest** catalog and writing the data into **Minio**, the scri

Re: [PR] Spark Action to Analyze table [iceberg]

2024-07-27 Thread via GitHub
findepi commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1694014900 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/NDVSketchGenerator.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Document stats `ndv` value representation [iceberg]

2024-07-27 Thread via GitHub
findepi commented on PR #10793: URL: https://github.com/apache/iceberg/pull/10793#issuecomment-2254249862 cc @karuppayya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Spark Action to Analyze table [iceberg]

2024-07-27 Thread via GitHub
findepi commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1694014900 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/NDVSketchGenerator.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Spark Action to Analyze table [iceberg]

2024-07-27 Thread via GitHub
findepi commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1694014828 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/NDVSketchGenerator.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Deprecate rest.authorization-url in favor of oauth2-server-uri [iceberg-python]

2024-07-27 Thread via GitHub
ndrluis commented on PR #962: URL: https://github.com/apache/iceberg-python/pull/962#issuecomment-2254247533 Updated deprecated version in commit [1039ac3](https://github.com/apache/iceberg-python/pull/962/commits/1039ac3f904a59e72b4e0f67dff14e8728b2009c) -- This is an automated message f

[I] Pydantic warning when appending data [iceberg-python]

2024-07-27 Thread via GitHub
ndrluis opened a new issue, #971: URL: https://github.com/apache/iceberg-python/issues/971 ### Apache Iceberg version main (development) ### Please describe the bug 🐞 Version: 0.7.0rc2 In 0.7.0rc1 we don't have this problem. Code to reproduce the warning

Re: [PR] Feature: Partition Binding and safe PartitionSpecBuilder [iceberg-rust]

2024-07-27 Thread via GitHub
c-thiel commented on PR #491: URL: https://github.com/apache/iceberg-rust/pull/491#issuecomment-2254206600 I have a few `ToDo`s in the code. Most of them are for tests in other modules that now fail. If someone has insights on the following, it would also be very helpful: Should we

[PR] Feature: Partition Binding and safe PartitionSpecBuilder [iceberg-rust]

2024-07-27 Thread via GitHub
c-thiel opened a new pull request, #491: URL: https://github.com/apache/iceberg-rust/pull/491 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [I] Query on nested struct field with PyIceberg? [iceberg-python]

2024-07-27 Thread via GitHub
sungwy commented on issue #953: URL: https://github.com/apache/iceberg-python/issues/953#issuecomment-2254183400 As discussed in the PR attempting to fix this issue, we will need to propose a syntax for describing nested fields in a row_filter. This is unfortunately not an easy task with a

Re: [PR] Deprecate rest.authorization-url in favor of oauth2-server-uri [iceberg-python]

2024-07-27 Thread via GitHub
sungwy commented on PR #962: URL: https://github.com/apache/iceberg-python/pull/962#issuecomment-2254182300 > We have already started the vote for release 0.7.0. I believe we need to change the deprecated_in to 0.8.0. > > Thoughts, @HonahX @sungwy? Hi @ndrluis - that sounds lik

[PR] Kafka Connect: Wait for coordinator shutdown [iceberg]

2024-07-27 Thread via GitHub
bryanck opened a new pull request, #10792: URL: https://github.com/apache/iceberg/pull/10792 This PR waits for the coordinator thread to complete when stopping the sink, to ensure there are no coordinator tasks pending before starting a new coordinator. The sink was designed with the assump

Re: [PR] Deprecate rest.authorization-url in favor of oauth2-server-uri [iceberg-python]

2024-07-27 Thread via GitHub
ndrluis commented on PR #962: URL: https://github.com/apache/iceberg-python/pull/962#issuecomment-2254152909 We have already started the vote for release 0.7.0. I believe we need to change the deprecated_in to 0.8.0. Thoughts, @HonahX @sungwy? -- This is an automated message from t

Re: [PR] Deprecate rest.authorization-url in favor of oauth2-server-uri [iceberg-python]

2024-07-27 Thread via GitHub
ndrluis commented on code in PR #962: URL: https://github.com/apache/iceberg-python/pull/962#discussion_r1693959627 ## pyiceberg/catalog/rest.py: ## @@ -290,11 +293,38 @@ def url(self, endpoint: str, prefixed: bool = True, **kwargs: Any) -> str: @property def auth_u

Re: [PR] Rename folder to memory [iceberg-rust]

2024-07-27 Thread via GitHub
Xuanwo merged PR #490: URL: https://github.com/apache/iceberg-rust/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

[PR] Rename folder to memory [iceberg-rust]

2024-07-27 Thread via GitHub
fqaiser94 opened a new pull request, #490: URL: https://github.com/apache/iceberg-rust/pull/490 In the [last PR](https://github.com/apache/iceberg-rust/pull/475), I renamed all code/docs from `in-memory` to `memory` but I forgot to rename the actual folder. I don't think it actually mat

Re: [PR] View Spec implementation [iceberg-rust]

2024-07-27 Thread via GitHub
c-thiel commented on PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#issuecomment-2254135228 Rebased on current master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] View Spec implementation [iceberg-rust]

2024-07-27 Thread via GitHub
c-thiel commented on code in PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1693949639 ## crates/iceberg/src/spec/view_version.rs: ## @@ -0,0 +1,313 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] View Spec implementation [iceberg-rust]

2024-07-27 Thread via GitHub
c-thiel commented on code in PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1693949266 ## crates/iceberg/src/spec/mod.rs: ## @@ -38,3 +40,6 @@ pub use sort::*; pub use table_metadata::*; pub use transform::*; pub use values::*; +pub use view_metadat

Re: [PR] View Spec implementation [iceberg-rust]

2024-07-27 Thread via GitHub
c-thiel commented on code in PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1693949164 ## crates/iceberg/src/error.rs: ## @@ -333,6 +335,28 @@ define_from_err!( define_from_err!(std::io::Error, ErrorKind::Unexpected, "IO Operation failed"); +/// C

Re: [PR] View Spec implementation [iceberg-rust]

2024-07-27 Thread via GitHub
Xuanwo commented on code in PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1693949016 ## crates/iceberg/src/error.rs: ## @@ -333,6 +335,28 @@ define_from_err!( define_from_err!(std::io::Error, ErrorKind::Unexpected, "IO Operation failed"); +/// Co

Re: [PR] View Spec implementation [iceberg-rust]

2024-07-27 Thread via GitHub
c-thiel commented on code in PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1693948492 ## crates/iceberg/src/error.rs: ## @@ -333,6 +335,28 @@ define_from_err!( define_from_err!(std::io::Error, ErrorKind::Unexpected, "IO Operation failed"); +/// C

Re: [PR] chore: Fix format of recent PRs [iceberg-rust]

2024-07-27 Thread via GitHub
Xuanwo merged PR #487: URL: https://github.com/apache/iceberg-rust/pull/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] chore: Fix format of recent PRs [iceberg-rust]

2024-07-27 Thread via GitHub
Xuanwo commented on PR #487: URL: https://github.com/apache/iceberg-rust/pull/487#issuecomment-2254093907 Hi, @Fokko, thanks for your review! I'm going to merge now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th