Re: [PR] Data: Add a util to read write partition stats [iceberg]

2024-06-23 Thread via GitHub
lirui-apache commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1650446414 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] 🐛 Write fields instead of spec object [iceberg-python]

2024-06-23 Thread via GitHub
HonahX merged PR #846: URL: https://github.com/apache/iceberg-python/pull/846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

2024-06-23 Thread via GitHub
HonahX commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1650427316 ## pyiceberg/io/pyarrow.py: ## @@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType: return TimeType() elif pa.

Re: [PR] Flink: Fix duplicate data in Flink's upsert writer for format V2 [iceberg]

2024-06-23 Thread via GitHub
zhongqishang commented on code in PR #10526: URL: https://github.com/apache/iceberg/pull/10526#discussion_r1650391006 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java: ## @@ -426,30 +425,44 @@ private void commitOperation( } @Ov

Re: [PR] Flink: Fix duplicate data in Flink's upsert writer for format V2 [iceberg]

2024-06-23 Thread via GitHub
pvary commented on code in PR #10526: URL: https://github.com/apache/iceberg/pull/10526#discussion_r1650379369 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java: ## @@ -426,30 +425,44 @@ private void commitOperation( } @Override

Re: [PR] Github: Add 0.6.1 to issue template [iceberg-python]

2024-06-23 Thread via GitHub
HonahX merged PR #841: URL: https://github.com/apache/iceberg-python/pull/841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Github: Add 0.6.1 to issue template [iceberg-python]

2024-06-23 Thread via GitHub
HonahX commented on PR #841: URL: https://github.com/apache/iceberg-python/pull/841#issuecomment-2185628338 Sorry for being late. @Fokko Thanks for adding this! @syun64 @kevinjqliu Thanks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message

[I] how to update nested column value with spark [iceberg]

2024-06-23 Thread via GitHub
panda403 opened a new issue, #10557: URL: https://github.com/apache/iceberg/issues/10557 ### Query engine use spark with iceberg ### Question here is my iceberg table root |-- partition_time: long (nullable = true) |-- base: struct (nullable = true) ||

[I] refactor: Remove dependency of tokio. [iceberg-rust]

2024-06-23 Thread via GitHub
liurenjie1024 opened a new issue, #418: URL: https://github.com/apache/iceberg-rust/issues/418 With the coming runtime module pr: https://github.com/apache/iceberg-rust/pull/233 we should carefully add runtime dependency. We have only one part depending on tokio: https://github.com

Re: [PR] Flink: Fix duplicate data in Flink's upsert writer for format V2 [iceberg]

2024-06-23 Thread via GitHub
zhongqishang commented on code in PR #10526: URL: https://github.com/apache/iceberg/pull/10526#discussion_r1650253742 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java: ## @@ -259,28 +268,28 @@ private void commitUpToCheckpoint( l

Re: [I] Add `CAST` to `parser.py` [iceberg-python]

2024-06-23 Thread via GitHub
github-actions[bot] commented on issue #198: URL: https://github.com/apache/iceberg-python/issues/198#issuecomment-2185376717 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apac

Re: [I] Incremental Changelog Scan [iceberg-python]

2024-06-23 Thread via GitHub
github-actions[bot] commented on issue #240: URL: https://github.com/apache/iceberg-python/issues/240#issuecomment-2185376705 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity oc

Re: [I] Add `CAST` to `parser.py` [iceberg-python]

2024-06-23 Thread via GitHub
github-actions[bot] closed issue #198: Add `CAST` to `parser.py` URL: https://github.com/apache/iceberg-python/issues/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] feat: support lower_bound&&upper_bound for parquet writer [iceberg-rust]

2024-06-23 Thread via GitHub
ZENOTME commented on code in PR #383: URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1650093045 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -188,10 +496,10 @@ impl ParquetWriter { .column_sizes(column_sizes) .valu

Re: [PR] feat: support lower_bound&&upper_bound for parquet writer [iceberg-rust]

2024-06-23 Thread via GitHub
ZENOTME commented on code in PR #383: URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1650093045 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -188,10 +496,10 @@ impl ParquetWriter { .column_sizes(column_sizes) .valu

Re: [PR] feat: support lower_bound&&upper_bound for parquet writer [iceberg-rust]

2024-06-23 Thread via GitHub
ZENOTME commented on code in PR #383: URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1650086826 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -78,106 +89,403 @@ impl FileWriterBuilder for ParquetWr type R = ParquetWriter; async

Re: [PR] feat: support lower_bound&&upper_bound for parquet writer [iceberg-rust]

2024-06-23 Thread via GitHub
ZENOTME commented on code in PR #383: URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1650086826 ## crates/iceberg/src/writer/file_writer/parquet_writer.rs: ## @@ -78,106 +89,403 @@ impl FileWriterBuilder for ParquetWr type R = ParquetWriter; async

Re: [PR] feat: runtime module [iceberg-rust]

2024-06-23 Thread via GitHub
liurenjie1024 commented on code in PR #233: URL: https://github.com/apache/iceberg-rust/pull/233#discussion_r1650082866 ## Cargo.toml: ## @@ -16,7 +16,6 @@ # under the License. [workspace] -resolver = "2" Review Comment: Why remove this? ## crates/iceberg/src/

Re: [PR] feat: runtime module [iceberg-rust]

2024-06-23 Thread via GitHub
liurenjie1024 commented on PR #233: URL: https://github.com/apache/iceberg-rust/pull/233#issuecomment-2184992611 > Made code change. Now tokio is always a dependency since traits like `AsyncWrite` are used. Do you have any plan for them? I made `tokio` a default feature to avoid breaking ch

Re: [PR] Cast 's', 'ms' and 'ns' PyArrow timestamp to 'us' precision on write [iceberg-python]

2024-06-23 Thread via GitHub
Fokko commented on PR #848: URL: https://github.com/apache/iceberg-python/pull/848#issuecomment-2184921011 Thanks @syun64 for working on this! 🙌 > Question: Are timestamp_ns and timestamptz_ns already supported? If so, should we just limit this PR to casting 's' and 'ms' to 'us' prec

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.55.1 [iceberg-go]

2024-06-23 Thread via GitHub
dependabot[bot] closed pull request #98: build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.55.1 URL: https://github.com/apache/iceberg-go/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.55.1 [iceberg-go]

2024-06-23 Thread via GitHub
dependabot[bot] commented on PR #98: URL: https://github.com/apache/iceberg-go/pull/98#issuecomment-2184910288 Superseded by #102. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.56.1 [iceberg-go]

2024-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #102: URL: https://github.com/apache/iceberg-go/pull/102 Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.48.0 to 1.56.1. Commits https://github.com/aws/aws-sdk-go-v2/commit/2d43b815f645eae1

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/glue from 1.73.1 to 1.85.0 [iceberg-go]

2024-06-23 Thread via GitHub
dependabot[bot] commented on PR #100: URL: https://github.com/apache/iceberg-go/pull/100#issuecomment-2184910011 Superseded by #101. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/glue from 1.73.1 to 1.85.0 [iceberg-go]

2024-06-23 Thread via GitHub
dependabot[bot] closed pull request #100: build(deps): bump github.com/aws/aws-sdk-go-v2/service/glue from 1.73.1 to 1.85.0 URL: https://github.com/apache/iceberg-go/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/glue from 1.73.1 to 1.87.1 [iceberg-go]

2024-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #101: URL: https://github.com/apache/iceberg-go/pull/101 Bumps [github.com/aws/aws-sdk-go-v2/service/glue](https://github.com/aws/aws-sdk-go-v2) from 1.73.1 to 1.87.1. Commits https://github.com/aws/aws-sdk-go-v2/commit/2d43b815f645ea