[PR] Build: Bump com.palantir.gradle.gitversion:gradle-git-version from 3.0.0 to 3.1.0 [iceberg]

2024-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #10468: URL: https://github.com/apache/iceberg/pull/10468 Bumps [com.palantir.gradle.gitversion:gradle-git-version](https://github.com/palantir/gradle-git-version) from 3.0.0 to 3.1.0. Release notes Sourced from https://github.com/palanti

[PR] Build: Bump software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin from 2.0.0 to 2.1.0 [iceberg]

2024-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #10467: URL: https://github.com/apache/iceberg/pull/10467 Bumps [software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin](https://github.com/aws/aws-s3-accessgrants-plugin-java-v2) from 2.0.0 to 2.1.0. Commits See full diff in

[PR] Build: Bump software.amazon.awssdk:bom from 2.25.64 to 2.25.69 [iceberg]

2024-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #10466: URL: https://github.com/apache/iceberg/pull/10466 Bumps software.amazon.awssdk:bom from 2.25.64 to 2.25.69. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=soft

[PR] Build: Bump jackson-bom from 2.14.2 to 2.17.1 [iceberg]

2024-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #10465: URL: https://github.com/apache/iceberg/pull/10465 Bumps `jackson-bom` from 2.14.2 to 2.17.1. Updates `com.fasterxml.jackson:jackson-bom` from 2.14.2 to 2.17.1 Commits https://github.com/FasterXML/jackson-bom/commit/50ab40a923

Re: [I] Support partitioned writes [iceberg-python]

2024-06-08 Thread via GitHub
ppasquet commented on issue #208: URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-2156311362 Curious as well as where you guys are standing on partitioned write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] Build: Bump mkdocs-material from 9.5.25 to 9.5.26 [iceberg]

2024-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #10464: URL: https://github.com/apache/iceberg/pull/10464 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.25 to 9.5.26. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc

Re: [PR] feat: glue table creation with some docs on testing [iceberg-go]

2024-06-08 Thread via GitHub
wolfeidau commented on PR #59: URL: https://github.com/apache/iceberg-go/pull/59#issuecomment-2156294155 @zeroshade I have had a shot at tidying this feature and addressing your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] AWS: Retain Glue Catalog column comment after updating Iceberg table [iceberg]

2024-06-08 Thread via GitHub
lawofcycles commented on PR #10276: URL: https://github.com/apache/iceberg/pull/10276#issuecomment-2156218208 Hi @amogh-jahagirdar would you review the latest change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-06-08 Thread via GitHub
marvinlanhenke commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1632091191 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -223,11 +217,10 @@ impl BoundPredicateVisitor for ExpressionEvaluatorVisitor<'_> {

Re: [PR] Add Snowflake catalog [iceberg-python]

2024-06-08 Thread via GitHub
prabodh1194 commented on code in PR #687: URL: https://github.com/apache/iceberg-python/pull/687#discussion_r1632063906 ## pyiceberg/catalog/snowflake_catalog.py: ## @@ -0,0 +1,237 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

Re: [PR] AWS: Retain Glue Catalog column comment after updating Iceberg table [iceberg]

2024-06-08 Thread via GitHub
lawofcycles commented on code in PR #10276: URL: https://github.com/apache/iceberg/pull/10276#discussion_r1632024064 ## aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java: ## @@ -231,11 +255,33 @@ static void setTableInputInformation( .col

Re: [PR] HELP WANTED: Jackson access issue [iceberg]

2024-06-08 Thread via GitHub
pan3793 commented on PR #10460: URL: https://github.com/apache/iceberg/pull/10460#issuecomment-2155988869 @nastra I don't think this is a simple "version not match" issue. 1. the code accesses `ALLOW_LEADING_DECIMAL_POINT_FOR_NUMBERS`. it should be available. 2. the code accesses a

Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-06-08 Thread via GitHub
sdd commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1631990232 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -223,11 +217,10 @@ impl BoundPredicateVisitor for ExpressionEvaluatorVisitor<'_> { literal:

Re: [PR] Improve MetricsReporter loading with class loader fallback [iceberg]

2024-06-08 Thread via GitHub
nastra commented on code in PR #10459: URL: https://github.com/apache/iceberg/pull/10459#discussion_r1631956569 ## core/src/test/java/org/apache/iceberg/TestCatalogUtil.java: ## @@ -249,6 +253,50 @@ public void fullTableNameWithDifferentValues() { .isEqualTo(pathStyleCa

Re: [PR] Improve MetricsReporter loading with class loader fallback [iceberg]

2024-06-08 Thread via GitHub
nastra commented on code in PR #10459: URL: https://github.com/apache/iceberg/pull/10459#discussion_r1631956021 ## core/src/test/resources/com/example/target/custom-metrics-reporter-1.0-SNAPSHOT.jar: ## Review Comment: I don't think it's a good idea to add jar files to the

Re: [PR] Improve MetricsReporter loading with class loader fallback [iceberg]

2024-06-08 Thread via GitHub
nastra commented on code in PR #10459: URL: https://github.com/apache/iceberg/pull/10459#discussion_r1631954976 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -443,36 +443,42 @@ public static void configureHadoopConf(Object maybeConfigurable, Object conf) {

Re: [PR] Improve MetricsReporter loading with class loader fallback [iceberg]

2024-06-08 Thread via GitHub
nastra commented on code in PR #10459: URL: https://github.com/apache/iceberg/pull/10459#discussion_r1631954848 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -443,36 +443,42 @@ public static void configureHadoopConf(Object maybeConfigurable, Object conf) {

Re: [PR] Improve MetricsReporter loading with class loader fallback [iceberg]

2024-06-08 Thread via GitHub
nastra commented on code in PR #10459: URL: https://github.com/apache/iceberg/pull/10459#discussion_r1631953806 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -443,36 +443,42 @@ public static void configureHadoopConf(Object maybeConfigurable, Object conf) {

Re: [PR] HELP WANTED: Jackson access issue [iceberg]

2024-06-08 Thread via GitHub
nastra commented on PR #10460: URL: https://github.com/apache/iceberg/pull/10460#issuecomment-2155863781 The error indicates that `ALLOW_LEADING_PLUS_SIGN_FOR_NUMBERS` isn't available in the Jackson version that is being used at runtime when the test is executed. I checked and `ALLOW_LEADIN

[I] Express REST server capabilities [iceberg]

2024-06-08 Thread via GitHub
nastra opened a new issue, #10462: URL: https://github.com/apache/iceberg/issues/10462 ### Proposed Change When introducing Views to the REST catalog it was clear that we need a way in the REST spec to signal which endpoints are being supported by a REST server. The idea of the propo