nastra commented on code in PR #10459:
URL: https://github.com/apache/iceberg/pull/10459#discussion_r1631953806
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -443,36 +443,42 @@ public static void configureHadoopConf(Object
maybeConfigurable, Object conf) {
public static MetricsReporter loadMetricsReporter(Map<String, String>
properties) {
String impl = properties.get(CatalogProperties.METRICS_REPORTER_IMPL);
if (impl == null) {
+ LOG.info(
+ "Custom metrics reporter is set, but the implementation is null.
Defaulting to LoggingMetricsReporter");
Review Comment:
I don't think this log message is actually correct. A custom metrics
reporter isn't set, because `CatalogProperties.METRICS_REPORTER_IMPL` evaluates
to `null`. So I'd rather just remove this log msg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
