Re: [PR] Infra: Track subtasks from Iceberg improvement proposal [iceberg]

2024-05-14 Thread via GitHub
ajantha-bhat commented on PR #10183: URL: https://github.com/apache/iceberg/pull/10183#issuecomment-2111676442 > Some proposals may not require tracking tasks, others may be much larger efforts that should be managed via projects (e.g. encryption support). @danielcweeks: The problem w

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-05-14 Thread via GitHub
ajantha-bhat commented on PR #10186: URL: https://github.com/apache/iceberg/pull/10186#issuecomment-2111667325 ping @bryanck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
pvary commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600932679 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/AggregatedStatisticsSerializer.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
pvary commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600931010 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/SketchUtil.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
pvary commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600928508 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/SketchUtil.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
pvary commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600925320 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/StatisticsType.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] feat: Convert predicate to arrow filter and push down to parquet reader [iceberg-rust]

2024-05-14 Thread via GitHub
viirya commented on PR #295: URL: https://github.com/apache/iceberg-rust/pull/295#issuecomment-2111463229 Thanks @liurenjie1024 for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] Convert row filter to arrow filter [iceberg-rust]

2024-05-14 Thread via GitHub
liurenjie1024 closed issue #265: Convert row filter to arrow filter URL: https://github.com/apache/iceberg-rust/issues/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] feat: Convert predicate to arrow filter and push down to parquet reader [iceberg-rust]

2024-05-14 Thread via GitHub
liurenjie1024 merged PR #295: URL: https://github.com/apache/iceberg-rust/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: Convert predicate to arrow filter and push down to parquet reader [iceberg-rust]

2024-05-14 Thread via GitHub
liurenjie1024 commented on PR #295: URL: https://github.com/apache/iceberg-rust/pull/295#issuecomment-2111431549 Thanks @viirya for this great effort! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Core: Pass input file into iterators to get the file name [iceberg]

2024-05-14 Thread via GitHub
szehon-ho commented on PR #9691: URL: https://github.com/apache/iceberg/pull/9691#issuecomment-2111407438 Maybe @RussellSpitzer has more idea what kind of corruption can lead to that error -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Core: Pass input file into iterators to get the file name [iceberg]

2024-05-14 Thread via GitHub
szehon-ho commented on PR #9691: URL: https://github.com/apache/iceberg/pull/9691#issuecomment-2111406615 I think as @RussellSpitzer said, its important to add test before pr can be merged to demonstrate the problem and validate the fix, otherwise its not obvious its a real existing problem

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600804435 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/MapDataStatistics.java: ## @@ -22,49 +22,69 @@ import org.apache.flink.annotation.Internal

Re: [PR] AWS: Retain Glue Catalog table description after updating Iceberg table [iceberg]

2024-05-14 Thread via GitHub
aajisaka commented on PR #10199: URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2111361552 Thank you @geruh @amogh-jahagirdar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] AWS: Retain Glue Catalog table description after updating Iceberg table [iceberg]

2024-05-14 Thread via GitHub
amogh-jahagirdar merged PR #10199: URL: https://github.com/apache/iceberg/pull/10199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] AWS: Retain Glue Catalog table description after updating Iceberg table [iceberg]

2024-05-14 Thread via GitHub
geruh commented on PR #10199: URL: https://github.com/apache/iceberg/pull/10199#issuecomment-2111348073 Awesome work @aajisaka, looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
rdblue commented on PR #10256: URL: https://github.com/apache/iceberg/pull/10256#issuecomment-2111327877 I'm surprised by this PR because I don't think that the auth properties should be overridden by a REST service. I'm not sure about it, but it sounds like @snazy seems to agree when he sa

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600773172 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/StatisticsType.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600772703 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/SketchUtil.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600762580 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/AggregatedStatisticsSerializer.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache So

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600765009 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/DataStatisticsSerializer.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600764054 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/DataStatisticsCoordinator.java: ## @@ -295,14 +320,15 @@ public void executionAttemptReady(

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600763166 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/AggregatedStatisticsTracker.java: ## @@ -104,30 +144,135 @@ AggregatedStatistics updateAndC

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600762580 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/AggregatedStatisticsSerializer.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache So

Re: [PR] Flink: refactor sink shuffling statistics collection [iceberg]

2024-05-14 Thread via GitHub
stevenzwu commented on code in PR #10331: URL: https://github.com/apache/iceberg/pull/10331#discussion_r1600742620 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/DataStatisticsOperator.java: ## @@ -47,151 +48,182 @@ * distribution to downstream subtas

[PR] Build: Bump mkdocstrings-python from 1.10.0 to 1.10.1 [iceberg-python]

2024-05-14 Thread via GitHub
dependabot[bot] opened a new pull request, #744: URL: https://github.com/apache/iceberg-python/pull/744 Bumps [mkdocstrings-python](https://github.com/mkdocstrings/python) from 1.10.0 to 1.10.1. Release notes Sourced from https://github.com/mkdocstrings/python/releases";>mkdocstrin

[PR] Build: Bump pyarrow from 16.0.0 to 16.1.0 [iceberg-python]

2024-05-14 Thread via GitHub
dependabot[bot] opened a new pull request, #743: URL: https://github.com/apache/iceberg-python/pull/743 Bumps [pyarrow](https://github.com/apache/arrow) from 16.0.0 to 16.1.0. Commits https://github.com/apache/arrow/commit/7dd1d34074af176d9e861a360e135ae57b21cf96";>7dd1d34 MINO

[I] Rest Catalog: `catalog.name` should not be part of namespace [iceberg-python]

2024-05-14 Thread via GitHub
c-thiel opened a new issue, #742: URL: https://github.com/apache/iceberg-python/issues/742 ### Apache Iceberg version main (development) ### Please describe the bug 🐞 This is a harder one: I am currently unhappy with the way pyiceberg handles the RestCatalogs `nam

Re: [I] Allow to configure thread-pool while using Iceberg to read the data (plan files/tasks) [iceberg]

2024-05-14 Thread via GitHub
amogh-jahagirdar commented on issue #10335: URL: https://github.com/apache/iceberg/issues/10335#issuecomment-246848 yeah we have a `planWith` API on Scans already and Trino is already using that when generating the splits here https://github.com/trinodb/trino/blob/master/plugin/trino-ic

Re: [I] Allow to configure thread-pool while using Iceberg to read the data (plan files/tasks) [iceberg]

2024-05-14 Thread via GitHub
amogh-jahagirdar commented on issue #10335: URL: https://github.com/apache/iceberg/issues/10335#issuecomment-231966 Checking, I thought we already had an API which allowed users to pass in a custom thread pool during planning? If not, I think that makes sense to add. -- This is an aut

Re: [I] Rest Catalog: table_exist does not succeed on 204 response code [iceberg-python]

2024-05-14 Thread via GitHub
c-thiel commented on issue #735: URL: https://github.com/apache/iceberg-python/issues/735#issuecomment-233767 Sure - PR is coming. I'll have some more tricky great catches tomorrow ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
adutra commented on PR #10256: URL: https://github.com/apache/iceberg/pull/10256#issuecomment-2111059746 Not a fan of leaving `oauthServerUri` out of the scope of this PR, for the reasons @snazy explained. Also what about `optionalOAuthParams`? For now it contains only resource and a

Re: [I] Aws Glue error for append data [iceberg-python]

2024-05-14 Thread via GitHub
apersilva commented on issue #738: URL: https://github.com/apache/iceberg-python/issues/738#issuecomment-2111055263 └┴───┴──┘Traceback (most recent call last): File "c:\g

Re: [I] Aws Glue error for append data [iceberg-python]

2024-05-14 Thread via GitHub
apersilva commented on issue #738: URL: https://github.com/apache/iceberg-python/issues/738#issuecomment-2111047010 def update_table(database_target, table_target,database_name, table_name, partition_by,size, process_date, custom_partion): catalog =load_catalog('glue', **{

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600580363 ## data/src/test/java/org/apache/iceberg/data/avro/TestSingleMessageEncoding.java: ## @@ -87,8 +86,10 @@ public void testByteBufferRoundTrip() throws Exception {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600578495 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -401,15 +391,15 @@ public void testProjectWithMissingFilterColumn() { } results.forEa

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600577333 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -281,36 +271,33 @@ public void testFullScan() { expected.addAll(file3FirstSnapshotRecords);

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600577909 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -326,15 +313,17 @@ private void verifyProjectIdColumn(Iterable results) { Lists.transfo

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600575976 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -266,12 +255,13 @@ public void testRandomData() throws IOException { append.commit();

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600575335 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -60,15 +53,15 @@ import org.apache.iceberg.types.Types; import org.apache.iceberg.util.DateTime

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600574151 ## data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: ## @@ -32,21 +32,14 @@ import java.io.IOException; import java.nio.ByteBuffer; import java.nio.ByteO

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600572291 ## data/src/test/java/org/apache/iceberg/data/TestGenericRecord.java: ## @@ -35,7 +34,7 @@ public void testGetNullValue() { GenericRecord record = GenericRecord.cre

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600568625 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -94,24 +94,24 @@ public void createTableAndData() throws IOException {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #9793: URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600568625 ## data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java: ## @@ -94,24 +94,24 @@ public void createTableAndData() throws IOException {

Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

2024-05-14 Thread via GitHub
igoradulian commented on PR #9793: URL: https://github.com/apache/iceberg/pull/9793#issuecomment-2111021027 @nastra please review last updates -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Accessing Iceberg tables without catalog [iceberg]

2024-05-14 Thread via GitHub
forestfang-stripe commented on issue #5512: URL: https://github.com/apache/iceberg/issues/5512#issuecomment-2111018765 `spark.read.format("iceberg").load(iceberg_path)` didn't work for me where `iceberg_path` is the parent folder of `/metadata` and `/data` `spark.read.format("iceberg").lo

Re: [PR] Concurrent table scans [iceberg-rust]

2024-05-14 Thread via GitHub
sdd commented on PR #373: URL: https://github.com/apache/iceberg-rust/pull/373#issuecomment-2111009920 I've updated this to ditch the concurrency when processing `ManifestEntry` items within a single `Manifest`, producing them asynchronously but sequentially instead. I've kept the limited c

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
snazy commented on PR #10256: URL: https://github.com/apache/iceberg/pull/10256#issuecomment-2110994585 > If I may, I would propose to: > > 1. the current impl should be improved, I think @adutra change is OK if we add scope configurable to deal with server side push > >

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
jbonofre commented on PR #10256: URL: https://github.com/apache/iceberg/pull/10256#issuecomment-2110987236 Maybe the confusion is due to the `config` endpoint is mixing different semantic properties, also related to the `scope`. For clarity, it would be better to split non authenticated c

Re: [PR] feat: Convert predicate to arrow filter and push down to parquet reader [iceberg-rust]

2024-05-14 Thread via GitHub
viirya commented on PR #295: URL: https://github.com/apache/iceberg-rust/pull/295#issuecomment-2110975107 Thanks @liurenjie1024. I just resolved the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Aws Glue error for append data [iceberg-python]

2024-05-14 Thread via GitHub
ndrluis commented on issue #738: URL: https://github.com/apache/iceberg-python/issues/738#issuecomment-2110972194 Hello @apersilva, can you give us a minimal code example that can reproduce this error? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
snazy commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1600512130 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.paths =

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
snazy commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1600501374 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.paths =

Re: [PR] Spark3.4: Add support for enums in SparkConfParser [iceberg]

2024-05-14 Thread via GitHub
huaxingao commented on PR #10330: URL: https://github.com/apache/iceberg/pull/10330#issuecomment-2110872216 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Infra: Track subtasks from Iceberg improvement proposal [iceberg]

2024-05-14 Thread via GitHub
danielcweeks commented on PR #10183: URL: https://github.com/apache/iceberg/pull/10183#issuecomment-2110858186 @ajantha-bhat I think we're being too heavy-handed here. I don't like including info that we don't expect or plan to have filled out in the template upon submission. Discussion a

Re: [PR] [FEAT]register table using iceberg metadata file via pyiceberg [iceberg-python]

2024-05-14 Thread via GitHub
kevinjqliu commented on code in PR #711: URL: https://github.com/apache/iceberg-python/pull/711#discussion_r1600447450 ## tests/catalog/test_glue.py: ## @@ -848,3 +848,17 @@ def test_table_exists( assert test_catalog.table_exists(identifier) is True # Act and Assert fo

Re: [PR] Spark3.4: Add support for enums in SparkConfParser [iceberg]

2024-05-14 Thread via GitHub
aokolnychyi merged PR #10330: URL: https://github.com/apache/iceberg/pull/10330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
danielcweeks commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1600446185 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.p

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-14 Thread via GitHub
flyrain commented on PR #10332: URL: https://github.com/apache/iceberg/pull/10332#issuecomment-2110766252 Thanks @amogh-jahagirdar and @nastra for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-14 Thread via GitHub
flyrain merged PR #10332: URL: https://github.com/apache/iceberg/pull/10332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
danielcweeks commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1600407349 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.p

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600393564 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestMonitorSource.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600392955 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestMonitorSource.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600391516 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/ManualSource.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600391271 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/ManualSource.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600390832 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/ManualSource.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600389873 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/ManualSource.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600389281 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/FlinkStreamingTestUtils.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache S

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600387856 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/FlinkStreamingTestUtils.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache S

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600387151 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/FlinkSqlExtension.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600386331 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/FlinkSqlExtension.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600383869 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/CollectingSink.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600382928 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/CollectingSink.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600382039 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/CollectingSink.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600379428 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TableChange.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600378983 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TableChange.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600377784 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/SingleThreadedIteratorSource.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Ap

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600377504 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/SingleThreadedIteratorSource.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Ap

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600376825 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/SingleThreadedIteratorSource.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Ap

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600375905 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/SingleThreadedIteratorSource.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Ap

Re: [PR] [FEAT]register table using iceberg metadata file via pyiceberg [iceberg-python]

2024-05-14 Thread via GitHub
MehulBatra commented on code in PR #711: URL: https://github.com/apache/iceberg-python/pull/711#discussion_r1600367489 ## tests/catalog/test_glue.py: ## @@ -848,3 +848,17 @@ def test_table_exists( assert test_catalog.table_exists(identifier) is True # Act and Assert fo

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600367408 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/SingleThreadedIteratorSource.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Ap

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600365825 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/MonitorSource.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600362592 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/MonitorSource.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600361833 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/MonitorSource.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600361227 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/MonitorSource.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600360902 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/MonitorSource.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600355296 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/MonitorSource.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software F

[I] Support Snapshot Management Operations: Cherry Pick Operation [iceberg-python]

2024-05-14 Thread via GitHub
syun64 opened a new issue, #737: URL: https://github.com/apache/iceberg-python/issues/737 ### Feature Request / Improvement Following is a list of operations that are supported in Spark: - rollback_to_snapshot (set_ref_snapshot) - rollback_to_timestamp (set_ref_snapshot) - set

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
snazy commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1600334750 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.paths =

Re: [I] PyIceberg Near-Term Roadmap [iceberg-python]

2024-05-14 Thread via GitHub
corleyma commented on issue #736: URL: https://github.com/apache/iceberg-python/issues/736#issuecomment-2110652446 @kevinjqliu @Fokko Where would something like the Iceberg Spark `create_changelog_view` procedure fit in this roadmap? Is that something that might be tackled as part of the o

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
snazy commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1600325406 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.paths =

Re: [PR] AWS: Retain Glue Catalog table description after updating Iceberg table [iceberg]

2024-05-14 Thread via GitHub
aajisaka commented on code in PR #10199: URL: https://github.com/apache/iceberg/pull/10199#discussion_r1600313072 ## aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java: ## @@ -316,6 +316,9 @@ void persistGlueTable( .skipArchive(awsProperties.gl

Re: [PR] Spark 3.5: Fix the setting of equalAuthorities in RemoveOrphanFilesProcedure [iceberg]

2024-05-14 Thread via GitHub
hantangwangd commented on code in PR #10334: URL: https://github.com/apache/iceberg/pull/10334#discussion_r1600292958 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRemoveOrphanFilesProcedure.java: ## @@ -647,19 +648,33 @@ public void testRe

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600274147 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/MonitorSource.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
rodmeneses commented on PR #10308: URL: https://github.com/apache/iceberg/pull/10308#issuecomment-2110557165 Please link the design doc in the PR description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-14 Thread via GitHub
danielcweeks commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1600255202 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.p

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
pvary commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600245674 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TableChange.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
pvary commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600240605 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/SingleThreadedIteratorSource.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

Re: [PR] Flink: Maintenance - MonitorSource [iceberg]

2024-05-14 Thread via GitHub
pvary commented on code in PR #10308: URL: https://github.com/apache/iceberg/pull/10308#discussion_r1600239450 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/SingleThreadedIteratorSource.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

  1   2   >