adutra commented on PR #10256:
URL: https://github.com/apache/iceberg/pull/10256#issuecomment-2111059746

   Not a fan of leaving `oauthServerUri` out of the scope of this PR, for the 
reasons @snazy explained.
   
   Also what about `optionalOAuthParams`? For now it contains only resource and 
audience, but we plan to add more config properties in the future, and these 
would naturally fit inside `optionalOAuthParams`.
   
   If `optionalOAuthParams` is not configurable by the server, this means that 
virtually _nothing_ related to auth is configurable through the server, which 
imho would make configuring client auth quite a complex task as more options 
could be added in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to