Re: [PR] feat: add `ExpressionEvaluator` [iceberg-rust]

2024-05-04 Thread via GitHub
sdd commented on code in PR #363: URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1590223772 ## crates/iceberg/src/expr/visitors/expression_evaluator.rs: ## @@ -0,0 +1,819 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[PR] Build: Bump mkdocs-material from 9.5.19 to 9.5.21 [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] opened a new pull request, #10272: URL: https://github.com/apache/iceberg/pull/10272 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.19 to 9.5.21. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.37.0 [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] commented on PR #10094: URL: https://github.com/apache/iceberg/pull/10094#issuecomment-2094575869 Superseded by #10270. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Build: Bump guava from 33.1.0-jre to 33.2.0-jre [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] opened a new pull request, #10271: URL: https://github.com/apache/iceberg/pull/10271 Bumps `guava` from 33.1.0-jre to 33.2.0-jre. Updates `com.google.guava:guava` from 33.1.0-jre to 33.2.0-jre Release notes Sourced from https://github.com/google/guava/releases";>c

[PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.38.0 [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] opened a new pull request, #10270: URL: https://github.com/apache/iceberg/pull/10270 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.28.0 to 26.38.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bo

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.37.0 [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] closed pull request #10094: Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.37.0 URL: https://github.com/apache/iceberg/pull/10094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Build: Bump net.snowflake:snowflake-jdbc from 3.15.1 to 3.16.0 [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] opened a new pull request, #10269: URL: https://github.com/apache/iceberg/pull/10269 Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.15.1 to 3.16.0. Release notes Sourced from https://github.com/snowflakedb/snowflake-jdbc/

[PR] Build: Bump com.google.errorprone:error_prone_annotations from 2.27.0 to 2.27.1 [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] opened a new pull request, #10268: URL: https://github.com/apache/iceberg/pull/10268 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.27.0 to 2.27.1. Release notes Sourced from https://github.com/google/error-prone

[PR] Build: Bump nessie from 0.80.0 to 0.81.1 [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] opened a new pull request, #10267: URL: https://github.com/apache/iceberg/pull/10267 Bumps `nessie` from 0.80.0 to 0.81.1. Updates `org.projectnessie.nessie:nessie-client` from 0.80.0 to 0.81.1 Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.80.0

[PR] Build: Bump software.amazon.awssdk:bom from 2.25.40 to 2.25.45 [iceberg]

2024-05-04 Thread via GitHub
dependabot[bot] opened a new pull request, #10266: URL: https://github.com/apache/iceberg/pull/10266 Bumps software.amazon.awssdk:bom from 2.25.40 to 2.25.45. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=soft

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-04 Thread via GitHub
flyrain commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1590183580 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -213,12 +214,13 @@ private AuthSession authSession() { e

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-04 Thread via GitHub
flyrain commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1590182083 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.paths

Re: [PR] REST: honor OAuth config sent by the server [iceberg]

2024-05-04 Thread via GitHub
flyrain commented on code in PR #10256: URL: https://github.com/apache/iceberg/pull/10256#discussion_r1590181761 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -215,6 +215,12 @@ public void initialize(String name, Map unresolved) { this.paths

Re: [PR] Support partial deletes [iceberg-python]

2024-05-04 Thread via GitHub
HonahX commented on code in PR #569: URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1584249768 ## pyiceberg/table/__init__.py: ## @@ -443,6 +468,54 @@ def overwrite( for data_file in data_files: update_snapshot.append_dat

Re: [PR] Add the build from source section [iceberg-go]

2024-05-04 Thread via GitHub
zeroshade commented on code in PR #70: URL: https://github.com/apache/iceberg-go/pull/70#discussion_r1590173336 ## README.md: ## @@ -21,6 +21,19 @@ `iceberg` is a Golang implementation of the [Iceberg table spec](https://iceberg.apache.org/spec/). +## Build From Source + +

Re: [I] An exception occurred while writing iceberg data through Spark: org. apache. iceberg. exceptions. CommitFailedException: metadata location has changed [iceberg]

2024-05-04 Thread via GitHub
srcnblgc commented on issue #9178: URL: https://github.com/apache/iceberg/issues/9178#issuecomment-2094374588 Possible to let me know how I can increase the number of retries on glue backed environment? Or how to set "From https://iceberg.apache.org/docs/1.2.1/configuration/#write-p

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-04 Thread via GitHub
sdd commented on PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#issuecomment-2094359196 FAO @Fokko @liurenjie1024 @marvinlanhenke: I've finished adding tests for this - it's ready for review, PTAL! 😄 -- This is an automated message from the Apache Git Service. To res

Re: [PR] Compare `Schema` and `StructType` fields irrespective of ordering [iceberg-python]

2024-05-04 Thread via GitHub
kevinjqliu commented on code in PR #700: URL: https://github.com/apache/iceberg-python/pull/700#discussion_r1590082827 ## tests/avro/test_resolver.py: ## @@ -372,7 +372,7 @@ def test_writer_ordering() -> None: ), ) -expected = StructWriter(((1, DoubleWriter()

Re: [I] Implement all functions of BoundPredicateVisitor for ManifestFilterVisitor [iceberg-rust]

2024-05-04 Thread via GitHub
s-akhtar-baig commented on issue #350: URL: https://github.com/apache/iceberg-rust/issues/350#issuecomment-2094259369 Thanks @marvinlanhenke, but I have made good progress on the task and will be creating a pull request in the next few days. -- This is an automated message from the Apach

Re: [I] Implement all functions of BoundPredicateVisitor for ManifestFilterVisitor [iceberg-rust]

2024-05-04 Thread via GitHub
marvinlanhenke commented on issue #350: URL: https://github.com/apache/iceberg-rust/issues/350#issuecomment-2094255209 @s-akhtar-baig are you still working on this? If you like I could try to help you out here? -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Implement the equality delete writer [iceberg-rust]

2024-05-04 Thread via GitHub
Dysprosium0626 commented on issue #341: URL: https://github.com/apache/iceberg-rust/issues/341#issuecomment-2094225277 Hi I nearly complete adding `EqualityDeleteWriter` but I encounter some problem. My impl is here: https://github.com/Dysprosium0626/iceberg-rust/blob/add_equality_delete

Re: [I] Failing to create a table using pyiceberg [iceberg-python]

2024-05-04 Thread via GitHub
felixscherz commented on issue #692: URL: https://github.com/apache/iceberg-python/issues/692#issuecomment-2094183984 Hi, I just tried this on my machine, could you double check the properties that you pass to `load_catalog`. I believe the glue catalog looks for the AWS profile name under `

Re: [PR] View Spec implementation [iceberg-rust]

2024-05-04 Thread via GitHub
c-thiel commented on PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#issuecomment-2094154795 @Fokko from my side this is good to merge - types are complete and tests are passing. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] feat: add `RollingManifestWriter` [iceberg-python]

2024-05-04 Thread via GitHub
felixscherz commented on PR #650: URL: https://github.com/apache/iceberg-python/pull/650#issuecomment-2094148537 Hi, I finally had some time to continue working on this. Based on your suggestions @geruh I added a `tell` method to the `OutputStream` protocol that returns the number of

Re: [PR] Core, Spark: Remove dangling deletes as part of RewriteDataFilesAction [iceberg]

2024-05-04 Thread via GitHub
nastra commented on code in PR #9724: URL: https://github.com/apache/iceberg/pull/9724#discussion_r1589914458 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveDanglingDeleteAction.java: ## @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software Foun