Re: [PR] Spark 3.5: Migrate tests in SQL directory to JUnit5 [iceberg]

2024-01-06 Thread via GitHub
chinmay-bhat commented on code in PR #9401: URL: https://github.com/apache/iceberg/pull/9401#discussion_r1443955073 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestTimestampWithoutZone.java: ## @@ -145,33 +137,31 @@ public void testAppendTimestampWithZone() {

Re: [PR] Spark 3.5: Migrate tests in SQL directory to JUnit5 [iceberg]

2024-01-06 Thread via GitHub
chinmay-bhat commented on code in PR #9401: URL: https://github.com/apache/iceberg/pull/9401#discussion_r1443954928 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestPartitionedWritesAsSelect.java: ## @@ -18,34 +18,35 @@ */ package org.apache.iceberg.spark.sq

[PR] Build: Bump mkdocs-monorepo-plugin from 1.0.5 to 1.1.0 [iceberg]

2024-01-06 Thread via GitHub
dependabot[bot] opened a new pull request, #9430: URL: https://github.com/apache/iceberg/pull/9430 Bumps [mkdocs-monorepo-plugin](https://github.com/backstage/mkdocs-monorepo-plugin) from 1.0.5 to 1.1.0. Changelog Sourced from https://github.com/backstage/mkdocs-monorepo-plugin/bl

[PR] Build: Bump com.google.errorprone:error_prone_annotations from 2.24.0 to 2.24.1 [iceberg]

2024-01-06 Thread via GitHub
dependabot[bot] opened a new pull request, #9429: URL: https://github.com/apache/iceberg/pull/9429 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.24.0 to 2.24.1. Release notes Sourced from https://github.com/google/error-prone/r

[PR] Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.32.0 [iceberg]

2024-01-06 Thread via GitHub
dependabot[bot] opened a new pull request, #9428: URL: https://github.com/apache/iceberg/pull/9428 Bumps [com.palantir.baseline:gradle-baseline-java](https://github.com/palantir/gradle-baseline) from 4.42.0 to 5.32.0. Release notes Sourced from https://github.com/palantir/gradle-b

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.9 [iceberg]

2024-01-06 Thread via GitHub
dependabot[bot] closed pull request #9391: Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.9 URL: https://github.com/apache/iceberg/pull/9391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.9 [iceberg]

2024-01-06 Thread via GitHub
dependabot[bot] commented on PR #9391: URL: https://github.com/apache/iceberg/pull/9391#issuecomment-1879931808 Superseded by #9426. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Build: Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [iceberg]

2024-01-06 Thread via GitHub
dependabot[bot] opened a new pull request, #9427: URL: https://github.com/apache/iceberg/pull/9427 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases";>org.assertj:assert

[PR] Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.12 [iceberg]

2024-01-06 Thread via GitHub
dependabot[bot] opened a new pull request, #9426: URL: https://github.com/apache/iceberg/pull/9426 Bumps software.amazon.awssdk:bom from 2.21.42 to 2.22.12. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa

Re: [I] Write iceberg Table Using Pyarrow [iceberg]

2024-01-06 Thread via GitHub
github-actions[bot] closed issue #6830: Write iceberg Table Using Pyarrow URL: https://github.com/apache/iceberg/issues/6830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Do Duck Db supports Iceberg table without converting to Pyarrow [iceberg]

2024-01-06 Thread via GitHub
github-actions[bot] commented on issue #6829: URL: https://github.com/apache/iceberg/issues/6829#issuecomment-1879887748 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Do Duck Db supports Iceberg table without converting to Pyarrow [iceberg]

2024-01-06 Thread via GitHub
github-actions[bot] closed issue #6829: Do Duck Db supports Iceberg table without converting to Pyarrow URL: https://github.com/apache/iceberg/issues/6829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] Write iceberg Table Using Pyarrow [iceberg]

2024-01-06 Thread via GitHub
github-actions[bot] commented on issue #6830: URL: https://github.com/apache/iceberg/issues/6830#issuecomment-1879887741 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Iceberg partition date/day equality problem when created on timestamp [iceberg]

2024-01-06 Thread via GitHub
github-actions[bot] commented on issue #6853: URL: https://github.com/apache/iceberg/issues/6853#issuecomment-1879887734 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Python: Implement Name Mapping to construct iceberg schema when field ids are not present in Data files [iceberg]

2024-01-06 Thread via GitHub
github-actions[bot] commented on issue #7451: URL: https://github.com/apache/iceberg/issues/7451#issuecomment-1879887719 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Python: Implement Name Mapping to construct iceberg schema when field ids are not present in Data files [iceberg]

2024-01-06 Thread via GitHub
github-actions[bot] closed issue #7451: Python: Implement Name Mapping to construct iceberg schema when field ids are not present in Data files URL: https://github.com/apache/iceberg/issues/7451 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Core: Create JUnit5 version of TableTestBase [iceberg]

2024-01-06 Thread via GitHub
lisirrx commented on code in PR #9217: URL: https://github.com/apache/iceberg/pull/9217#discussion_r1443873022 ## core/src/test/java/org/apache/iceberg/TestManifestReader.java: ## @@ -32,17 +32,15 @@ import org.apache.iceberg.types.Types; import org.assertj.core.api.Assertions

Re: [PR] Flink: Watermark read options [iceberg]

2024-01-06 Thread via GitHub
stevenzwu commented on code in PR #9346: URL: https://github.com/apache/iceberg/pull/9346#discussion_r1443861169 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceSql.java: ## @@ -39,4 +62,76 @@ public void before() throws IOException {

Re: [PR] Core: Create JUnit5 version of TableTestBase [iceberg]

2024-01-06 Thread via GitHub
nastra commented on code in PR #9217: URL: https://github.com/apache/iceberg/pull/9217#discussion_r1443813325 ## core/src/test/java/org/apache/iceberg/TestManifestReader.java: ## @@ -32,17 +32,15 @@ import org.apache.iceberg.types.Types; import org.assertj.core.api.Assertions;

Re: [PR] Spark 3.5: Migrate tests in SQL directory to JUnit5 [iceberg]

2024-01-06 Thread via GitHub
nastra commented on code in PR #9401: URL: https://github.com/apache/iceberg/pull/9401#discussion_r1443812981 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestTimestampWithoutZone.java: ## @@ -145,33 +137,31 @@ public void testAppendTimestampWithZone() {

Re: [PR] Spark 3.5: Migrate tests in SQL directory to JUnit5 [iceberg]

2024-01-06 Thread via GitHub
nastra commented on code in PR #9401: URL: https://github.com/apache/iceberg/pull/9401#discussion_r1443812495 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestPartitionedWritesAsSelect.java: ## @@ -18,34 +18,35 @@ */ package org.apache.iceberg.spark.sql; +

Re: [PR] Spark 3.5: Migrate tests in SQL directory to JUnit5 [iceberg]

2024-01-06 Thread via GitHub
nastra commented on code in PR #9401: URL: https://github.com/apache/iceberg/pull/9401#discussion_r1443812461 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java: ## @@ -18,90 +18,131 @@ */ package org.apache.iceberg.spark.sql; +import stati

Re: [PR] Parquet: Support reading INT96 column in row group filter [iceberg]

2024-01-06 Thread via GitHub
nastra commented on code in PR #8988: URL: https://github.com/apache/iceberg/pull/8988#discussion_r1443806214 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java: ## @@ -2181,20 +2181,28 @@ public void testTableWithInt96Timestamp()

Re: [PR] Core: Create JUnit5 version of TableTestBase [iceberg]

2024-01-06 Thread via GitHub
lisirrx commented on code in PR #9217: URL: https://github.com/apache/iceberg/pull/9217#discussion_r1443802733 ## core/src/test/java/org/apache/iceberg/TestManifestReader.java: ## @@ -32,17 +32,15 @@ import org.apache.iceberg.types.Types; import org.assertj.core.api.Assertions

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2024-01-06 Thread via GitHub
nastra commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1443801136 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier toV1Tabl

Re: [PR] Parquet: Support reading INT96 column in row group filter [iceberg]

2024-01-06 Thread via GitHub
manuzhang commented on code in PR #8988: URL: https://github.com/apache/iceberg/pull/8988#discussion_r1443788439 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java: ## @@ -2181,20 +2181,28 @@ public void testTableWithInt96Timestamp

Re: [I] Support partitioned writes [iceberg-python]

2024-01-06 Thread via GitHub
Fokko commented on issue #208: URL: https://github.com/apache/iceberg-python/issues/208#issuecomment-1879726210 Hey @jqin61 Thanks for replying here. I'm not aware of the fact that anyone already started on this. It would be great if you can take a stab at it 🚀 -- This is an automated me

Re: [I] Failed to assign splits due to the serialized split size [iceberg]

2024-01-06 Thread via GitHub
javrasya commented on issue #9410: URL: https://github.com/apache/iceberg/issues/9410#issuecomment-1879638660 We don't do any deletes actually. I will try to debug it locally somehow on that single file it was failing on. I can why it is big. But regardless, what do you think would be a rem