nastra commented on code in PR #8988:
URL: https://github.com/apache/iceberg/pull/8988#discussion_r1443806214
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -2181,20 +2181,28 @@ public void testTableWithInt96Timestamp() throws
IOException {
stagingLocation);
// validate we get the expected results back
- List<Row> expected =
spark.table("parquet_table").select("tmp_col").collectAsList();
- List<Row> actual =
- spark
- .read()
- .format("iceberg")
- .load(loadLocation(tableIdentifier))
- .select("tmp_col")
- .collectAsList();
- assertThat(actual).as("Rows must
match").containsExactlyInAnyOrderElementsOf(expected);
+ testWithFilter("tmp_col < to_timestamp('2000-01-31 08:30:00')",
tableIdentifier);
Review Comment:
I think it would be good to update the same test across all Spark versions,
because the code fixes it already across versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
