Re: [PR] Flink: Support watermark alignment of source splits [iceberg]

2023-12-16 Thread via GitHub
pvary commented on code in PR #9308: URL: https://github.com/apache/iceberg/pull/9308#discussion_r1429040047 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java: ## @@ -80,6 +87,25 @@ public RecordsWithSplitIds> fetch() throws

Re: [PR] Flink: Support watermark alignment of source splits [iceberg]

2023-12-16 Thread via GitHub
pvary commented on code in PR #9308: URL: https://github.com/apache/iceberg/pull/9308#discussion_r1429023418 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java: ## @@ -123,6 +155,19 @@ public void close() throws Exception {

Re: [PR] Flink: Support watermark alignment of source splits [iceberg]

2023-12-16 Thread via GitHub
pvary commented on PR #9308: URL: https://github.com/apache/iceberg/pull/9308#issuecomment-1859040607 > @pvary we are changing some critical code here. I would prefer we take a little more time here and get more people to review. > > Hence I would prefer if we disable/ignore the test

[PR] Build: Bump actions/labeler from 4 to 5 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9320: URL: https://github.com/apache/iceberg/pull/9320 Bumps [actions/labeler](https://github.com/actions/labeler) from 4 to 5. Release notes Sourced from https://github.com/actions/labeler/releases";>actions/labeler's releases. v5

[PR] Build: Bump actions/upload-artifact from 3 to 4 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9319: URL: https://github.com/apache/iceberg/pull/9319 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. Release notes Sourced from https://github.com/actions/upload-artifact/releases";>actions/uploa

[PR] Build: Bump mkdocs-material from 9.5.1 to 9.5.2 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9318: URL: https://github.com/apache/iceberg/pull/9318 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.1 to 9.5.2. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdocs-ma

[PR] Build: Bump org.roaringbitmap:RoaringBitmap from 1.0.0 to 1.0.1 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9317: URL: https://github.com/apache/iceberg/pull/9317 Bumps [org.roaringbitmap:RoaringBitmap](https://github.com/RoaringBitmap/RoaringBitmap) from 1.0.0 to 1.0.1. Release notes Sourced from https://github.com/RoaringBitmap/RoaringBitmap

[PR] Build: Bump org.springframework:spring-web from 5.3.30 to 6.1.2 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9316: URL: https://github.com/apache/iceberg/pull/9316 Bumps [org.springframework:spring-web](https://github.com/spring-projects/spring-framework) from 5.3.30 to 6.1.2. Release notes Sourced from https://github.com/spring-projects/spring

Re: [PR] Build: Bump io.netty:netty-buffer from 4.1.68.Final to 4.1.101.Final [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] commented on PR #9040: URL: https://github.com/apache/iceberg/pull/9040#issuecomment-1859030933 Superseded by #9315. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Build: Bump io.netty:netty-buffer from 4.1.68.Final to 4.1.101.Final [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] closed pull request #9040: Build: Bump io.netty:netty-buffer from 4.1.68.Final to 4.1.101.Final URL: https://github.com/apache/iceberg/pull/9040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.0 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9314: URL: https://github.com/apache/iceberg/pull/9314 Bumps software.amazon.awssdk:bom from 2.21.42 to 2.22.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwar

[PR] Build: Bump com.google.cloud:libraries-bom from 26.28.0 to 26.29.0 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9312: URL: https://github.com/apache/iceberg/pull/9312 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.28.0 to 26.29.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bom/

Re: [PR] Build: Bump org.springframework:spring-web from 5.3.30 to 6.1.1 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] closed pull request #9156: Build: Bump org.springframework:spring-web from 5.3.30 to 6.1.1 URL: https://github.com/apache/iceberg/pull/9156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Build: Bump org.springframework:spring-web from 5.3.30 to 6.1.1 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] commented on PR #9156: URL: https://github.com/apache/iceberg/pull/9156#issuecomment-1859030974 Superseded by #9316. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Build: Bump io.netty:netty-buffer from 4.1.68.Final to 4.1.104.Final [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9315: URL: https://github.com/apache/iceberg/pull/9315 Bumps [io.netty:netty-buffer](https://github.com/netty/netty) from 4.1.68.Final to 4.1.104.Final. Commits https://github.com/netty/netty/commit/257742648994569cadce5a6fac079bc8c04

[PR] Build: Bump nessie from 0.74.0 to 0.75.0 [iceberg]

2023-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #9313: URL: https://github.com/apache/iceberg/pull/9313 Bumps `nessie` from 0.74.0 to 0.75.0. Updates `org.projectnessie.nessie:nessie-client` from 0.74.0 to 0.75.0 Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.74.0 t

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428994320 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428984670 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

[PR] Apply Name mapping [iceberg-python]

2023-12-16 Thread via GitHub
syun64 opened a new pull request, #219: URL: https://github.com/apache/iceberg-python/pull/219 Closes: https://github.com/apache/iceberg-python/issues/202 Based on the following two working branches from @Fokko : 1. Name-mapping plumbing: https://github.com/apache/iceberg-python

Re: [I] Can't create iceberg catalog [iceberg]

2023-12-16 Thread via GitHub
github-actions[bot] commented on issue #7170: URL: https://github.com/apache/iceberg/issues/7170#issuecomment-1858993589 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Set Commit retry attempts dynamically based on file groups and partial progress max commits [iceberg]

2023-12-16 Thread via GitHub
github-actions[bot] commented on issue #7129: URL: https://github.com/apache/iceberg/issues/7129#issuecomment-1858993599 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Set Commit retry attempts dynamically based on file groups and partial progress max commits [iceberg]

2023-12-16 Thread via GitHub
github-actions[bot] closed issue #7129: Set Commit retry attempts dynamically based on file groups and partial progress max commits URL: https://github.com/apache/iceberg/issues/7129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Add checks in create/alter table if table location conflicts [iceberg]

2023-12-16 Thread via GitHub
github-actions[bot] commented on issue #7238: URL: https://github.com/apache/iceberg/issues/7238#issuecomment-1858993579 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Add checks in create/alter table if table location conflicts [iceberg]

2023-12-16 Thread via GitHub
github-actions[bot] closed issue #7238: Add checks in create/alter table if table location conflicts URL: https://github.com/apache/iceberg/issues/7238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Flink: Support watermark alignment of source splits [iceberg]

2023-12-16 Thread via GitHub
stevenzwu commented on code in PR #9308: URL: https://github.com/apache/iceberg/pull/9308#discussion_r1428932405 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java: ## @@ -80,6 +87,25 @@ public RecordsWithSplitIds> fetch() th

Re: [PR] Replace black by Ruff Formatter [iceberg-python]

2023-12-16 Thread via GitHub
hussein-awala commented on PR #127: URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1858928681 > @hussein-awala the PR has been merged :) I was waiting for the release, the merged PR was released 3 days ago in [v0.1.8](https://github.com/astral-sh/ruff/releases/tag

Re: [PR] Core: Avro writers use BlockingBinaryEncoder to enable array/map size calculations. [iceberg]

2023-12-16 Thread via GitHub
rustyconover commented on PR #8625: URL: https://github.com/apache/iceberg/pull/8625#issuecomment-1858921063 Hello @aokolnychyi and @Fokko, >> Question. Aren't we using DataFileWriter from Avro in our AvroFileAppender? If so, how is this PR affecting it? Won't we still use direct enc

Re: [PR] Flink: Support watermark alignment of source splits [iceberg]

2023-12-16 Thread via GitHub
stevenzwu commented on code in PR #9308: URL: https://github.com/apache/iceberg/pull/9308#discussion_r1428899523 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java: ## @@ -113,7 +139,13 @@ public void handleSplitsChanges(Spli

Re: [PR] Spark Streaming: Fix clobbering of files across streaming epochs [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9255: URL: https://github.com/apache/iceberg/pull/9255#discussion_r1428890835 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -673,11 +673,11 @@ public DataWriter createWriter(int partitionId, lo

Re: [PR] Spark Streaming: Fix clobbering of files across streaming epochs [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9255: URL: https://github.com/apache/iceberg/pull/9255#discussion_r1428890835 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -673,11 +673,11 @@ public DataWriter createWriter(int partitionId, lo

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428887738 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -99,17 +98,10 @@ static Map transformSpecs( abstract MetadataTableType metadataTabl

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428887230 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428887230 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar merged PR #9310: URL: https://github.com/apache/iceberg/pull/9310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Core: Make sqlFor case insensitive for dialect check [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar merged PR #9311: URL: https://github.com/apache/iceberg/pull/9311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9310: URL: https://github.com/apache/iceberg/pull/9310#discussion_r1428865937 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -202,7 +204,7 @@ public Map refs() { @Override public UUID uuid() { -return

Re: [PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar closed pull request #9310: Core: Fix Metadata table's UUID URL: https://github.com/apache/iceberg/pull/9310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on PR #9310: URL: https://github.com/apache/iceberg/pull/9310#issuecomment-1858885364 @ajantha-bhat the same unrelated Flink flaky test is occurring that https://github.com/apache/iceberg/pull/9309 is fixing. I'm going to close and re-open this PR to retrigger CI

Re: [PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9310: URL: https://github.com/apache/iceberg/pull/9310#discussion_r1428867709 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java: ## @@ -138,6 +139,18 @@ public void testManifestsTableAlwaysIgnoresResiduals() throws IO

Re: [PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9310: URL: https://github.com/apache/iceberg/pull/9310#discussion_r1428865937 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -202,7 +204,7 @@ public Map refs() { @Override public UUID uuid() { -return

Re: [PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9310: URL: https://github.com/apache/iceberg/pull/9310#discussion_r1428865937 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -202,7 +204,7 @@ public Map refs() { @Override public UUID uuid() { -return

Re: [PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9310: URL: https://github.com/apache/iceberg/pull/9310#discussion_r1428865937 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -202,7 +204,7 @@ public Map refs() { @Override public UUID uuid() { -return

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1428863691 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override +

Re: [PR] API, Core: Add sqlFor API to views to handle basic resolution of dialect [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9247: URL: https://github.com/apache/iceberg/pull/9247#discussion_r1428849085 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -103,4 +104,28 @@ public UpdateLocation updateLocation() { public UUID uuid() { retu

Re: [PR] API, Core: Add sqlFor API to views to handle basic resolution of dialect [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9247: URL: https://github.com/apache/iceberg/pull/9247#discussion_r1428849085 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -103,4 +104,28 @@ public UpdateLocation updateLocation() { public UUID uuid() { retu

Re: [PR] Core: Make sqlFor case insensitive for dialect check [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar closed pull request #9311: Core: Make sqlFor case insensitive for dialect check URL: https://github.com/apache/iceberg/pull/9311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Core: Make sqlFor case insensitive for dialect check [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on PR #9311: URL: https://github.com/apache/iceberg/pull/9311#issuecomment-1858867436 Looks like the unrelated Flink test TestIcebergSourceWithWatermarkExtractor is still flaky? I see there's a PR out for this https://github.com/apache/iceberg/pull/9309/files

[PR] Core: Make sqlFor case insensitive for dialect check [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar opened a new pull request, #9311: URL: https://github.com/apache/iceberg/pull/9311 This makes the dialect check case insensitive https://github.com/apache/iceberg/pull/9247/files . Was an oversight, after refactoring the code the case insensitive change mistakenly became ca

Re: [PR] Flink: Support watermark alignment of source splits [iceberg]

2023-12-16 Thread via GitHub
pvary commented on code in PR #9308: URL: https://github.com/apache/iceberg/pull/9308#discussion_r1428804100 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java: ## @@ -80,6 +87,18 @@ public RecordsWithSplitIds> fetch() throws

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-12-16 Thread via GitHub
ajantha-bhat commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1428761950 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override + pub

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2023-12-16 Thread via GitHub
ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428761407 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

[PR] Core: Fix Metadata table's UUID [iceberg]

2023-12-16 Thread via GitHub
ajantha-bhat opened a new pull request, #9310: URL: https://github.com/apache/iceberg/pull/9310 `BaseFileRewriteCoordinator`, `ScanTaskSetManager` calls `table.uuid()` of metadata table multiple times for setting and reading from cache. So, uuid has to be consistent on each call for a given

Re: [PR] Flink: Support watermark alignment of source splits [iceberg]

2023-12-16 Thread via GitHub
pvary commented on code in PR #9308: URL: https://github.com/apache/iceberg/pull/9308#discussion_r1428755761 ## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java: ## @@ -61,6 +67,7 @@ class IcebergSourceSplitReader implements S

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-16 Thread via GitHub
ajantha-bhat commented on PR #9309: URL: https://github.com/apache/iceberg/pull/9309#issuecomment-1858762537 Please also handle for other flink modules. Flakiness can come from any of the modules. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] API: Fix equals and hashCode in CharSequenceSet [iceberg]

2023-12-16 Thread via GitHub
aokolnychyi commented on PR #9245: URL: https://github.com/apache/iceberg/pull/9245#issuecomment-1858758541 Thanks, @szehon-ho! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] API: Fix equals and hashCode in CharSequenceSet [iceberg]

2023-12-16 Thread via GitHub
aokolnychyi merged PR #9245: URL: https://github.com/apache/iceberg/pull/9245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] API: Fix equals and hashCode in CharSequenceSet [iceberg]

2023-12-16 Thread via GitHub
aokolnychyi commented on PR #9245: URL: https://github.com/apache/iceberg/pull/9245#issuecomment-1858758126 @szehon-ho, I started by extending `AbstractSet`. Unfortunately, `hashCode` does not work. It is implemented using the iterator that in our case returns unwrapped elements and breaks