Re: [PATCH] Updated master.c process counting patch

2002-05-18 Thread Jeremy Howard
Henrique de Moraes Holschuh wrote: >I am, thus, somewhat wary of adding SHUT_RDWR inconditionally. Maybe we >could add a runtime-option that very busy sites can set if they need even >faster socket recycling? > > That sounds like a good idea.

Re: [PATCH] Updated master.c process counting patch

2002-05-18 Thread Henrique de Moraes Holschuh
On Thu, 16 May 2002, Jeremy Howard wrote: > I *strongly* recommend also including shutdown.diff. This is important > in Linux to avoid sockets handing around in CLOSE_WAIT state. Remove the I had a talk with some kernel people, and they confirmed that. shutdown(socket, SHUT_RD) should _always_

Re: [PATCH] Updated master.c process counting patch

2002-05-17 Thread Jeremy Howard
Henrique de Moraes Holschuh wrote: >On Fri, 17 May 2002, Jeremy Howard wrote: > > >>I believe (?) that this issue is less important on Solaris, because I >>think that it handles close() differently to Linux. However on Linux it >>is vital to flush receive buffers and call shutdown() to avoid

Re: [PATCH] Updated master.c process counting patch

2002-05-17 Thread Henrique de Moraes Holschuh
On Fri, 17 May 2002, Jeremy Howard wrote: > I believe (?) that this issue is less important on Solaris, because I > think that it handles close() differently to Linux. However on Linux it > is vital to flush receive buffers and call shutdown() to avoid hanging > connections. I am still studyin

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Jeremy Howard
Henrique de Moraes Holschuh wrote: >On Thu, 16 May 2002, Jeremy Howard wrote: > > >>I *strongly* recommend also including shutdown.diff. This is important >>in Linux to avoid sockets handing around in CLOSE_WAIT state. Remove the >>' && !imapd_in->tls_conn' bit everywhere for general distribu

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Jeremy Howard
Ken Murchison wrote: >If you set MALLOC_CHECK_=2, then imapd will abort() whenever it thinks >that there might be a corruption. By examining this core, it is easier >to track down these problems. I've done this a few times to track down >the subtle errors that have baffled others. > > Great.

Repeatable IMAP crash. Was Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Rob Mueller (fastmail)
ROTECTED]>; <[EMAIL PROTECTED]>; "Henrique de Moraes Holschuh" <[EMAIL PROTECTED]> Sent: Thursday, May 16, 2002 11:31 PM Subject: Re: [PATCH] Updated master.c process counting patch > > > Jeremy Howard wrote: > > > > Lawrence Greenfield

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Lawrence Greenfield
Date: Fri, 17 May 2002 09:35:39 +1000 From: Jeremy Howard <[EMAIL PROTECTED]> [...] Yes, 2.1.3 with skiplist for everything. We have the tls cache turned off, however. We prune the delivery database with -E0 every hour to avoid it getting big (otherwise DB recovery takes too long)

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Ken Murchison
Jeremy Howard wrote: > > Ken Murchison wrote: > > >I'm running a config almost the same as you and have never seen this > >problem. AFAIK, the CMU guys have never seen this either. Do you have > >a core that you can run a backtrace on, or can you force a core by > >setting MALLOC_CHECK_=2 be

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Jeremy Howard
Ken Murchison wrote: >I'm running a config almost the same as you and have never seen this >problem. AFAIK, the CMU guys have never seen this either. Do you have >a core that you can run a backtrace on, or can you force a core by >setting MALLOC_CHECK_=2 before starting master (see malloc(3) fo

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Scott Adkins
For what its worth, we run into this problem a lot in our environment as well... I had come to the same conclusion as Jeremy and Henrique did before they even posted their message about it to the list. The environment we are running is as follows: Cyrus IMAPD 2.0.16 Compaq Tru64 5.1 on Alpha

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Ken Murchison
Henrique de Moraes Holschuh wrote: > > On Thu, 16 May 2002, Ken Murchison wrote: > > If you have multiple services/processes the cores will overwrite each > > other, so you need to catch it fairly quickly (unless they all have the > > Unless you tell the kernel to use the pid in the corefile n

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Henrique de Moraes Holschuh
On Thu, 16 May 2002, Ken Murchison wrote: > If you have multiple services/processes the cores will overwrite each > other, so you need to catch it fairly quickly (unless they all have the Unless you tell the kernel to use the pid in the corefile name... Add this to the script on Linux 2.4.x: [ -

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Ken Murchison
Jeremy Howard wrote: > > Lawrence Greenfield wrote: > > > Date: Wed, 15 May 2002 16:02:42 -0300 > > From: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> > >[...] > > The point is, if that indeed happens, log or no log, master loses track of > > the number of children that can service

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Ken Murchison
Jeremy Howard wrote: > > Henrique de Moraes Holschuh wrote: > > >I don't know what Ken and Lawrence think of these patches, but I just > >finished porting the child pid tracking of master-avail.diff to 2.1.4CVS, > >and will post that to this list soon. I will also include it in Debian, > >whi

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Henrique de Moraes Holschuh
On Thu, 16 May 2002, Jeremy Howard wrote: > I *strongly* recommend also including shutdown.diff. This is important > in Linux to avoid sockets handing around in CLOSE_WAIT state. Remove the > ' && !imapd_in->tls_conn' bit everywhere for general distribution--this > is a workaround for a memory

Re: [PATCH] Updated master.c process counting patch

2002-05-16 Thread Henrique de Moraes Holschuh
On Wed, 15 May 2002, Michael Bacon wrote: > Would it be sufficient if the patch were altered slightly to send a > LOG_DEBUG message to syslog every time the master decremented one of the > worker counters, specifying what it did? Right now, it seems like the I've had some ideas for a bit of i

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Jeremy Howard
Henrique de Moraes Holschuh wrote: >On Wed, 15 May 2002, Scott Russell wrote: > > >>On Wed, May 15, 2002 at 10:35:04AM -0300, Henrique de Moraes Holschuh wrote: >> >> >>>I don't know about all the other patches, though. I have included the >>>safe_flock patches, and I *may* include the alar

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Jeremy Howard
Lawrence Greenfield wrote: > Date: Wed, 15 May 2002 16:02:42 -0300 > From: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> >[...] > The point is, if that indeed happens, log or no log, master loses track of > the number of children that can service requests. That would be a bug, and > t

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Jeremy Howard
Henrique de Moraes Holschuh wrote: >I don't know what Ken and Lawrence think of these patches, but I just >finished porting the child pid tracking of master-avail.diff to 2.1.4CVS, >and will post that to this list soon. I will also include it in Debian, >which will give some field-testing to the

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Michael Bacon
--On Wednesday, May 15, 2002 2:50 PM -0400 Lawrence Greenfield <[EMAIL PROTECTED]> wrote: >Date: Wed, 15 May 2002 15:37:50 -0300 >From: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> > [...] > >> We don't have this problem on any of our servers. > >Do you have preforking en

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Michael Bacon
--On Wednesday, May 15, 2002 4:29 PM -0400 Lawrence Greenfield <[EMAIL PROTECTED]> wrote: >Date: Wed, 15 May 2002 16:02:42 -0300 >From: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> > [...] >The point is, if that indeed happens, log or no log, master loses > track ofthe numbe

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Henrique de Moraes Holschuh
On Wed, 15 May 2002, Lawrence Greenfield wrote: > service processes without one of those service processes crashing > (either by the sysadmin or otherwise) then there's some other problem > in the child accounting. Well, anything that could cause the messages to be lost will cause trouble for the

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Lawrence Greenfield
Date: Wed, 15 May 2002 16:02:42 -0300 From: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> [...] The point is, if that indeed happens, log or no log, master loses track of the number of children that can service requests. That would be a bug, and the patch supposedly fixes this bug

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Henrique de Moraes Holschuh
On Wed, 15 May 2002, Lawrence Greenfield wrote: >Good question, isn't it? I am trying to track a segfault in the auth_unix >callbacks with SASL 2.1.2 [1], but after that I will try to do a once-over >the entire master flow, with and without the child pid tracking patches. > >[1]

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Lawrence Greenfield
Date: Wed, 15 May 2002 15:37:50 -0300 From: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> [...] > > I'm still wondering what causes these problems. Some reports say that > service processes aren't crashing; if they're not crashing, how is the > count getting off? Good ques

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Henrique de Moraes Holschuh
On Wed, 15 May 2002, Lawrence Greenfield wrote: >Date: Wed, 15 May 2002 08:34:29 -0400 >From: Scott Adkins <[EMAIL PROTECTED]> > [...] >I am still waiting to hear from Ken and Lawrence on what they think about >these patches? Will any or all of them be implented in the next releas

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Lawrence Greenfield
Date: Wed, 15 May 2002 08:34:29 -0400 From: Scott Adkins <[EMAIL PROTECTED]> [...] I am still waiting to hear from Ken and Lawrence on what they think about these patches? Will any or all of them be implented in the next release? I'm still wondering what causes these problems. Some

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Scott Russell
On Wed, May 15, 2002 at 10:52:39AM -0300, Henrique de Moraes Holschuh wrote: > On Wed, 15 May 2002, Scott Russell wrote: > > On Wed, May 15, 2002 at 10:35:04AM -0300, Henrique de Moraes Holschuh wrote: > > > I don't know about all the other patches, though. I have included the > > > safe_flock pat

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Scott Russell
On Wed, May 15, 2002 at 10:35:04AM -0300, Henrique de Moraes Holschuh wrote: > On Wed, 15 May 2002, Scott Adkins wrote: > > I am still waiting to hear from Ken and Lawrence on what they think about > > these patches? Will any or all of them be implented in the next release? > > I don't know what

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Henrique de Moraes Holschuh
On Wed, 15 May 2002, Scott Russell wrote: > On Wed, May 15, 2002 at 10:35:04AM -0300, Henrique de Moraes Holschuh wrote: > > I don't know about all the other patches, though. I have included the > > safe_flock patches, and I *may* include the alarm and locking stuff in > > master-avail.diff later,

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Henrique de Moraes Holschuh
On Wed, 15 May 2002, Scott Adkins wrote: > I am still waiting to hear from Ken and Lawrence on what they think about > these patches? Will any or all of them be implented in the next release? I don't know what Ken and Lawrence think of these patches, but I just finished porting the child pid tra

Re: [PATCH] Updated master.c process counting patch

2002-05-15 Thread Scott Adkins
I am still waiting to hear from Ken and Lawrence on what they think about these patches? Will any or all of them be implented in the next release? Scott --On Wednesday, May 15, 2002 12:41 PM +1000 Jeremy Howard <[EMAIL PROTECTED]> wrote: > Thanks to Jaska Kivela, some patch formatting problem

[PATCH] Updated master.c process counting patch

2002-05-14 Thread Jeremy Howard
Thanks to Jaska Kivela, some patch formatting problems that caused the master.c process counting patch to not apply cleanly have been resolved. The patch set has been updated, and now also incorporates the master.c race condition patch: http://jhoward.fastmail.fm/patches/cyrus/imap-diff.tgz T