Bug#1067022: man2html: Segmentation fault with tzfile(5)

Package: man2html Version: 1.6g-16 Severity: normal Tags: upstream X-Debbugs-Cc: Alejandro Colomar , Paul Eggert , "G. Branden Robinson" , linux-...@vger.kernel.org, groff@gnu.org, t...@iana.org Dear Maintainer, The page tzfile(5) from tzdb-2024a manages to consistently produce a Segmentation f

Re: Use public inbox in groff [was: Remove redundant tests]

Please contact overse...@sourceware.org. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: Use public inbox in groff [was: Remove redundant tests]

Hi Branden, On Sat, Mar 16, 2024 at 08:37:00PM +0100, Andreas Schwab wrote: > Please contact overse...@sourceware.org. Branden, I guess it's you who'd need to ask them to do it. Would you mind doing the honours? Have a lovely night! Alex -- signature.asc

Re: Use public inbox in groff [was: Remove redundant tests]

On Sat, Mar 16, 2024 at 08:37:00PM +0100, Andreas Schwab wrote: > Please contact overse...@sourceware.org. Thanks! Have a lovely night! Alex > -- > Andreas Schwab, sch...@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completel

Re: groff now undoing .ad settings after .IP

Okay, I think we've sorted out the way forward for groff that would address the immediate issue. That leaves three questions: should I do something in the next release of Pod::Man, should I assume that the next release of groff will default to ragged right, and is there a way for Pod::Man output t

Use public inbox in groff [was: Remove redundant tests]

[CC += groff@] Hi Andreas, Dave, [This sub-thread started here: ] On Sat, Mar 16, 2024 at 12:11:08PM -0500, Dave Kemper wrote: > On Sat, Mar 16, 2024 at 5:44 AM Alejandro Colomar wrote: > > Where do I need to do my lobbying?

[PATCH v5 09/10] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp |

[PATCH v5 03/10] src/: Remove redundant checks after strtol(3).

`str == end` can only happen if strtol(3) returns 0. Fixes: 351da0dcdf70 ("groff before CVS: release 1.02") Fixes: d21a9dbc7a83 ("* src/devices/grolbp/lbp.cc: (long_options): Add -w/--linewidth option.") Fixes: dc5351364982 ("groff before CVS: release 1.10") Link:

[PATCH v5 08/10] [indxbib]: Remove dead code

The tests (LONG_MAX > INT_MAX && n > INT_MAX) and (n > INT_MAX) are equivalent. Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Link: Cc: "G. Branden Robinson" Cc: Dave Kempe

[PATCH v5 10/10] [grolbp]: Fix range check after strtol(3)

In case INT_MAX==LONG_MAX, we need to check for ERANGE to reject high values. The test 'n > INT_MAX' would never be true. Fixes: d21a9dbc7a83 ("* src/devices/grolbp/lbp.cc: (long_options): Add -w/--linewidth option.") Link: Link:

[PATCH v5 02/10] [libgroff]: Remove dead code

strtol(3) can only report ERANGE, if the base is valid (and it is). Fixes: e4290210f2c1 ("Implement `SOURCE_DATE_EPOCH' for reproducible builds.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG C

[PATCH v5 01/10] [libgroff]: Remove redundant checks.

ERANGE can only happen if strtol(3) returns either LONG_MIN or LONG_MAX. Fixes: e4290210f2c1 ("Implement `SOURCE_DATE_EPOCH' for reproducible builds.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBE

[PATCH v5 07/10] [indxbib]: Clear errno before calling strtol(3)

Otherwise, errno may hold ERANGE from before. See strtol(3). Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-o

[PATCH v5 04/10] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Fixes: 98608a8ba037 ("grolbp output device") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar

[PATCH v5 05/10] src/: ceil_prime(): Add function to get the lowest prime not less than n

And use it where the same logic was being open-coded. While at it, fix the logic, which was incorrect in the open-coded call sites, since for an input of 1, it produced 3, but the first prime is 2. A recent commit started rejecting 1 earlier, so this bug was now impossible to trigger, but remained

[PATCH v5 00/10] strtol(3)-related fixes

Hi, This v5 further documents which commits introduced some issues being fixed, and with it, I found James also wrote some of this, so I've also CCed him. See range-diff below. Cheers, Alex Alejandro Colomar (10): [libgroff]: Remove redundant checks. [libgroff]: Remove dead code src/: Rem

[PATCH v5 06/10] [indxbib]: Don't else after [[noreturn]]

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp |

Re: [PATCH v4 10/10] [grolbp]: Fix range check after strtol(3)

On Sat, Mar 16, 2024 at 12:55:07PM +0100, Alejandro Colomar wrote: > In case INT_MAX==LONG_MAX, we need to check for ERANGE to reject > high values. The test 'n > INT_MAX' would never be true. > > Fixes: d21a9dbc7a83 ("Werner LEMBERG ") Oops, this should be ("* src/devices/grolbp/lbp.cc: (long_o

[PATCH v4 10/10] [grolbp]: Fix range check after strtol(3)

In case INT_MAX==LONG_MAX, we need to check for ERANGE to reject high values. The test 'n > INT_MAX' would never be true. Fixes: d21a9dbc7a83 ("Werner LEMBERG ") Link: Link: Cc: "G. Branden Robinson" Cc: Dave Kemper C

[PATCH v4 09/10] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 6 +- 1 file

[PATCH v4 01/10] [libgroff]: Remove redundant checks.

ERANGE can only happen if strtol(3) returns either LONG_MIN or LONG_MAX. Fixes: e4290210f2c1 ("Implement `SOURCE_DATE_EPOCH' for reproducible builds.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBE

[PATCH v4 06/10] [indxbib]: Don't else after [[noreturn]]

Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 20 1 file changed, 8 insertions(+), 12 deletions(-) dif

[PATCH v4 08/10] [indxbib]: Remove dead code

The tests (LONG_MAX > INT_MAX && n > INT_MAX) and (n > INT_MAX) are equivalent. Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Link: Cc: "G. Branden Robinson" Cc: Dave Kempe

[PATCH v4 07/10] [indxbib]: Clear errno before calling strtol(3)

Otherwise, errno may hold ERANGE from before. See strtol(3). Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro

[PATCH v4 03/10] src/: Remove redundant checks after strtol(3).

`str == end` can only happen if strtol(3) returns 0. Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp | 4 ++-- src/devices/gr

[PATCH v4 02/10] [libgroff]: Remove dead code

strtol(3) can only report ERANGE, if the base is valid (and it is). Fixes: e4290210f2c1 ("Implement `SOURCE_DATE_EPOCH' for reproducible builds.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG S

[PATCH v4 00/10] strtol(3)-related fixes

Hi Branden, Dave, In this v4, I've found another case of the LONG_MAX==INT_MAX problem. I've also added two authors of bugs being fixed to CC, in case they've written similar bugs in other software and they want to fix them. Below is a range diff. I strongly suggest considering the use of liba2i

[PATCH v4 05/10] src/: ceil_prime(): Add function to get the lowest prime not less than n

And use it where the same logic was being open-coded. While at it, fix the logic, which was incorrect in the open-coded call sites, since for an input of 1, it produced 3, but the first prime is 2. A recent commit started rejecting 1 earlier, so this bug was now impossible to trigger, but remained

[PATCH v4 04/10] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Closes: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 2 +- 1 file changed, 1 i