Hi, This v5 further documents which commits introduced some issues being fixed, and with it, I found James also wrote some of this, so I've also CCed him. See range-diff below.
Cheers,
Alex
Alejandro Colomar (10):
[libgroff]: Remove redundant checks.
[libgroff]: Remove dead code
src/: Remove redundant checks after strtol(3).
[grolbp]: Remove bogus (and redundant) check
src/: ceil_prime(): Add function to get the lowest prime not less than
n
[indxbib]: Don't else after [[noreturn]]
[indxbib]: Clear errno before calling strtol(3)
[indxbib]: Remove dead code
[indxbib]: Collapse related tests
[grolbp]: Fix range check after strtol(3)
src/devices/grodvi/dvi.cpp | 4 ++--
src/devices/grolbp/lbp.cpp | 7 ++++---
src/devices/grolj4/lj4.cpp | 6 +++---
src/devices/grops/ps.cpp | 4 ++--
src/devices/grops/psrm.cpp | 2 +-
src/include/lib.h | 2 +-
src/libs/libbib/index.cpp | 4 +---
src/libs/libgroff/curtime.cpp | 3 +--
src/libs/libgroff/font.cpp | 2 +-
src/libs/libgroff/prime.cpp | 18 +++++++++++++++++-
src/preproc/eqn/lex.cpp | 2 +-
src/preproc/pic/tex.cpp | 2 +-
src/preproc/refer/command.cpp | 3 +--
src/preproc/refer/ref.cpp | 2 +-
src/preproc/refer/refer.cpp | 6 +++---
src/utils/indxbib/indxbib.cpp | 27 ++++++++-------------------
src/utils/lkbib/lkbib.cpp | 2 +-
src/utils/lookbib/lookbib.cpp | 2 +-
src/utils/tfmtodit/tfmtodit.cpp | 5 +----
19 files changed, 51 insertions(+), 52 deletions(-)
Range-diff against v4:
1: e79b884b4 ! 1: 0aea166ce [libgroff]: Remove redundant checks.
@@ Commit message
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/libs/libgroff/curtime.cpp ##
2: 0f7a1dbae ! 2: 7ca4db995 [libgroff]: Remove dead code
@@ Commit message
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/libs/libgroff/curtime.cpp ##
3: 7b64b59d3 ! 3: c329d28ea src/: Remove redundant checks after strtol(3).
@@ Commit message
`str == end` can only happen if strtol(3) returns 0.
+ Fixes: 351da0dcdf70 ("groff before CVS: release 1.02")
+ Fixes: d21a9dbc7a83 ("* src/devices/grolbp/lbp.cc: (long_options): Add
-w/--linewidth option.")
+ Fixes: dc5351364982 ("groff before CVS: release 1.10")
Link: <https://savannah.gnu.org/bugs/?65451>
Cc: "G. Branden Robinson" <[email protected]>
Cc: Dave Kemper <[email protected]>
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/devices/grodvi/dvi.cpp ##
4: f61b16e5e ! 4: 9e56cc80e [grolbp]: Remove bogus (and redundant) check
@@ Commit message
`str == end` can only happen if strtol(3) returns 0.
- Closes: <https://savannah.gnu.org/bugs/?65451>
+ Fixes: 98608a8ba037 ("grolbp output device")
+ Link: <https://savannah.gnu.org/bugs/?65451>
Cc: "G. Branden Robinson" <[email protected]>
Cc: Dave Kemper <[email protected]>
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/devices/grolbp/lbp.cpp ##
5: 647391522 ! 5: 29798c58b src/: ceil_prime(): Add function to get the
lowest prime not less than n
@@ Commit message
Also, since this is a library function, let's behave well for an input
of 0, which is mathematically fine, and return also the first prime, 2.
+ Fixes: 4c7a3396375b ("[libbib, libgroff, indxbib]: Slightly refactor.")
Link: <https://savannah.gnu.org/bugs/?65452>
Link: <https://lists.gnu.org/archive/html/groff/2024-03/msg00065.html>
Cc: "G. Branden Robinson" <[email protected]>
@@ Commit message
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/include/lib.h ##
6: dd5d8b1c0 ! 6: 3553a1916 [indxbib]: Don't else after [[noreturn]]
@@ Metadata
## Commit message ##
[indxbib]: Don't else after [[noreturn]]
+ Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.")
Link: <https://savannah.gnu.org/bugs/?65452>
Cc: "G. Branden Robinson" <[email protected]>
Cc: Dave Kemper <[email protected]>
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/utils/indxbib/indxbib.cpp ##
7: 2ea8b950b ! 7: a21c50302 [indxbib]: Clear errno before calling strtol(3)
@@ Commit message
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/utils/indxbib/indxbib.cpp ##
8: 6a02a0b3b ! 8: d1fa83ae4 [indxbib]: Remove dead code
@@ Commit message
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/utils/indxbib/indxbib.cpp ##
9: dd7d94b19 ! 9: 7416f8d15 [indxbib]: Collapse related tests
@@ Commit message
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/utils/indxbib/indxbib.cpp ##
10: e19b783c0 ! 10: ff0b5e068 [grolbp]: Fix range check after strtol(3)
@@ Commit message
In case INT_MAX==LONG_MAX, we need to check for ERANGE to reject
high values. The test 'n > INT_MAX' would never be true.
- Fixes: d21a9dbc7a83 ("Werner LEMBERG <[email protected]>")
+ Fixes: d21a9dbc7a83 ("* src/devices/grolbp/lbp.cc: (long_options): Add
-w/--linewidth option.")
Link: <https://savannah.gnu.org/bugs/?65451>
Link: <https://savannah.gnu.org/bugs/?65452>
Cc: "G. Branden Robinson" <[email protected]>
@@ Commit message
Cc: "James K. Lowden" <[email protected]>
Cc: Colin Watson <[email protected]>
Cc: Werner LEMBERG <[email protected]>
+ Cc: James Clark <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
## src/devices/grolbp/lbp.cpp ##
--
2.43.0
signature.asc
Description: PGP signature
